Yuxuan Wang created THRIFT-5609:
---
Summary: TJSONProtocol and TSimpleJSONProtocol are unsafe to be
used with TDeserializerPool and TSerializerPool
Key: THRIFT-5609
URL:
[
https://issues.apache.org/jira/browse/THRIFT-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576069#comment-17576069
]
Yuxuan Wang commented on THRIFT-5609:
-
Also updated the issue to be only about TJSONProtocol and
[
https://issues.apache.org/jira/browse/THRIFT-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576069#comment-17576069
]
Yuxuan Wang edited comment on THRIFT-5609 at 8/5/22 10:37 PM:
--
Also updated
[
https://issues.apache.org/jira/browse/THRIFT-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuxuan Wang reassigned THRIFT-5609:
---
Assignee: Yuxuan Wang
> TJSONProtocol and TSimpleJSONProtocol are unsafe to be used with
[
https://issues.apache.org/jira/browse/THRIFT-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576063#comment-17576063
]
Duru Can Celasun commented on THRIFT-5609:
--
4 is clean and safe, but 2 is cleaner. Can you
fishy opened a new pull request, #2639:
URL: https://github.com/apache/thrift/pull/2639
Client: go
Add Reset to TJSONProtocol, and call it in deserializer and serializer
to make sure that it's always safe to be used in the pool version.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/THRIFT-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576067#comment-17576067
]
Yuxuan Wang commented on THRIFT-5609:
-
Also just found out THRIFT-3735 when I'm trying to work on a
[
https://issues.apache.org/jira/browse/THRIFT-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576066#comment-17576066
]
Yuxuan Wang commented on THRIFT-5609:
-
It looks like there are cases we call ReadStructBegin after
[
https://issues.apache.org/jira/browse/THRIFT-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuxuan Wang updated THRIFT-5609:
Summary: TJSONProtocol is unsafe to be used with TDeserializerPool (was:
TJSONProtocol and