[jira] [Created] (THRIFT-2475) c_glib: buffered_transport_write function return always TRUE.

2014-04-17 Thread Jaesang Kim (JIRA)
Jaesang Kim created THRIFT-2475: --- Summary: c_glib: buffered_transport_write function return always TRUE. Key: THRIFT-2475 URL: https://issues.apache.org/jira/browse/THRIFT-2475 Project: Thrift

AW: [jira] [Created] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Jens Geyer
Hi Vitali, di you talk about Java? There is no component indicated at the ticket. Thanks Jens Von: Vitali Lovich (JIRA) Gesendet: 17.04.2014 01:56 An: dev@thrift.apache.org Betreff: [jira] [Created] (THRIFT-2473) _isset entries shouldn't be generated for

[GitHub] thrift pull request: THRIFT-2470: Stop THttpHandler from swallowin...

2014-04-17 Thread adam-resdiary
Github user adam-resdiary commented on the pull request: https://github.com/apache/thrift/pull/100#issuecomment-40691732 I only ran the tests in VS, but I can certainly try them out in MonoDevelop on my mac when I get a chance. I figured that since NUnit and Moq are pretty standard

[jira] [Commented] (THRIFT-2470) THttpHandler swallows exceptions from processor

2014-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972391#comment-13972391 ] ASF GitHub Bot commented on THRIFT-2470: Github user adam-resdiary commented on

[jira] [Commented] (THRIFT-2457) fbthrift float

2014-04-17 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972925#comment-13972925 ] Ben Craig commented on THRIFT-2457: --- I do have a concern about adding new types. Say

[jira] [Updated] (THRIFT-2472) Thrift types that don't participate in inheritance shouldn't have virtual destructors

2014-04-17 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça updated THRIFT-2472: -- Component/s: C++ - Compiler Thrift types that don't participate in inheritance

Jenkins build is back to normal : Thrift-Compiler-Windows #1186

2014-04-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/Thrift-Compiler-Windows/1186/changes

Build failed in Jenkins: Thrift #1135

2014-04-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/Thrift/1135/changes Changes: [roger] THRIFT-847 Test Framework harmonization across all languages -- [...truncated 7144 lines...] File ./../../lib/py/build/lib.linux-x86_64-2.7/thrift/transport/TTransport.py, line

Re: [jira] [Created] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Nevo Hed
Also, sample .thrift file showing the issue I have seen cases where there was some __isset confusion with complex types (long ago, don't remember the details) On Thu, Apr 17, 2014 at 3:16 AM, Jens Geyer jensge...@hotmail.com wrote: Hi Vitali, di you talk about Java? There is no component

[jira] [Commented] (THRIFT-847) Test Framework harmonization across all languages

2014-04-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973390#comment-13973390 ] Hudson commented on THRIFT-847: --- FAILURE: Integrated in Thrift #1135 (See

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-17 Thread Dave Watson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973394#comment-13973394 ] Dave Watson commented on THRIFT-2429: - I like the new proposal since it works for

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-17 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973418#comment-13973418 ] Randy Abernethy commented on THRIFT-2429: - To solve Chris' use case we would need

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973426#comment-13973426 ] Jens Geyer commented on THRIFT-2473: Hi [~vlovich], could you please indicate what

[jira] [Comment Edited] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973426#comment-13973426 ] Jens Geyer edited comment on THRIFT-2473 at 4/17/14 9:23 PM: -

[jira] [Updated] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Vitali Lovich (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitali Lovich updated THRIFT-2473: -- Component/s: C++ - Compiler _isset entries shouldn't be generated for non-optional fields

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Vitali Lovich (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973600#comment-13973600 ] Vitali Lovich commented on THRIFT-2473: --- Sorry. It's in C++. The __isset field is

[GitHub] thrift pull request: Go inlines

2014-04-17 Thread apesternikov
GitHub user apesternikov opened a pull request: https://github.com/apache/thrift/pull/101 Go inlines THRIFT-2451 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apesternikov/thrift go_inlines Alternatively you can review and

[jira] [Commented] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped t

2014-04-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973622#comment-13973622 ] ASF GitHub Bot commented on THRIFT-2451: GitHub user apesternikov opened a pull

[jira] [Created] (THRIFT-2477) thrift --help text with misplaced comma

2014-04-17 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-2477: -- Summary: thrift --help text with misplaced comma Key: THRIFT-2477 URL: https://issues.apache.org/jira/browse/THRIFT-2477 Project: Thrift Issue Type: Bug

[jira] [Updated] (THRIFT-2477) thrift --help text with misplaced comma

2014-04-17 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2477: --- Attachment: THRIFT-2477_misplaced_comma_in_help.patch thrift --help text with misplaced comma

[jira] [Resolved] (THRIFT-2477) thrift --help text with misplaced comma

2014-04-17 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2477. Resolution: Fixed Committed, thanks to [Martin

[jira] [Created] (THRIFT-2478) Thrift c_glib binary protocol may go to infinite loop for bad input

2014-04-17 Thread Xiaodong Ma (JIRA)
Xiaodong Ma created THRIFT-2478: --- Summary: Thrift c_glib binary protocol may go to infinite loop for bad input Key: THRIFT-2478 URL: https://issues.apache.org/jira/browse/THRIFT-2478 Project: Thrift

[jira] [Updated] (THRIFT-2478) Thrift c_glib binary protocol may go to infinite loop for bad input

2014-04-17 Thread Xiaodong Ma (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong Ma updated THRIFT-2478: Attachment: fix_c_glib_binary_protocol_data_fuzzing_cause_infinite_loop.diff Tested by feeding

[jira] [Commented] (THRIFT-2477) thrift --help text with misplaced comma

2014-04-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973732#comment-13973732 ] Hudson commented on THRIFT-2477: SUCCESS: Integrated in Thrift #1136 (See

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Nevo Hed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973735#comment-13973735 ] Nevo Hed commented on THRIFT-2473: -- [~vlovich], Still need a sample Compiling this

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-17 Thread Vitali Lovich (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973755#comment-13973755 ] Vitali Lovich commented on THRIFT-2473: --- The struct in question doesn't specify