AW: [jira] [Commented] (THRIFT-2571) Simplify cross compilation using CMake

2014-06-12 Thread Jens Geyer
Good question. I have read about cmake and my overall impression was, that it could be a really good thing to switch. OTOH my experiences with both cmake and the auto-stuff we are currently using is way limited, so I'm speaking purely out of theory. Last not least, as the saying goes, it is

Re: [jira] [Commented] (THRIFT-2571) Simplify cross compilation using CMake

2014-06-12 Thread Roger Meier
I think Cmake is worth to add as a additional option beside of autotools. It will simplify developers and users life in many cases. I see no problem to have CMake beside of autotools as long as we integrate it properly(e.g. read Version from configure.ac, etc.). = both need to be integrated into

[GitHub] thrift pull request: Implement Thrift.Protocol.prototype.skip() fo...

2014-06-12 Thread hyungsul
GitHub user hyungsul opened a pull request: https://github.com/apache/thrift/pull/139 Implement Thrift.Protocol.prototype.skip() for JavaScript library Thrift.Protocol.prototype.skip was not implemented yet. Due to the exception that the previous implementation throws, Thrift

[jira] [Comment Edited] (THRIFT-2520) cpp:cob_style generates incorrect .tcc file

2014-06-12 Thread Nobuaki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029206#comment-14029206 ] Nobuaki Sukegawa edited comment on THRIFT-2520 at 6/12/14 2:36 PM:

[jira] [Commented] (THRIFT-2520) cpp:cob_style generates incorrect .tcc file

2014-06-12 Thread Nobuaki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029206#comment-14029206 ] Nobuaki Sukegawa commented on THRIFT-2520: -- Is it about the travis error or are

[GitHub] thrift pull request: Implement Thrift.Protocol.prototype.skip() fo...

2014-06-12 Thread hyungsul
Github user hyungsul closed the pull request at: https://github.com/apache/thrift/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: Implement Thrift.Protocol.prototype.skip() fo...

2014-06-12 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/139#issuecomment-45955651 [Could you add an JIRA ticket?](http://thrift.apache,.org/docs/HowToContribute)? Furthermore, an associated test case would be great as well! Thanks! --- If

[GitHub] thrift pull request: Update simple_json_protocol.go

2014-06-12 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/134#issuecomment-45955641 [Could you add an JIRA ticket?](http://thrift.apache,.org/docs/HowToContribute)? Furthermore, an associated test case would be great as well! Thanks! --- If

[jira] [Closed] (THRIFT-2570) Wrong URL given in http://thrift.apache.org/developers

2014-06-12 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2570. -- Resolution: Cannot Reproduce Can't reproduce. Feel free to re-open if new information becomes

[jira] [Commented] (THRIFT-1682) Multiple thread calling a Service function unsafely causes message corruption and terminates with Broken Pipe

2014-06-12 Thread Juan Moreno (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029994#comment-14029994 ] Juan Moreno commented on THRIFT-1682: - A Socket is not a thread-safe, share-able

[jira] [Commented] (THRIFT-1682) Multiple thread calling a Service function unsafely causes message corruption and terminates with Broken Pipe

2014-06-12 Thread Juan Moreno (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029993#comment-14029993 ] Juan Moreno commented on THRIFT-1682: - Yes this is definitely intended behavior. I

[jira] [Created] (THRIFT-2574) Compiler option to generate namespace directories for Ruby

2014-06-12 Thread Andrew Bloomgarden (JIRA)
Andrew Bloomgarden created THRIFT-2574: -- Summary: Compiler option to generate namespace directories for Ruby Key: THRIFT-2574 URL: https://issues.apache.org/jira/browse/THRIFT-2574 Project:

[jira] [Updated] (THRIFT-2574) Compiler option to generate namespace directories for Ruby

2014-06-12 Thread Andrew Bloomgarden (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Bloomgarden updated THRIFT-2574: --- Labels: compiler namespaces patch ruby (was: compiler namespaces patch) Compiler

[jira] [Updated] (THRIFT-2574) Compiler option to generate namespace directories for Ruby

2014-06-12 Thread Andrew Bloomgarden (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Bloomgarden updated THRIFT-2574: --- Attachment: thrift-2574.diff thrift-2574-formatted-patch.patch

[GitHub] thrift pull request: rb:namespaced: generate Ruby files in idiomat...

2014-06-12 Thread aughr
GitHub user aughr opened a pull request: https://github.com/apache/thrift/pull/140 rb:namespaced: generate Ruby files in idiomatic namespaced directories. Idiomatic Ruby expects that namespaces are mirrored on the filesystem. This new namespaced option lets that happen.

[jira] [Commented] (THRIFT-2574) Compiler option to generate namespace directories for Ruby

2014-06-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030249#comment-14030249 ] ASF GitHub Bot commented on THRIFT-2574: GitHub user aughr opened a pull request: