[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

2015-04-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490814#comment-14490814 ] James E. King, III commented on THRIFT-3084: Hi Randy, I do understand what

[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

2015-04-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490284#comment-14490284 ] James E. King, III commented on THRIFT-3084: I believe that instead of

[jira] [Updated] (THRIFT-3084) C++ add concurrent client limit to threaded servers

2015-04-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3084: --- Description: The TThreadedServer and TThreadPoolServer do not impose limits on the

[jira] [Created] (THRIFT-3090) cmake build is broken

2015-04-10 Thread Marco Molteni (JIRA)
Marco Molteni created THRIFT-3090: - Summary: cmake build is broken Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-3090) cmake build is broken

2015-04-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490402#comment-14490402 ] James E. King, III commented on THRIFT-3090: Unless it was something added

[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)

2015-04-10 Thread marco-m
GitHub user marco-m opened a pull request: https://github.com/apache/thrift/pull/434 Fix THRIFT-3090 (cmake build is broken) Problem found and fixed on Mac OS X 10.10.3, but at least the link problems must happen on every OS. You can merge this pull request into a Git repository

[jira] [Commented] (THRIFT-3090) cmake build is broken

2015-04-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490434#comment-14490434 ] ASF GitHub Bot commented on THRIFT-3090: GitHub user marco-m opened a pull

[jira] [Commented] (THRIFT-3090) cmake build is broken

2015-04-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490442#comment-14490442 ] James E. King, III commented on THRIFT-3090: So the issue is with clang then?

[jira] [Comment Edited] (THRIFT-3090) cmake build is broken

2015-04-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490442#comment-14490442 ] James E. King, III edited comment on THRIFT-3090 at 4/10/15 10:04 PM:

[GitHub] thrift pull request: THRIFT-3076 Compatibility with Haxe 3.2.0

2015-04-10 Thread Jens-G
GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/435 THRIFT-3076 Compatibility with Haxe 3.2.0 Client: Haxe Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift

[jira] [Commented] (THRIFT-3076) Compatibility with Haxe 3.2.0

2015-04-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490567#comment-14490567 ] ASF GitHub Bot commented on THRIFT-3076: GitHub user Jens-G opened a pull

[GitHub] thrift pull request: THRIFT-3076 Compatibility with Haxe 3.2.0

2015-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3076) Compatibility with Haxe 3.2.0

2015-04-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490572#comment-14490572 ] ASF GitHub Bot commented on THRIFT-3076: Github user asfgit closed the pull

[jira] [Resolved] (THRIFT-3076) Compatibility with Haxe 3.2.0

2015-04-10 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3076. Resolution: Fixed Committed. Compatibility with Haxe 3.2.0 -

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-04-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490578#comment-14490578 ] ASF GitHub Bot commented on THRIFT-2441: Github user ben-craig commented on a

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-10 Thread ben-craig
Github user ben-craig commented on a diff in the pull request: https://github.com/apache/thrift/pull/424#discussion_r28189195 --- Diff: lib/cpp/src/thrift/server/TSimpleServer.cpp --- @@ -88,7 +88,7 @@ void TSimpleServer::serve() { string errStr = string(Some kind of

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-04-10 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490579#comment-14490579 ] Ben Craig commented on THRIFT-2441: --- +1 Cannot shutdown TThreadedServer when clients

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-10 Thread ben-craig
Github user ben-craig commented on a diff in the pull request: https://github.com/apache/thrift/pull/433#discussion_r28189373 --- Diff: lib/cpp/src/thrift/server/TThreadPoolServer.cpp --- @@ -146,9 +73,12 @@ void TThreadPoolServer::serve() { shared_ptrTProcessor

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

2015-04-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490584#comment-14490584 ] ASF GitHub Bot commented on THRIFT-3081: Github user ben-craig commented on a

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-10 Thread ben-craig
Github user ben-craig commented on a diff in the pull request: https://github.com/apache/thrift/pull/433#discussion_r28189526 --- Diff: lib/cpp/src/thrift/server/TConnectedClient.cpp --- @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

2015-04-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490593#comment-14490593 ] ASF GitHub Bot commented on THRIFT-3081: Github user ben-craig commented on a

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

2015-04-10 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490598#comment-14490598 ] Ben Craig commented on THRIFT-3081: --- I approve of the general direction of the recently

[jira] [Commented] (THRIFT-3076) Compatibility with Haxe 3.2.0

2015-04-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490609#comment-14490609 ] Hudson commented on THRIFT-3076: SUCCESS: Integrated in Thrift #1498 (See

[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

2015-04-10 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490651#comment-14490651 ] Randy Abernethy commented on THRIFT-3084: - Hey Ben: I agree with keeping the

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

2015-04-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490707#comment-14490707 ] James E. King, III commented on THRIFT-3081: Thanks, however even on the

[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

2015-04-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490710#comment-14490710 ] James E. King, III commented on THRIFT-3084: The proper way to do this would

[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers

2015-04-10 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490722#comment-14490722 ] Randy Abernethy commented on THRIFT-3084: - Hey James: I have a different view on