[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-22 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/456#issuecomment-95180226 Need help - all of the "make cross" csharp tests appear to be failing in Travis CI but I do not believe the changes I made would have impacted them at all (this pull requ

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507077#comment-14507077 ] ASF GitHub Bot commented on THRIFT-2850: Github user jeking3 commented on the pul

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507062#comment-14507062 ] ASF GitHub Bot commented on THRIFT-2441: Github user jeking3 commented on the pul

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-22 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-95177941 To make the (hopefully) impending merge easier, I merged master into this branch and there was one conflict to resolve so I took care of it. --- If your project is set u

[jira] [Closed] (THRIFT-3104) Include TZlibTransport in Windows C++ library

2015-04-22 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-3104. -- > Include TZlibTransport in Windows C++ library > -

[jira] [Resolved] (THRIFT-3104) Include TZlibTransport in Windows C++ library

2015-04-22 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3104. Resolution: Won't Fix The cmake build environment makes a "thriftz" library that ad

[GitHub] thrift pull request: Thrift-1857: Python 3 support, redux

2015-04-22 Thread jeroenvlek
Github user jeroenvlek commented on the pull request: https://github.com/apache/thrift/pull/213#issuecomment-95121808 The commit 3b4b03e introduces a conversion to bytearray in TBinaryProtocol.writeString(): ```python # after commit 3b4b03e and 3d912d7 def writeSt

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506788#comment-14506788 ] ASF GitHub Bot commented on THRIFT-2850: Github user jeking3 commented on the pul

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-22 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506790#comment-14506790 ] ASF GitHub Bot commented on THRIFT-2850: GitHub user jeking3 reopened a pull requ

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-04-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506789#comment-14506789 ] ASF GitHub Bot commented on THRIFT-2850: Github user jeking3 closed the pull requ

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-22 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/456 THRIFT-2850 cmake win cpp library and unit tests I made changes to the cmake environment so that cmake can build the compiler, static libraries and unit tests on Windows. In my testing I found t

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-22 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/456#issuecomment-95120411 csharp build failed and I believe it is unrelated, recycling pull request to rebuild --- If your project is set up for it, you can reply to this email and have your repl