[jira] [Commented] (THRIFT-3359) Binary field incompatibilities

[ https://issues.apache.org/jira/browse/THRIFT-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935222#comment-14935222 ] Nobuaki Sukegawa commented on THRIFT-3359: -- Yes, we should choose whatever works best for us. I

[jira] [Commented] (THRIFT-3359) Binary field incompatibilities

[ https://issues.apache.org/jira/browse/THRIFT-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935020#comment-14935020 ] Jens Geyer commented on THRIFT-3359: It is mandatory because some external entity said so. I don't

[GitHub] thrift pull request: THRIFT-3306: Java: TBinaryProtocol: Use a sin...

Github user evanj commented on the pull request: https://github.com/apache/thrift/pull/596#issuecomment-144037231 Note: the Travis CI build may have failed, but it failed to compile some parts of the C++ code, so I suspect this is due to a flaky test and is not legitimate, since I

[jira] [Commented] (THRIFT-3306) Java: TBinaryProtocol: Use 1 temp buffer instead of allocating 8

[ https://issues.apache.org/jira/browse/THRIFT-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935042#comment-14935042 ] ASF GitHub Bot commented on THRIFT-3306: Github user evanj commented on the pull request:

[jira] [Commented] (THRIFT-3346) c_glib: Tutorials example crashes saying Calculator.ping implementation returned FALSE but did not set an error

[ https://issues.apache.org/jira/browse/THRIFT-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934913#comment-14934913 ] AkhlD commented on THRIFT-3346: --- Unfortunately, someone has to add testBinary() call to the example

[jira] [Commented] (THRIFT-2242) Generate C++11 code

[ https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934886#comment-14934886 ] Konrad Grochowski commented on THRIFT-2242: --- thrift map & set are unordered by definition. So

[jira] [Assigned] (THRIFT-3361) Improve C# library

[ https://issues.apache.org/jira/browse/THRIFT-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-3361: -- Assignee: Jens Geyer > Improve C# library > -- > > Key:

[jira] [Commented] (THRIFT-2958) connect() interrupted is not handled properly in TSocket

[ https://issues.apache.org/jira/browse/THRIFT-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935927#comment-14935927 ] James E. King, III commented on THRIFT-2958: Are you suggesting that we should also check for

[jira] [Commented] (THRIFT-3237) Fix TNamedPipeServer::createNamedPipe memory leak

[ https://issues.apache.org/jira/browse/THRIFT-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935909#comment-14935909 ] ASF GitHub Bot commented on THRIFT-3237: GitHub user jeking3 opened a pull request:

[jira] [Updated] (THRIFT-3036) create official haxelib Thrift package

[ https://issues.apache.org/jira/browse/THRIFT-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3036: --- Assignee: (was: Jens Geyer) > create official haxelib Thrift package >

[jira] [Assigned] (THRIFT-3237) Fix TNamedPipeServer::createNamedPipe memory leak

[ https://issues.apache.org/jira/browse/THRIFT-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3237: -- Assignee: James E. King, III > Fix TNamedPipeServer::createNamedPipe memory

[jira] [Commented] (THRIFT-424) Steal ProtocolBuffers' VarInt implementation for C++

[ https://issues.apache.org/jira/browse/THRIFT-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935948#comment-14935948 ] James E. King, III commented on THRIFT-424: --- [~jfarrell] is this something we want to keep in

[GitHub] thrift pull request: THRIFT-3237: Fix memory leak in pipe server

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/632 THRIFT-3237: Fix memory leak in pipe server You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3237 Alternatively

[GitHub] thrift pull request: Bugfix/thrift 3237 fix memory leak in pipe se...

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/631 Bugfix/thrift 3237 fix memory leak in pipe server (Windows) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3237

[jira] [Commented] (THRIFT-3362) make check fails for C++

[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935919#comment-14935919 ] Jens Geyer commented on THRIFT-3362: Full log: {code}

[jira] [Assigned] (THRIFT-2536) new TSocket, uninitialised value reported by valgrind

[ https://issues.apache.org/jira/browse/THRIFT-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-2536: -- Assignee: James E. King, III > new TSocket, uninitialised value reported by

[jira] [Commented] (THRIFT-2342) Add __FILE__ and __LINE__ to Thrift C++ excpetions

[ https://issues.apache.org/jira/browse/THRIFT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935958#comment-14935958 ] Konrad Grochowski commented on THRIFT-2342: --- +1 > Add __FILE__ and __LINE__ to Thrift C++

[jira] [Commented] (THRIFT-3237) Fix TNamedPipeServer::createNamedPipe memory leak

[ https://issues.apache.org/jira/browse/THRIFT-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935906#comment-14935906 ] ASF GitHub Bot commented on THRIFT-3237: Github user jeking3 closed the pull request at:

[GitHub] thrift pull request: THRIFT-3237 fix memory leak in pipe server (W...

Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/631 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3237) Fix TNamedPipeServer::createNamedPipe memory leak

[ https://issues.apache.org/jira/browse/THRIFT-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935903#comment-14935903 ] James E. King, III commented on THRIFT-3237: https://github.com/apache/thrift/pull/631 > Fix

[jira] [Commented] (THRIFT-2028) Cleanup threading headers / libraries

[ https://issues.apache.org/jira/browse/THRIFT-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935913#comment-14935913 ] James E. King, III commented on THRIFT-2028: Another suggestion would be to eliminate the

[jira] [Created] (THRIFT-3362) make check fails for C++

Jens Geyer created THRIFT-3362: -- Summary: make check fails for C++ Key: THRIFT-3362 URL: https://issues.apache.org/jira/browse/THRIFT-3362 Project: Thrift Issue Type: Bug Components:

[jira] [Commented] (THRIFT-2342) Add __FILE__ and __LINE__ to Thrift C++ excpetions

[ https://issues.apache.org/jira/browse/THRIFT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935947#comment-14935947 ] James E. King, III commented on THRIFT-2342: I don't think it is wise to add a backtrace to

[jira] [Closed] (THRIFT-424) Steal ProtocolBuffers' VarInt implementation for C++

[ https://issues.apache.org/jira/browse/THRIFT-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-424. --- Resolution: Fixed Fix Version/s: 0.9.3 > Steal ProtocolBuffers' VarInt implementation for C++

[jira] [Resolved] (THRIFT-3323) Python library does not handle escaped forward slash ("/") in JSON

[ https://issues.apache.org/jira/browse/THRIFT-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3323. Resolution: Fixed Fix Version/s: 0.9.4 Committed, thank you! > Python library does not

[jira] [Commented] (THRIFT-3359) Binary field incompatibilities

[ https://issues.apache.org/jira/browse/THRIFT-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935632#comment-14935632 ] Jens Geyer commented on THRIFT-3359: +1 > Binary field incompatibilities >

[jira] [Commented] (THRIFT-3321) Thrift can't be added as a subdirectory of another CMake-based project

[ https://issues.apache.org/jira/browse/THRIFT-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935701#comment-14935701 ] Hudson commented on THRIFT-3321: SUCCESS: Integrated in Thrift #1668 (See

[jira] [Commented] (THRIFT-3323) Python library does not handle escaped forward slash ("/") in JSON

[ https://issues.apache.org/jira/browse/THRIFT-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935625#comment-14935625 ] Roger Meier commented on THRIFT-3323: - +1 for this patch from Nepal! *make cross* passed on my

[jira] [Resolved] (THRIFT-3321) Thrift can't be added as a subdirectory of another CMake-based project

[ https://issues.apache.org/jira/browse/THRIFT-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3321. - Resolution: Fixed Assignee: Roger Meier committed thanks > Thrift can't be added as a

[jira] [Commented] (THRIFT-3323) Python library does not handle escaped forward slash ("/") in JSON

[ https://issues.apache.org/jira/browse/THRIFT-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935707#comment-14935707 ] Jens Geyer commented on THRIFT-3323: Thanks for the reminder + thanks for testing! Committing ... >

[GitHub] thrift pull request: THRIFT-3323 - Update TJSONProtocol.py

Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/605#issuecomment-144166076 Committed per 15c400488550d565e5436f1e77ad3fdddfd4ef66 Could you pleaswe close the PR manually? Thanks! --- If your project is set up for it, you can reply to this

[jira] [Commented] (THRIFT-3323) Python library does not handle escaped forward slash ("/") in JSON

[ https://issues.apache.org/jira/browse/THRIFT-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935715#comment-14935715 ] ASF GitHub Bot commented on THRIFT-3323: Github user Jens-G commented on the pull request:

[jira] [Commented] (THRIFT-3323) Python library does not handle escaped forward slash ("/") in JSON

[ https://issues.apache.org/jira/browse/THRIFT-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935735#comment-14935735 ] Hudson commented on THRIFT-3323: SUCCESS: Integrated in Thrift #1669 (See

[GitHub] thrift pull request: THRIFT-3361 Improve C# library

Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/630#issuecomment-144174886 Mono refreshes me with this (absolutely correct) warning: src/Transport/TTLSSocket.cs(322,47): warning CS0219: The variable `certs' is assigned

[jira] [Commented] (THRIFT-3361) Improve C# library

[ https://issues.apache.org/jira/browse/THRIFT-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935765#comment-14935765 ] ASF GitHub Bot commented on THRIFT-3361: Github user Jens-G commented on the pull request: