[jira] [Commented] (THRIFT-3943) Coverity Scan identified some high severity defects

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15550381#comment-15550381 ] ASF GitHub Bot commented on THRIFT-3943: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1109: THRIFT-3943: resolve some high severity outstanding defe...

2016-10-05 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1109 Well, putting in that delete of xceptions_ certainly didn't fare well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (THRIFT-3942) TSSLSocket does not honor send and receive timeouts

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549844#comment-15549844 ] ASF GitHub Bot commented on THRIFT-3942: Github user tpcwang commented on a diff in the pull

[GitHub] thrift pull request #1108: THRIFT-3942 Make TSSLSocket honor send and receiv...

2016-10-05 Thread tpcwang
Github user tpcwang commented on a diff in the pull request: https://github.com/apache/thrift/pull/1108#discussion_r82062644 --- Diff: lib/cpp/test/TSSLSocketInterruptTest.cpp --- @@ -57,12 +54,6 @@ struct GlobalFixtureSSL BOOST_TEST_MESSAGE(boost::format("argv[%1%] =

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549639#comment-15549639 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

2016-10-05 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1103 How will a decision be made as to whether this gets into 0.10.0 or not? Obviously it is not a trivial change but I think it solidifies parts of the C++ engine that have been neglected; adds much

[jira] [Commented] (THRIFT-3943) Coverity Scan identified some high severity defects

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549630#comment-15549630 ] ASF GitHub Bot commented on THRIFT-3943: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1109: THRIFT-3943: resolve some high severity outstandi...

2016-10-05 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1109 THRIFT-3943: resolve some high severity outstanding defects identified by coverity scan https://scan7.coverity.com/reports.htm#v15415/p10216/fileInstanceId=3547531=1023429=748818

[jira] [Created] (THRIFT-3943) Coverity Scan identified some high severity defects

2016-10-05 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-3943: -- Summary: Coverity Scan identified some high severity defects Key: THRIFT-3943 URL: https://issues.apache.org/jira/browse/THRIFT-3943 Project: Thrift

[jira] [Commented] (THRIFT-3942) TSSLSocket does not honor send and receive timeouts

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549451#comment-15549451 ] ASF GitHub Bot commented on THRIFT-3942: GitHub user tpcwang opened a pull request:

[GitHub] thrift pull request #1108: THRIFT-3942 Make TSSLSocket honor send and receiv...

2016-10-05 Thread tpcwang
GitHub user tpcwang opened a pull request: https://github.com/apache/thrift/pull/1108 THRIFT-3942 Make TSSLSocket honor send and receive timeouts You can merge this pull request into a Git repository by running: $ git pull https://github.com/tpcwang/thrift THRIFT-3942

[jira] [Created] (THRIFT-3942) TSSLSocket does not honor send and receive timeouts

2016-10-05 Thread Ted Wang (JIRA)
Ted Wang created THRIFT-3942: Summary: TSSLSocket does not honor send and receive timeouts Key: THRIFT-3942 URL: https://issues.apache.org/jira/browse/THRIFT-3942 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-3941) WinXP version of thrift_poll() relies on undefined behavior by passing a destructed variable to select()

2016-10-05 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548588#comment-15548588 ] James E. King, III commented on THRIFT-3941: This would be an issue that [Coverity

[jira] [Resolved] (THRIFT-3941) WinXP version of thrift_poll() relies on undefined behavior by passing a destructed variable to select()

2016-10-05 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3941. Resolution: Fixed Fix Version/s: 0.10.0 Committed, thank you both. > WinXP version of

[jira] [Commented] (THRIFT-3941) WinXP version of thrift_poll() relies on undefined behavior by passing a destructed variable to select()

2016-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548328#comment-15548328 ] ASF GitHub Bot commented on THRIFT-3941: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1107: THRIFT-3941 WinXP version of thrift_poll() relies...

2016-10-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is