[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1156 > Good intentions, absolutely, but the implementation .. FWIW, I agree. However, we still need a solution and as I explained above, we don't have a way of returning an error here. That leav

[jira] [Commented] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

[ https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823547#comment-15823547 ] ASF GitHub Bot commented on THRIFT-4011: Github user dcelasun commented on the is

[jira] [Commented] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

[ https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823384#comment-15823384 ] ASF GitHub Bot commented on THRIFT-4011: Github user Jens-G commented on the issu

[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1156 Oopsie. After I read the word "map" above I must have been mentally switched to maps somehow. My mistake. Nevertheless what I said about panic and errors in general above still holds true.

[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...

Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1088 Hi @Jens-G Done - you can check master in https://github.com/vgotra/thrift. Added framed transport and added sample of usage of MultiplexedProtocol. Also updated docs for library.

[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...

Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1088 Yes - I can. Not sure about multiplex. I will check it and ping you later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI

[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823166#comment-15823166 ] Chandler May commented on THRIFT-4029: -- The new zip distribution works for me. > Ac

[jira] [Commented] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

[ https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823163#comment-15823163 ] ASF GitHub Bot commented on THRIFT-4011: Github user dcelasun commented on the is

[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1156 Hey @Jens-G, I'm not sure I follow you, what does this have anything to do with maps? Assuming you meant sets, the docs say: > An unordered set of unique elements. Translates to an STL set,

[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...

Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1088 Could you extract the other stuff (e.g. framed transport, multiplex, ...) into a separate PR that works with the current Thrift code base? Smaller PRs are easier to review, and we get at least these

[jira] [Commented] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

[ https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823148#comment-15823148 ] ASF GitHub Bot commented on THRIFT-4011: Github user Jens-G commented on the issu

[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1156 http://thrift.apache.org/docs/types states that (as one would expect) a Thrift map is defined as "A map of **strictly unique keys** to values. Translates to an STL map, Java HashMap, PHP associative

[GitHub] thrift pull request #1153: fix a bug in windows

Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1153#discussion_r96138653 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() { ownEventBase_ = f

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823138#comment-15823138 ] ASF GitHub Bot commented on THRIFT-2945: Github user Jens-G commented on the issu

[GitHub] thrift issue #1147: THRIFT-2945 Add Rust support

Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1147 @all: Everyone happy with it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[jira] [Commented] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

[ https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823094#comment-15823094 ] ASF GitHub Bot commented on THRIFT-4011: GitHub user dcelasun opened a pull reque

[GitHub] thrift pull request #1156: THRIFT-4011 Use slices for Thrift sets

GitHub user dcelasun opened a pull request: https://github.com/apache/thrift/pull/1156 THRIFT-4011 Use slices for Thrift sets As discussed in [THRIFT-4011](https://issues.apache.org/jira/browse/THRIFT-4011), this commit changes the Go generator to use slices, instead of maps for Th