[jira] [Created] (THRIFT-4063) Sources for libthrift 0.10.0 are missing from Maven Central

2017-01-31 Thread Zac Bentley (JIRA) 
Zac Bentley created THRIFT-4063:
---

 Summary: Sources for libthrift 0.10.0 are missing from Maven 
Central
 Key: THRIFT-4063
 URL: https://issues.apache.org/jira/browse/THRIFT-4063
 Project: Thrift
  Issue Type: Bug
  Components: Build Process
Affects Versions: 0.10.0
Reporter: Zac Bentley
Priority: Minor


The other versions of libthrift have source JARs on Maven Central; 0.10.0 does 
not.

Could sources be published?

Alternatively, is there some way to wire up the Git repository as a source JAR, 
using e.g. jitpack.io's maven dependency-from-git-repo converter?

Tentatively classifying this as a bug, since it seems inconsistent with all the 
other releases on Central.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] (THRIFT-4046) MinGW with gcc 6.2 does not compile on Windows

2017-01-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847535#comment-15847535
 ] 

ASF GitHub Bot commented on THRIFT-4046:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1171


> MinGW with gcc 6.2 does not compile on Windows
> --
>
> Key: THRIFT-4046
> URL: https://issues.apache.org/jira/browse/THRIFT-4046
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process, C++ - Library
>Affects Versions: 0.9.3, 0.10.0
> Environment: Windows, MinGW-64/MSYS2 2016-10-26 (gcc 6.3)
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> There are numerous issues building the Windows C++ library with MinGW and gcc 
> 6.3.  They need to be resolved together so I am combining them into a single 
> Jira item.  See the linked, superceded items for details.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1171: THRIFT-4046 fix PlatformSocket.h for mingw64/msys...

2017-01-31 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1171


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] (THRIFT-4046) MinGW with gcc 6.2 does not compile on Windows

2017-01-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847530#comment-15847530
 ] 

ASF GitHub Bot commented on THRIFT-4046:


Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1171#discussion_r98771831
  
--- Diff: build/cmake/README-MSYS2.md ---
@@ -0,0 +1,63 @@
+
+
+# Building thrift on Windows (MinGW64/MSYS2)
+
+Thrift uses cmake to make it easier to build the project on multiple 
platforms, however to build a fully functional and production ready thrift on 
Windows requires a number of third party libraries to be obtained.  Once third 
party libraries are ready, the right combination of options must be passed to 
cmake in order to generate the correct environment.
+
+> Note: libevent and libevent-devel do not work with this toolchain as 
they do not properly detect mingw64 and expect some headers to exist that do 
not, so the non-blocking server is not currently built into this solution.
+
+## MSYS2
+
+Download and fully upgrade msys2 following the instructions at:
+
+https://msys2.github.io/
+
+Install the necessary toolchain items for C++:
+
+$ pacman -S bison flex openssl openssl-devel \
+mingw-w64-x86_64-boost mingw-w64-x86_64-cmake \
+mingw-w64-x86_64-toolchain zlib zlib-devel
+
+Update your msys2 bash path to include /mingw64/bin by adding a line to 
your ~/.bash_profiles using this command:
+
+echo "export PATH=/mingw64/bin:\$PATH" >> ~/.bash_profile
+
+After that, close your shell and open a new one.
+
+Use cmake to create a MinGW makefile, out of tree (assumes you are in the 
top level of the thrift source tree):
+
+mkdir ../thrift-build
+cd ../thrift-build
+cmake -G"MinGW Makefiles" 
-DCMAKE_MAKE_PROGRAM=/mingw64/bin/mingw32-make \
+   -DCMAKE_C_COMPILER=x86_64-w64-mingw32-gcc.exe \
+   -DCMAKE_CXX_COMPILER=x86_64-w64-mingw32-g++.exe \
+   -DWITH_BOOSTTHREADS=ON -DWITH_LIBEVENT=OFF \
--- End diff --

BOOST is used in the particular case I have because we have a hardcoded 
windows/config.h we are using instead of relying on the one generated by cmake. 
 There's already a backlog item for this, so given there's a bugfix here + some 
instructions I am going to merge this.


> MinGW with gcc 6.2 does not compile on Windows
> --
>
> Key: THRIFT-4046
> URL: https://issues.apache.org/jira/browse/THRIFT-4046
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process, C++ - Library
>Affects Versions: 0.9.3, 0.10.0
> Environment: Windows, MinGW-64/MSYS2 2016-10-26 (gcc 6.3)
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> There are numerous issues building the Windows C++ library with MinGW and gcc 
> 6.3.  They need to be resolved together so I am combining them into a single 
> Jira item.  See the linked, superceded items for details.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1171: THRIFT-4046 fix PlatformSocket.h for mingw64/msys...

2017-01-31 Thread jeking3 
Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1171#discussion_r98771831
  
--- Diff: build/cmake/README-MSYS2.md ---
@@ -0,0 +1,63 @@
+
+
+# Building thrift on Windows (MinGW64/MSYS2)
+
+Thrift uses cmake to make it easier to build the project on multiple 
platforms, however to build a fully functional and production ready thrift on 
Windows requires a number of third party libraries to be obtained.  Once third 
party libraries are ready, the right combination of options must be passed to 
cmake in order to generate the correct environment.
+
+> Note: libevent and libevent-devel do not work with this toolchain as 
they do not properly detect mingw64 and expect some headers to exist that do 
not, so the non-blocking server is not currently built into this solution.
+
+## MSYS2
+
+Download and fully upgrade msys2 following the instructions at:
+
+https://msys2.github.io/
+
+Install the necessary toolchain items for C++:
+
+$ pacman -S bison flex openssl openssl-devel \
+mingw-w64-x86_64-boost mingw-w64-x86_64-cmake \
+mingw-w64-x86_64-toolchain zlib zlib-devel
+
+Update your msys2 bash path to include /mingw64/bin by adding a line to 
your ~/.bash_profiles using this command:
+
+echo "export PATH=/mingw64/bin:\$PATH" >> ~/.bash_profile
+
+After that, close your shell and open a new one.
+
+Use cmake to create a MinGW makefile, out of tree (assumes you are in the 
top level of the thrift source tree):
+
+mkdir ../thrift-build
+cd ../thrift-build
+cmake -G"MinGW Makefiles" 
-DCMAKE_MAKE_PROGRAM=/mingw64/bin/mingw32-make \
+   -DCMAKE_C_COMPILER=x86_64-w64-mingw32-gcc.exe \
+   -DCMAKE_CXX_COMPILER=x86_64-w64-mingw32-g++.exe \
+   -DWITH_BOOSTTHREADS=ON -DWITH_LIBEVENT=OFF \
--- End diff --

BOOST is used in the particular case I have because we have a hardcoded 
windows/config.h we are using instead of relying on the one generated by cmake. 
 There's already a backlog item for this, so given there's a bugfix here + some 
instructions I am going to merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] (THRIFT-4045) Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix building with Address Sanitizer

2017-01-31 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847516#comment-15847516
 ] 

James E. King, III commented on THRIFT-4045:


This fix causes the following warnings when using the bootstrap.sh script:

{noformat}
jking@jking-dvm51-buildenv-2:~/thrift/github/thrift$ ./bootstrap.sh
configure.ac: warning: missing AC_FUNC_MALLOC wanted by: 
lib/cpp/src/thrift/TOutput.cpp:62
configure.ac: warning: missing AC_FUNC_REALLOC wanted by: 
lib/cpp/src/thrift/server/TNonblockingServer.cpp:729
{noformat}

I think it's harmless, and autoconf is deprecated anyway, so I think I'll leave 
it be.

> Remove AC_FUNC_MALLOC and AC_FUNC_REALLOC to fix building with Address 
> Sanitizer
> 
>
> Key: THRIFT-4045
> URL: https://issues.apache.org/jira/browse/THRIFT-4045
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.10.0
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Trivial
> Fix For: 0.11.0
>
>
> Created for https://github.com/apache/thrift/pull/1065



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

2017-01-31 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1156
  
Ok, all fine. Don't panic ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

2017-01-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847498#comment-15847498
 ] 

ASF GitHub Bot commented on THRIFT-4011:


Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1156
  
Ok, all fine. Don't panic ;-)


> Sets of Thrift structs generate Go code that can't be serialized to JSON
> 
>
> Key: THRIFT-4011
> URL: https://issues.apache.org/jira/browse/THRIFT-4011
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Compiler
>Reporter: Can Celasun
>
> Consider the following structs:
> {code}
> struct Foo {
>   1: optional string foo
> }
> struct Bar {
>   1: optional set foos
> }
> {code}
> This compiles into the following Go code:
> {code}
> type Bar struct {
>   Foos map[*Foo]struct{} `thrift:"foos,1" db:"foos" json:"foos,omitempty"`
> }
> {code}
> Even though the generated code has tags for JSON support, Bar can't be 
> serialized to JSON:
> {code}
> json: unsupported type: map[*Foo]struct {}
> {code}
> One solution would be to use slices, not maps, for Thrift sets. Thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

2017-01-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847491#comment-15847491
 ] 

ASF GitHub Bot commented on THRIFT-4011:


Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1156
  
Hey @Jens-G sorry, I didn't have time to finish this up just yet. The lib 
part of the PR is still missing, but I'll be doing that in a few days. I'll 
rebase, push and let you know.


> Sets of Thrift structs generate Go code that can't be serialized to JSON
> 
>
> Key: THRIFT-4011
> URL: https://issues.apache.org/jira/browse/THRIFT-4011
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Compiler
>Reporter: Can Celasun
>
> Consider the following structs:
> {code}
> struct Foo {
>   1: optional string foo
> }
> struct Bar {
>   1: optional set foos
> }
> {code}
> This compiles into the following Go code:
> {code}
> type Bar struct {
>   Foos map[*Foo]struct{} `thrift:"foos,1" db:"foos" json:"foos,omitempty"`
> }
> {code}
> Even though the generated code has tags for JSON support, Bar can't be 
> serialized to JSON:
> {code}
> json: unsupported type: map[*Foo]struct {}
> {code}
> One solution would be to use slices, not maps, for Thrift sets. Thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

2017-01-31 Thread dcelasun 
Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1156
  
Hey @Jens-G sorry, I didn't have time to finish this up just yet. The lib 
part of the PR is still missing, but I'll be doing that in a few days. I'll 
rebase, push and let you know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

2017-01-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847478#comment-15847478
 ] 

ASF GitHub Bot commented on THRIFT-4011:


Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1156
  
Hi @dcelasun,any news? In caseyou're donw with it, could you rebase the PR 
to trigger a new Travis build?


> Sets of Thrift structs generate Go code that can't be serialized to JSON
> 
>
> Key: THRIFT-4011
> URL: https://issues.apache.org/jira/browse/THRIFT-4011
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Compiler
>Reporter: Can Celasun
>
> Consider the following structs:
> {code}
> struct Foo {
>   1: optional string foo
> }
> struct Bar {
>   1: optional set foos
> }
> {code}
> This compiles into the following Go code:
> {code}
> type Bar struct {
>   Foos map[*Foo]struct{} `thrift:"foos,1" db:"foos" json:"foos,omitempty"`
> }
> {code}
> Even though the generated code has tags for JSON support, Bar can't be 
> serialized to JSON:
> {code}
> json: unsupported type: map[*Foo]struct {}
> {code}
> One solution would be to use slices, not maps, for Thrift sets. Thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

2017-01-31 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1156
  
Hi @dcelasun,any news? In caseyou're donw with it, could you rebase the PR 
to trigger a new Travis build?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] (THRIFT-4062) Remove debug print from TServiceClient

2017-01-31 Thread Jens Geyer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer resolved THRIFT-4062.

   Resolution: Fixed
Fix Version/s: 0.11.0

Committed, thanks!

> Remove debug print from TServiceClient
> --
>
> Key: THRIFT-4062
> URL: https://issues.apache.org/jira/browse/THRIFT-4062
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Reporter: Jens Geyer
>Assignee: Tom Davis
> Fix For: 0.11.0
>
>
> GitHub user tdavis opened a pull request:
> https://github.com/apache/thrift/pull/1173
> Remove debug print from TServiceClient
> Client: Java
> You can merge this pull request into a Git repository by running:
> $ git pull https://github.com/tdavis/thrift patch-1
> Alternatively you can review and apply these changes as the patch at:
> https://github.com/apache/thrift/pull/1173.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> This closes #1173
> 
> 
> commit 670ad408b7f601798db7cf7b659ac231ba53c6a9
> Author: Tom Davis 
> Date:   2017-01-31T17:01:50Z
> Remove debug print from TServiceClient
> 
> Client: Java
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] (THRIFT-4062) Remove debug print from TServiceClient

2017-01-31 Thread Jens Geyer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer reassigned THRIFT-4062:
--

Assignee: Tom Davis

> Remove debug print from TServiceClient
> --
>
> Key: THRIFT-4062
> URL: https://issues.apache.org/jira/browse/THRIFT-4062
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Reporter: Jens Geyer
>Assignee: Tom Davis
>
> GitHub user tdavis opened a pull request:
> https://github.com/apache/thrift/pull/1173
> Remove debug print from TServiceClient
> Client: Java
> You can merge this pull request into a Git repository by running:
> $ git pull https://github.com/tdavis/thrift patch-1
> Alternatively you can review and apply these changes as the patch at:
> https://github.com/apache/thrift/pull/1173.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> This closes #1173
> 
> 
> commit 670ad408b7f601798db7cf7b659ac231ba53c6a9
> Author: Tom Davis 
> Date:   2017-01-31T17:01:50Z
> Remove debug print from TServiceClient
> 
> Client: Java
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1173: Remove debug print from TServiceClient

2017-01-31 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1173


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #672: Fix package.json to include only the needed files

2017-01-31 Thread bufferoverflow 
Github user bufferoverflow commented on the issue:

https://github.com/apache/thrift/pull/672
  
@jfarrell you are the npm publisher, could you please push 0.10.0 to the 
npm registry?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] (THRIFT-4062) Remove debug print from TServiceClient

2017-01-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847454#comment-15847454
 ] 

ASF GitHub Bot commented on THRIFT-4062:


Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1173
  
Tracked in THRIFT-4062
@tdavis: next time please have a look at our [contrib 
guidelines](http://thrift.apache.org/docs/HowToContribute). Thank you!



> Remove debug print from TServiceClient
> --
>
> Key: THRIFT-4062
> URL: https://issues.apache.org/jira/browse/THRIFT-4062
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Reporter: Jens Geyer
>
> GitHub user tdavis opened a pull request:
> https://github.com/apache/thrift/pull/1173
> Remove debug print from TServiceClient
> Client: Java
> You can merge this pull request into a Git repository by running:
> $ git pull https://github.com/tdavis/thrift patch-1
> Alternatively you can review and apply these changes as the patch at:
> https://github.com/apache/thrift/pull/1173.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> This closes #1173
> 
> 
> commit 670ad408b7f601798db7cf7b659ac231ba53c6a9
> Author: Tom Davis 
> Date:   2017-01-31T17:01:50Z
> Remove debug print from TServiceClient
> 
> Client: Java
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1173: Remove debug print from TServiceClient

2017-01-31 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1173
  
Tracked in THRIFT-4062
@tdavis: next time please have a look at our [contrib 
guidelines](http://thrift.apache.org/docs/HowToContribute). Thank you!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] (THRIFT-4062) Remove debug print from TServiceClient

2017-01-31 Thread Jens Geyer (JIRA) 
Jens Geyer created THRIFT-4062:
--

 Summary: Remove debug print from TServiceClient
 Key: THRIFT-4062
 URL: https://issues.apache.org/jira/browse/THRIFT-4062
 Project: Thrift
  Issue Type: Improvement
  Components: Java - Library
Reporter: Jens Geyer


GitHub user tdavis opened a pull request:

https://github.com/apache/thrift/pull/1173

Remove debug print from TServiceClient

Client: Java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tdavis/thrift patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1173


commit 670ad408b7f601798db7cf7b659ac231ba53c6a9
Author: Tom Davis 
Date:   2017-01-31T17:01:50Z

Remove debug print from TServiceClient

Client: Java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] (THRIFT-3000) .NET implementation has trouble with mixed IP modes

2017-01-31 Thread Jens Geyer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer resolved THRIFT-3000.

   Resolution: Fixed
Fix Version/s: 0.11.0

Committed

> .NET implementation has trouble with mixed IP modes
> ---
>
> Key: THRIFT-3000
> URL: https://issues.apache.org/jira/browse/THRIFT-3000
> Project: Thrift
>  Issue Type: Bug
>  Components: C# - Library
>Affects Versions: 0.9.2, 0.9.3
> Environment: Windows 7 / Windows 8 / Windows 8.1 / .NET 3.5 / .NET 
> 4.0 / .NET 4.5
>Reporter: Tobias Mundt
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.11.0
>
>
> The .NET implementation of TSocket and TServerSocket use the .NET class 
> TcpClient and TcpListener. When creating instances of theses classes the .NET 
> framework estabiles either an IPv4 or an IPv6 lsitener/client depending on 
> the order of network protocols set in the control center for the network 
> adapter. Mention that only the first type of protocol is used not both. 
> Microsoft switched the default order og ipv4 over ipv6 in windows 7 to ipv6 
> over ipv4 in windows 8  and 8.1. That means that a thrift component on a win 
> 7 machine can not talk to the same component on a win 8 machine since they 
> fired of different listeners. 
> When upgrading to .NET 4.5 this can be solved by setting the DualMode=true 
> flag on the TcpListener.Server and the TcpClient.Client sockets. Since 
> DualMode is not supported in Mono as of February 2015. The patch can not be 
> applied.
> Another possible solutions would be to get the configuration of the network 
> protocol order manually and apply the approvriate ip protocol by hand.
> Yet a third possibility would by to add a parameter to the TSocket and 
> TServerSocket constructors to let the user choose the behaviour of the 
> TcpListener and TcpClient
> This problem was attmepted to be solved in the pull request 
> https://github.com/apache/thrift/pull/377 which was rejected due to mono 
> incompatibility



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] (THRIFT-3000) .NET implementation has trouble with mixed IP modes

2017-01-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847444#comment-15847444
 ] 

ASF GitHub Bot commented on THRIFT-3000:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1167


> .NET implementation has trouble with mixed IP modes
> ---
>
> Key: THRIFT-3000
> URL: https://issues.apache.org/jira/browse/THRIFT-3000
> Project: Thrift
>  Issue Type: Bug
>  Components: C# - Library
>Affects Versions: 0.9.2, 0.9.3
> Environment: Windows 7 / Windows 8 / Windows 8.1 / .NET 3.5 / .NET 
> 4.0 / .NET 4.5
>Reporter: Tobias Mundt
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.11.0
>
>
> The .NET implementation of TSocket and TServerSocket use the .NET class 
> TcpClient and TcpListener. When creating instances of theses classes the .NET 
> framework estabiles either an IPv4 or an IPv6 lsitener/client depending on 
> the order of network protocols set in the control center for the network 
> adapter. Mention that only the first type of protocol is used not both. 
> Microsoft switched the default order og ipv4 over ipv6 in windows 7 to ipv6 
> over ipv4 in windows 8  and 8.1. That means that a thrift component on a win 
> 7 machine can not talk to the same component on a win 8 machine since they 
> fired of different listeners. 
> When upgrading to .NET 4.5 this can be solved by setting the DualMode=true 
> flag on the TcpListener.Server and the TcpClient.Client sockets. Since 
> DualMode is not supported in Mono as of February 2015. The patch can not be 
> applied.
> Another possible solutions would be to get the configuration of the network 
> protocol order manually and apply the approvriate ip protocol by hand.
> Yet a third possibility would by to add a parameter to the TSocket and 
> TServerSocket constructors to let the user choose the behaviour of the 
> TcpListener and TcpClient
> This problem was attmepted to be solved in the pull request 
> https://github.com/apache/thrift/pull/377 which was rejected due to mono 
> incompatibility



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1167: THRIFT-3000 .NET implementation has trouble with ...

2017-01-31 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1167


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] (THRIFT-1634) Document cpp.type

2017-01-31 Thread Todd Lipcon (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847435#comment-15847435
 ] 

Todd Lipcon commented on THRIFT-1634:
-

See THRIFT-1567 - there's some info there that may help.

> Document cpp.type
> -
>
> Key: THRIFT-1634
> URL: https://issues.apache.org/jira/browse/THRIFT-1634
> Project: Thrift
>  Issue Type: Sub-task
>  Components: C++ - Library
>Affects Versions: 1.0
>Reporter: Jake Farrell
>Assignee: Todd Lipcon
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] (THRIFT-1634) Document cpp.type

2017-01-31 Thread Todd Lipcon (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon reassigned THRIFT-1634:
---

Assignee: (was: Todd Lipcon)

> Document cpp.type
> -
>
> Key: THRIFT-1634
> URL: https://issues.apache.org/jira/browse/THRIFT-1634
> Project: Thrift
>  Issue Type: Sub-task
>  Components: C++ - Library
>Affects Versions: 1.0
>Reporter: Jake Farrell
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1173: Remove debug print from TServiceClient

2017-01-31 Thread tdavis 
GitHub user tdavis opened a pull request:

https://github.com/apache/thrift/pull/1173

Remove debug print from TServiceClient

Client: Java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tdavis/thrift patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1173


commit 670ad408b7f601798db7cf7b659ac231ba53c6a9
Author: Tom Davis 
Date:   2017-01-31T17:01:50Z

Remove debug print from TServiceClient

Client: Java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #672: Fix package.json to include only the needed files

2017-01-31 Thread modocache 
Github user modocache commented on the issue:

https://github.com/apache/thrift/pull/672
  
+1 for @zertosh's comment. @bufferoverflow, is there any way for me, a 
third-party contributor, to help you or other maintainers publish a new version 
on npm? I'd love to use a version without these unneeded dependencies. Plus, 
the npm version is 0.9.3, but the Apache Thrift website only provides direct 
links to 0.10.0 downloads.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---