[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188375#comment-16188375 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[GitHub] thrift issue #1382: THRIFT-4285 Move TX/RX methods from gen. code to library

2017-10-02 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1382 > I don't think we can unilaterally require go 1.9 at this point without causing some pain, but I'm not sure. This change doesn't effect the user, it's only needed for the tests. Though

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188349#comment-16188349 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1382: THRIFT-4285 Move TX/RX methods from gen. code to library

2017-10-02 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1382 We support go back to version 1.2.1 or 1.4.3 (I can't remember which, but I think 1.2.1 is on trusty). That said, I'm in the middle of reworking the docker images to be as stock as possible, and

[jira] [Updated] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4

2017-10-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4352: --- Summary: Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4 (was: Thrift

[jira] [Commented] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4

2017-10-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188233#comment-16188233 ] Jens Geyer commented on THRIFT-4352: Perfect. Problem solved. > Ubuntu Artful doesn't appear to be

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188187#comment-16188187 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[GitHub] thrift issue #1382: THRIFT-4285 Move TX/RX methods from gen. code to library

2017-10-02 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1382 Travis failure is unrelated, all Go tests are green. cc @jeking3 thoughts? ---

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187973#comment-16187973 ] ASF GitHub Bot commented on THRIFT-4285: GitHub user dcelasun opened a pull request:

[GitHub] thrift pull request #1382: THRIFT-4285 Move TX/RX methods from gen. code to ...

2017-10-02 Thread dcelasun
GitHub user dcelasun opened a pull request: https://github.com/apache/thrift/pull/1382 THRIFT-4285 Move TX/RX methods from gen. code to library This change removes a lot of duplication from generated code and allows the caller to customize how they can read from / write to the

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187807#comment-16187807 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun closed the pull request at:

[GitHub] thrift pull request #1381: THRIFT-4285: Move TX/RX methods from gen. code to...

2017-10-02 Thread dcelasun
Github user dcelasun closed the pull request at: https://github.com/apache/thrift/pull/1381 ---

[jira] [Closed] (THRIFT-4291) Two different thrift interface in the same project causes run time asserts

2017-10-02 Thread Peter Young (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Young closed THRIFT-4291. --- Resolution: Fixed > Two different thrift interface in the same project causes run time asserts >

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187710#comment-16187710 ] ASF GitHub Bot commented on THRIFT-4285: GitHub user dcelasun opened a pull request:

[GitHub] thrift pull request #1381: THRIFT-4285: Move TX/RX methods from gen. code to...

2017-10-02 Thread dcelasun
GitHub user dcelasun opened a pull request: https://github.com/apache/thrift/pull/1381 THRIFT-4285: Move TX/RX methods from gen. code to library This change removes a lot of duplication from generated code and allows the caller to customize how they can read from / write to the