[jira] [Commented] (THRIFT-3773) Swift Library

2017-11-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234483#comment-16234483 ] ASF GitHub Bot commented on THRIFT-3773: Github user apocolipse commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2017-11-01 Thread apocolipse
Github user apocolipse commented on the issue: https://github.com/apache/thrift/pull/1084 @nsuke hah good catch, bad habits from other languages ;) Fixed ---

[jira] [Commented] (THRIFT-3773) Swift Library

2017-11-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234195#comment-16234195 ] ASF GitHub Bot commented on THRIFT-3773: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2017-11-01 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r148288455 --- Diff: compiler/cpp/src/thrift/generate/t_swift_generator.cc --- @@ -245,22 +297,30 @@ class t_swift_generator : public t_oop_generator { */