[GitHub] thrift issue #1413: 0.8.x

2017-11-13 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1413 @jfarrell, could you please close this? ---

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250293#comment-16250293 ] ASF GitHub Bot commented on THRIFT-4329: Github user gadLinux commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-11-13 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 Hi @jeking3 I think at the end it was part of the test client... What do you think? It worth it merge it? ---

[GitHub] thrift issue #1411: Fix remote client for HTTP transport

2017-11-13 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1411 Thanks - once the CI builds pass I will re-review. ---

[jira] [Updated] (THRIFT-4385) Go remote client doesn't work for HTTP transport

2017-11-13 Thread Dylan Trotter (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dylan Trotter updated THRIFT-4385: -- Description: There are two separate but trivial bugs in the Go remote implementation: * The

[jira] [Updated] (THRIFT-4385) Go remote client -u flag is broken

2017-11-13 Thread Dylan Trotter (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dylan Trotter updated THRIFT-4385: -- Summary: Go remote client -u flag is broken (was: Go remote client doesn't work for HTTP

[GitHub] thrift issue #1411: Fix remote client for HTTP transport

2017-11-13 Thread trotterdylan
Github user trotterdylan commented on the issue: https://github.com/apache/thrift/pull/1411 Done. Updated the commit message accordingly. ---

[GitHub] thrift issue #1411: Fix remote client for HTTP transport

2017-11-13 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1411 Please revert the `NewTHttpClient` part of this PR, since `THttpPostClient` is deprecated and is just an alias for `THttpClient` since 0dd82358. ---

[GitHub] thrift pull request #1413: 0.8.x

2017-11-13 Thread tt918916
GitHub user tt918916 opened a pull request: https://github.com/apache/thrift/pull/1413 0.8.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/thrift 0.8.x Alternatively you can review and apply these changes as the patch

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249864#comment-16249864 ] ASF GitHub Bot commented on THRIFT-4329: Github user gadLinux commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-11-13 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 In fact @jeking3 Some of the failures are not related to this issue. So please don't ask me to fix them as part of this issue. One of them is caused in the Java Server because the exception

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249852#comment-16249852 ] ASF GitHub Bot commented on THRIFT-4329: Github user gadLinux commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-11-13 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 What I'm telling you is that I need help if you want to fix everything on this language. I don't have all the time to implement the full stack. This is an implementation of the processor, not all

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249845#comment-16249845 ] ASF GitHub Bot commented on THRIFT-4329: Github user gadLinux commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-11-13 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 @jeking3 I don't think is an error, but that all this cross tests are directly not supported. No all protocols are implemented. ---

[jira] [Commented] (THRIFT-4385) Go remote client doesn't work for HTTP transport

2017-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249834#comment-16249834 ] ASF GitHub Bot commented on THRIFT-4385: Github user trotterdylan commented on the issue:

[jira] [Created] (THRIFT-4385) Go remote client doesn't work for HTTP transport

2017-11-13 Thread Dylan Trotter (JIRA)
Dylan Trotter created THRIFT-4385: - Summary: Go remote client doesn't work for HTTP transport Key: THRIFT-4385 URL: https://issues.apache.org/jira/browse/THRIFT-4385 Project: Thrift Issue

[GitHub] thrift issue #1411: Fix remote client for HTTP transport

2017-11-13 Thread trotterdylan
Github user trotterdylan commented on the issue: https://github.com/apache/thrift/pull/1411 Done! https://issues.apache.org/jira/browse/THRIFT-4385 ---

[jira] [Created] (THRIFT-4384) Using multiple services simultaneously is not thread-safe.

2017-11-13 Thread Michael Eiler (JIRA)
Michael Eiler created THRIFT-4384: - Summary: Using multiple services simultaneously is not thread-safe. Key: THRIFT-4384 URL: https://issues.apache.org/jira/browse/THRIFT-4384 Project: Thrift

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249647#comment-16249647 ] ASF GitHub Bot commented on THRIFT-4329: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-11-13 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1361 @gadLinux I think you need to re-read the error messages. It says GLib-WARNING and GError. That's the c_glib library. Further it looks like all the "multi" protocol tests failed with c_glib on

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-11-13 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 Yes but this seems to be in other languages that are not in my scope. So it should be others that fix them. So I think it's good enough for now. Can you merge it? And maybe open a new bug to trac

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249565#comment-16249565 ] ASF GitHub Bot commented on THRIFT-4329: Github user gadLinux commented on the issue:

[jira] [Commented] (THRIFT-2913) Ruby Server Thrift::ThreadPoolServer should serve inside a thread

2017-11-13 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249473#comment-16249473 ] James E. King, III commented on THRIFT-2913: If someone with Ruby experience could figure

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249458#comment-16249458 ] ASF GitHub Bot commented on THRIFT-4329: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-11-13 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1361 Job 6 failed due to https://issues.apache.org/jira/browse/THRIFT-2913 which pops up far too often. Job 4 failed legitimitely and indicates there is still something that needs to be fixed:

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249297#comment-16249297 ] ASF GitHub Bot commented on THRIFT-4329: Github user gadLinux commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-11-13 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 4197.6 Fails... I'm done. Don't know what else to do. Please check what is it... ---

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249230#comment-16249230 ] ASF GitHub Bot commented on THRIFT-4329: Github user gadLinux commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-11-13 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 @jeking3 It doesn't fail for me, even in the docker container. Please review and merge. ---