[
https://issues.apache.org/jira/browse/THRIFT-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4470.
Resolution: Fixed
Fix Version/s: (was: 0.11.0)
0.12.0
[
https://issues.apache.org/jira/browse/THRIFT-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336923#comment-16336923
]
ASF GitHub Bot commented on THRIFT-4463:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4463.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks!
> PHP generated
[
https://issues.apache.org/jira/browse/THRIFT-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336922#comment-16336922
]
ASF GitHub Bot commented on THRIFT-4464:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1475
---
[
https://issues.apache.org/jira/browse/THRIFT-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4464.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks!
> Potentially s
[
https://issues.apache.org/jira/browse/THRIFT-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336924#comment-16336924
]
ASF GitHub Bot commented on THRIFT-4470:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336921#comment-16336921
]
ASF GitHub Bot commented on THRIFT-4460:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1477
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1473
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1472
---
[
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4460.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks!
> php library u
[
https://issues.apache.org/jira/browse/THRIFT-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4470:
--
Assignee: James E. King, III
> Include popular IDE file templates to gitignore
[
https://issues.apache.org/jira/browse/THRIFT-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4464:
--
Assignee: James E. King, III
> Potentially server-crashing typo in Python TNon
[
https://issues.apache.org/jira/browse/THRIFT-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336906#comment-16336906
]
ASF GitHub Bot commented on THRIFT-4464:
Github user nsuke commented on the issue
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1475
Thanks @tomtung, looks fine to me.
---
[
https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336902#comment-16336902
]
ASF GitHub Bot commented on THRIFT-4438:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1451
Thanks, given there were no structural changes to php other than dropping
5.3 from the compatibility list, I think this is best for now.
---
Github user Alex-Vol closed the pull request at:
https://github.com/apache/thrift/pull/1468
---
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
@jeking3 per our offline discussion, I am closing this and pushing to my
branch the update with the commit user email corrected so it does not trigger a
new build. You can pick up the changes and m
[
https://issues.apache.org/jira/browse/THRIFT-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336847#comment-16336847
]
ASF GitHub Bot commented on THRIFT-1418:
Github user Alex-Vol closed the pull req
[
https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Lu closed THRIFT-4438.
-
Resolution: Not A Problem
> require php ^5.6 || ^7.0
>
>
> Key:
[
https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336806#comment-16336806
]
ASF GitHub Bot commented on THRIFT-4438:
Github user RobberPhex closed the pull r
[
https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336804#comment-16336804
]
ASF GitHub Bot commented on THRIFT-4438:
Github user RobberPhex commented on the
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1451
Considering that trusty haven't reached end of life, so I close this pr,
and keep trusty in CI.
---
Github user RobberPhex closed the pull request at:
https://github.com/apache/thrift/pull/1451
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/747
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/353
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/352
---
[
https://issues.apache.org/jira/browse/THRIFT-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336684#comment-16336684
]
ASF GitHub Bot commented on THRIFT-2820:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336679#comment-16336679
]
ASF GitHub Bot commented on THRIFT-2896:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336681#comment-16336681
]
ASF GitHub Bot commented on THRIFT-2939:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336687#comment-16336687
]
ASF GitHub Bot commented on THRIFT-3500:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336686#comment-16336686
]
ASF GitHub Bot commented on THRIFT-2427:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336685#comment-16336685
]
ASF GitHub Bot commented on THRIFT-3143:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336680#comment-16336680
]
ASF GitHub Bot commented on THRIFT-2938:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/488
---
[
https://issues.apache.org/jira/browse/THRIFT-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336682#comment-16336682
]
ASF GitHub Bot commented on THRIFT-2885:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336677#comment-16336677
]
ASF GitHub Bot commented on THRIFT-2429:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336678#comment-16336678
]
ASF GitHub Bot commented on THRIFT-2926:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336683#comment-16336683
]
ASF GitHub Bot commented on THRIFT-3060:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/756
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/395
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/383
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/413
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/731
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/555
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/345
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/624
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/93
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/326
---
[
https://issues.apache.org/jira/browse/THRIFT-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336674#comment-16336674
]
ASF GitHub Bot commented on THRIFT-2790:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336673#comment-16336673
]
ASF GitHub Bot commented on THRIFT-3500:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/782
Should this be moved forward or closed?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/756
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/747
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
[
https://issues.apache.org/jira/browse/THRIFT-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336671#comment-16336671
]
ASF GitHub Bot commented on THRIFT-2427:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/744
@lihanharry please move this forward or it will eventually be closed due to
inactivity. @RobberPhex any concerns with this code?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/723
All parties here, please move this forward or it will eventually be closed
due to inactivity. It looks like we're fairly close to completing this;
however I have to point out that the project's use
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/731
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
[
https://issues.apache.org/jira/browse/THRIFT-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336664#comment-16336664
]
ASF GitHub Bot commented on THRIFT-2820:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336665#comment-16336665
]
ASF GitHub Bot commented on THRIFT-3143:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336663#comment-16336663
]
ASF GitHub Bot commented on THRIFT-3060:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336657#comment-16336657
]
ASF GitHub Bot commented on THRIFT-2896:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/488
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/555
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
[
https://issues.apache.org/jira/browse/THRIFT-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336661#comment-16336661
]
ASF GitHub Bot commented on THRIFT-2939:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/624
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/413
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
[
https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336658#comment-16336658
]
ASF GitHub Bot commented on THRIFT-2926:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/395
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
[
https://issues.apache.org/jira/browse/THRIFT-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336660#comment-16336660
]
ASF GitHub Bot commented on THRIFT-2938:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336662#comment-16336662
]
ASF GitHub Bot commented on THRIFT-2885:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/383
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/353
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/326
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/345
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/93
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
[
https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336656#comment-16336656
]
ASF GitHub Bot commented on THRIFT-2429:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/352
This pull request is being closed due to lack of activity.
You can re-open it after rebasing on the current master if you would like
it to be reconsidered.
---
[
https://issues.apache.org/jira/browse/THRIFT-4471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4471:
--
Assignee: James E. King, III
> Thrift CPAN release is missing Makefile.PL and
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1448
Is this done (for now) with the exception of that build issue, since you
removed the [WIP] tag?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1468
Do you want me to mark all the Jira issues as fixed in 0.12.0 once this is
merged?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1468
As a separate pull request, yes. :)
---
[
https://issues.apache.org/jira/browse/THRIFT-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336610#comment-16336610
]
ASF GitHub Bot commented on THRIFT-4464:
Github user tomtung commented on the iss
Github user tomtung commented on the issue:
https://github.com/apache/thrift/pull/1475
Maybe @nsuke (who wrote made the change originally) can help check?
---
[
https://issues.apache.org/jira/browse/THRIFT-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4472.
Resolution: Fixed
> Fix the genspec for ruby so it does not complain about an inval
James E. King, III created THRIFT-4472:
--
Summary: Fix the genspec for ruby so it does not complain about an
invalid license
Key: THRIFT-4472
URL: https://issues.apache.org/jira/browse/THRIFT-4472
[
https://issues.apache.org/jira/browse/THRIFT-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336608#comment-16336608
]
ASF GitHub Bot commented on THRIFT-4464:
Github user allengeorge commented on the
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1475
On the face of it that looks correct. There isn't even a `message` in
scope, so when it hits that line the code would just break. I'll look a little
deeper.
---
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163420333
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open();
v
[
https://issues.apache.org/jira/browse/THRIFT-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336597#comment-16336597
]
ASF GitHub Bot commented on THRIFT-4464:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1475
It would be helpful if someone with python experience could double-check
this.
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163418365
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open();
[
https://issues.apache.org/jira/browse/THRIFT-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336363#comment-16336363
]
Anton Shchyrov commented on THRIFT-4467:
Now I use class helper for class TThrift
[
https://issues.apache.org/jira/browse/THRIFT-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336355#comment-16336355
]
Anton Shchyrov commented on THRIFT-4468:
OK. With this approach, this class is re
[
https://issues.apache.org/jira/browse/THRIFT-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336336#comment-16336336
]
Jens Geyer commented on THRIFT-4468:
I don't see this patch as part of the Thrift lib
[
https://issues.apache.org/jira/browse/THRIFT-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336322#comment-16336322
]
Jens Geyer edited comment on THRIFT-4467 at 1/23/18 8:28 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336322#comment-16336322
]
Jens Geyer commented on THRIFT-4467:
I don't see this patch as part of the Thrift lib
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
Yes, as it stands right now we will need to change the "making a release"
page to eliminate the manual editing of the gradle.properties file since it is
now automated to just require the configure.
1 - 100 of 112 matches
Mail list logo
