[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416594#comment-16416594 ] ASF GitHub Bot commented on THRIFT-4530: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1522: THRIFT-4530: add @Nullable annotations to generated Java...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1522 Yes there is an issue that appears in builds where lisp cannot find a file it just supposedly wrote. Lisp is new to the project, this is an ongoing thing. ---

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416581#comment-16416581 ] ASF GitHub Bot commented on THRIFT-4530: Github user msridhar commented on the issue:

[GitHub] thrift issue #1522: THRIFT-4530: add @Nullable annotations to generated Java...

Github user msridhar commented on the issue: https://github.com/apache/thrift/pull/1522 Looks like the Travis failure is on Common Lisp codegen (https://api.travis-ci.org/v3/job/359136811/log.txt), which has nothing to do with this PR ---

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416508#comment-16416508 ] Buğra Gedik commented on THRIFT-4532: - We considered two approaches. The first one was just what you

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416467#comment-16416467 ] James E. King, III commented on THRIFT-4532: Yes, I agree this would be useful.  I assume the

[GitHub] thrift issue #1522: THRIFT-4530: add @Nullable annotations to generated Java...

Github user msridhar commented on the issue: https://github.com/apache/thrift/pull/1522 Note that while there are no new tests, the code under `tutorial/java/gen-java` includes the annotations and compiles without issue. Since this change doesn't affect runtime behavior of the

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416443#comment-16416443 ] ASF GitHub Bot commented on THRIFT-4530: Github user msridhar commented on the issue:

[jira] [Commented] (THRIFT-4530) proposal: add nullability annotations to generated Java code

[ https://issues.apache.org/jira/browse/THRIFT-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416437#comment-16416437 ] ASF GitHub Bot commented on THRIFT-4530: GitHub user msridhar opened a pull request:

[GitHub] thrift pull request #1522: THRIFT-4530: add @Nullable annotations to generat...

GitHub user msridhar opened a pull request: https://github.com/apache/thrift/pull/1522 THRIFT-4530: add @Nullable annotations to generated Java code Use our own `org.apache.thrift.annotations.Nullable` annotation to avoid introducing a third-party dependency You can merge this

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416303#comment-16416303 ] Buğra Gedik commented on THRIFT-4532: - [~jking3] If you think this is a valuable contribution, we

[jira] [Updated] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Buğra Gedik updated THRIFT-4532: Description: We would like to contribute an improvement to the Thrift compiler that would avoid

[jira] [Created] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

Buğra Gedik created THRIFT-4532: --- Summary: Avoid updating Thrift compiler generated code if the output has not changed Key: THRIFT-4532 URL: https://issues.apache.org/jira/browse/THRIFT-4532 Project:

[jira] [Commented] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415620#comment-16415620 ] ASF GitHub Bot commented on THRIFT-4531: Github user margars commented on the issue:

[GitHub] thrift issue #1521: THRIFT-4531 (#1)

Github user margars commented on the issue: https://github.com/apache/thrift/pull/1521 Build failed with Gradle POM parsing error which has nothing to do with the commit. ---

[jira] [Commented] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415537#comment-16415537 ] ASF GitHub Bot commented on THRIFT-4531: GitHub user margars opened a pull request:

[GitHub] thrift pull request #1521: THRIFT-4531 (#1)

GitHub user margars opened a pull request: https://github.com/apache/thrift/pull/1521 THRIFT-4531 (#1) THRIFT-4531: Fix generated Python read() method for immutable structs with optional members. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415495#comment-16415495 ] ASF GitHub Bot commented on THRIFT-4531: Github user margars commented on the issue:

[GitHub] thrift issue #1520: THRIFT-4531

Github user margars commented on the issue: https://github.com/apache/thrift/pull/1520 I am behind corporate firewall and don't know how to squash from the web interface, will try from scratch. ---

[jira] [Commented] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415493#comment-16415493 ] ASF GitHub Bot commented on THRIFT-4531: Github user margars closed the pull request at:

[GitHub] thrift pull request #1520: THRIFT-4531

Github user margars closed the pull request at: https://github.com/apache/thrift/pull/1520 ---

[jira] [Commented] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415488#comment-16415488 ] ASF GitHub Bot commented on THRIFT-4531: Github user dcelasun commented on the issue:

[GitHub] thrift issue #1520: THRIFT-4531

Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1520 Also, please squash your commits. ---

[jira] [Issue Comment Deleted] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Margar Simonyan updated THRIFT-4531: Comment: was deleted (was: Added pull request https://github.com/apache/thrift/pull/1520 )

[jira] [Commented] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415476#comment-16415476 ] Margar Simonyan commented on THRIFT-4531: - Added pull request 

[jira] [Commented] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415473#comment-16415473 ] ASF GitHub Bot commented on THRIFT-4531: Github user margars commented on the issue:

[GitHub] thrift issue #1520: THRIFT-4531

Github user margars commented on the issue: https://github.com/apache/thrift/pull/1520 Sorry, I am not familiar with all this setup and rules. ---

[jira] [Commented] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415457#comment-16415457 ] ASF GitHub Bot commented on THRIFT-4531: Github user dcelasun commented on the issue:

[GitHub] thrift issue #1520: THRIFT-4531

Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1520 There are no changes in this PR. Please correct it and force push. ---

[jira] [Commented] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415444#comment-16415444 ] ASF GitHub Bot commented on THRIFT-4531: GitHub user margars opened a pull request:

[GitHub] thrift pull request #1520: THRIFT-4531

GitHub user margars opened a pull request: https://github.com/apache/thrift/pull/1520 THRIFT-4531 I am not familiar with your rules for contributions. This issue is described in JIRA THRIFT-4531. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

[ https://issues.apache.org/jira/browse/THRIFT-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415439#comment-16415439 ] Can Celasun commented on THRIFT-4531: - See the [contributing

[jira] [Created] (THRIFT-4531) Thrift generates wrong Python code for immutable structures with optional members

Margar Simonyan created THRIFT-4531: --- Summary: Thrift generates wrong Python code for immutable structures with optional members Key: THRIFT-4531 URL: https://issues.apache.org/jira/browse/THRIFT-4531