[jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268
[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460345#comment-16460345 ] James E. King III commented on THRIFT-3769: --- The project has not retroactively applied patches. It will appear in 0.12.0 which is likely to start soon, as we want to release more than once yearly :) but in the meantime you can maintain your own fork with the patch and build a jar... > Fix logic of THRIFT-2268 > > > Key: THRIFT-3769 > URL: https://issues.apache.org/jira/browse/THRIFT-3769 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9.2 >Reporter: Harsh J >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > Attachments: THRIFT-3769.patch > > > THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled > servers, but the commit doesn't help in doing so (its just adding more > specific noise today). > This is because the transport factory overrides disallow throwing specific > execution types (no TTransportException in signature), and thereby all > implementations will throw a RuntimeException-wrapped exception, which the > added catch clauses would never encounter. > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslServerTransport.java#L217-L219 > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L290-L295 > We'll need to unwrap the RuntimeException to perform an actual valid cause > check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4541) Use new project system in "lib/csharp" and define supported platforms
[ https://issues.apache.org/jira/browse/THRIFT-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460342#comment-16460342 ] James E. King III commented on THRIFT-4541: --- I'm happy to see any improvements in this space, so go for it. > Use new project system in "lib/csharp" and define supported platforms > - > > Key: THRIFT-4541 > URL: https://issues.apache.org/jira/browse/THRIFT-4541 > Project: Thrift > Issue Type: Umbrella > Components: C# - Library >Reporter: Christian Weiss >Priority: Major > > As discussed in THRIFT-4535, it would be great if we could update > "lib/csharp" to use the new "csproj" project system. This will allow us to > target multiple platforms and the new ".NET Standard" with a single project. > It's possible to support pretty much every platform there is with this new > project format (see e.g. > [Newtonsoft.Json|https://github.com/JamesNK/Newtonsoft.Json/blob/master/Src/Newtonsoft.Json/Newtonsoft.Json.csproj]), > however supporting older platforms requires more work as this requires more > #if statements etc. > This means that we have to decide which platforms we want to support! > Targeting ".NET Standard 2.0" would be the easiest option as this version > [covers a much larger API > surface|https://blogs.msdn.microsoft.com/dotnet/2017/08/14/announcing-net-standard-2-0/]. > However, this would also mean that people have to use rather recent versions > of their platforms to use it, as .NET Standard 2.0 requires the following > minimum versions: > * .NET 4.6.1 (adding support for .NET 4.5 is no problem though) > * .NET Core 2.0 > * Mono 5.4 > * Xamarin.iOS 10.14 > * Xamarin.Mac 3.8 > * Xamarin.Android 8.0 > * UWP 10.0.16299 > I will create a PR that targets .NET Standard 2.0 and .NET 4.5 to show what > the new project files would look like. If the approach is OK for you in > general, then I can try to add support for whatever minimum versions you'd > like to support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268
[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460166#comment-16460166 ] Vihang Karajgaonkar commented on THRIFT-3769: - Hi [~jking3] Is it possible to get this patch merged in 0.9.x branch as well? We would like to get this patch released as part of 0.9.4 if possible. Thank you! > Fix logic of THRIFT-2268 > > > Key: THRIFT-3769 > URL: https://issues.apache.org/jira/browse/THRIFT-3769 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9.2 >Reporter: Harsh J >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > Attachments: THRIFT-3769.patch > > > THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled > servers, but the commit doesn't help in doing so (its just adding more > specific noise today). > This is because the transport factory overrides disallow throwing specific > execution types (no TTransportException in signature), and thereby all > implementations will throw a RuntimeException-wrapped exception, which the > added catch clauses would never encounter. > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslServerTransport.java#L217-L219 > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L290-L295 > We'll need to unwrap the RuntimeException to perform an actual valid cause > check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268
[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460155#comment-16460155 ] Vihang Karajgaonkar commented on THRIFT-3769: - Thanks for committing the patch [~jking3]. Do you know if there are any plans to release 0.12.0 soon? > Fix logic of THRIFT-2268 > > > Key: THRIFT-3769 > URL: https://issues.apache.org/jira/browse/THRIFT-3769 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9.2 >Reporter: Harsh J >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > Attachments: THRIFT-3769.patch > > > THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled > servers, but the commit doesn't help in doing so (its just adding more > specific noise today). > This is because the transport factory overrides disallow throwing specific > execution types (no TTransportException in signature), and thereby all > implementations will throw a RuntimeException-wrapped exception, which the > added catch clauses would never encounter. > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslServerTransport.java#L217-L219 > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L290-L295 > We'll need to unwrap the RuntimeException to perform an actual valid cause > check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4541) Use new project system in "lib/csharp" and define supported platforms
[ https://issues.apache.org/jira/browse/THRIFT-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459991#comment-16459991 ] Christian Weiss commented on THRIFT-4541: - Any feedback on this? I do not want to proceed until I have your feedback. > Use new project system in "lib/csharp" and define supported platforms > - > > Key: THRIFT-4541 > URL: https://issues.apache.org/jira/browse/THRIFT-4541 > Project: Thrift > Issue Type: Umbrella > Components: C# - Library >Reporter: Christian Weiss >Priority: Major > > As discussed in THRIFT-4535, it would be great if we could update > "lib/csharp" to use the new "csproj" project system. This will allow us to > target multiple platforms and the new ".NET Standard" with a single project. > It's possible to support pretty much every platform there is with this new > project format (see e.g. > [Newtonsoft.Json|https://github.com/JamesNK/Newtonsoft.Json/blob/master/Src/Newtonsoft.Json/Newtonsoft.Json.csproj]), > however supporting older platforms requires more work as this requires more > #if statements etc. > This means that we have to decide which platforms we want to support! > Targeting ".NET Standard 2.0" would be the easiest option as this version > [covers a much larger API > surface|https://blogs.msdn.microsoft.com/dotnet/2017/08/14/announcing-net-standard-2-0/]. > However, this would also mean that people have to use rather recent versions > of their platforms to use it, as .NET Standard 2.0 requires the following > minimum versions: > * .NET 4.6.1 (adding support for .NET 4.5 is no problem though) > * .NET Core 2.0 > * Mono 5.4 > * Xamarin.iOS 10.14 > * Xamarin.Mac 3.8 > * Xamarin.Android 8.0 > * UWP 10.0.16299 > I will create a PR that targets .NET Standard 2.0 and .NET 4.5 to show what > the new project files would look like. If the approach is OK for you in > general, then I can try to add support for whatever minimum versions you'd > like to support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (THRIFT-4556) Optional rethrow of unhandled exceptions in java processor
[ https://issues.apache.org/jira/browse/THRIFT-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III resolved THRIFT-4556. --- Resolution: Fixed Fix Version/s: (was: 0.11.0) 0.12.0 Committed - thanks. > Optional rethrow of unhandled exceptions in java processor > -- > > Key: THRIFT-4556 > URL: https://issues.apache.org/jira/browse/THRIFT-4556 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler, Java - Library >Affects Versions: 0.11.0 >Reporter: Nicolas Krog >Assignee: James E. King III >Priority: Major > Fix For: 0.12.0 > > > Current behavior for Java processor is to do a minor logging of any unhandled > exceptions and return to the client that an exception has happened. > I would like to make it possible to rethrow the uncaught exceptions since we > need that functionality in order to make 0.11.0+ version be compatible with > our current code. > The functionality we want is similar to the functionality of the commit > 5038466e5e57b17b881684bae0e541408aafac0e, but that functionality was > overwritten with the commit 026c9d032c4a298ecb9edbcdfb52590facb442f3 and left > some code unused. We want to more or less reuse and adapt that unused code in > order to make it possible for the user to choose whether uncaught exceptions > should be re-thrown. > More specifically: > The command here, implemented with 5038..., made it possible for the user to > specify whether a RuntimeException should be handled and returned to the > client. > $ thrift --gen java:handle_runtime_exceptions someThriftFile.thrift > That flag is now of no use, because of the changes made in 026c9... > We want to be able to do > $ thrift --gen java:rethrowUncaughtExceptions someThriftFile.thrift > Thus, making the java processor rethrow the exception and propagating it > upwards. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (THRIFT-4556) Optional rethrow of unhandled exceptions in java processor
[ https://issues.apache.org/jira/browse/THRIFT-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III reassigned THRIFT-4556: - Assignee: James E. King III > Optional rethrow of unhandled exceptions in java processor > -- > > Key: THRIFT-4556 > URL: https://issues.apache.org/jira/browse/THRIFT-4556 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler, Java - Library >Affects Versions: 0.11.0 >Reporter: Nicolas Krog >Assignee: James E. King III >Priority: Major > Fix For: 0.12.0 > > > Current behavior for Java processor is to do a minor logging of any unhandled > exceptions and return to the client that an exception has happened. > I would like to make it possible to rethrow the uncaught exceptions since we > need that functionality in order to make 0.11.0+ version be compatible with > our current code. > The functionality we want is similar to the functionality of the commit > 5038466e5e57b17b881684bae0e541408aafac0e, but that functionality was > overwritten with the commit 026c9d032c4a298ecb9edbcdfb52590facb442f3 and left > some code unused. We want to more or less reuse and adapt that unused code in > order to make it possible for the user to choose whether uncaught exceptions > should be re-thrown. > More specifically: > The command here, implemented with 5038..., made it possible for the user to > specify whether a RuntimeException should be handled and returned to the > client. > $ thrift --gen java:handle_runtime_exceptions someThriftFile.thrift > That flag is now of no use, because of the changes made in 026c9... > We want to be able to do > $ thrift --gen java:rethrowUncaughtExceptions someThriftFile.thrift > Thus, making the java processor rethrow the exception and propagating it > upwards. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
ApacheCon North America 2018 schedule is now live.
Dear Apache Enthusiast, We are pleased to announce our schedule for ApacheCon North America 2018. ApacheCon will be held September 23-27 at the Montreal Marriott Chateau Champlain in Montreal, Canada. Registration is open! The early bird rate of $575 lasts until July 21, at which time it goes up to $800. And the room block at the Marriott ($225 CAD per night, including wifi) closes on August 24th. We will be featuring more than 100 sessions on Apache projects. The schedule is now online at https://apachecon.com/acna18/ The schedule includes full tracks of content from Cloudstack[1], Tomcat[2], and our GeoSpatial community[3]. We will have 4 keynote speakers, two of whom are Apache members, and two from the wider community. On Tuesday, Apache member and former board member Cliff Schmidt will be speaking about how Amplio uses technology to educate and improve the quality of life of people living in very difficult parts of the world[4]. And Apache Fineract VP Myrle Krantz will speak about how Open Source banking is helping the global fight against poverty[5]. Then, on Wednesday, we’ll hear from Bridget Kromhout, Principal Cloud Developer Advocate from Microsoft, about the really hard problem in software - the people[6]. And Euan McLeod, VP VIPER at Comcast will show us the many ways that Apache software delivers your favorite shows to your living room[7]. ApacheCon will also feature old favorites like the Lightning Talks, the Hackathon (running the duration of the event), PGP key signing, and lots of hallway-track time to get to know your project community better. Follow us on Twitter, @ApacheCon, and join the disc...@apachecon.com mailing list (send email to discuss-subscr...@apachecon.com) to stay up to date with developments. And if your company wants to sponsor this event, get in touch at h...@apachecon.com for opportunities that are still available. See you in Montreal! Rich Bowen VP Conferences, The Apache Software Foundation h...@apachecon.com @ApacheCon [1] http://cloudstackcollab.org/ [2] http://tomcat.apache.org/conference.html [3] http://apachecon.dukecon.org/acna/2018/#/schedule?search=geospatial [4] http://apachecon.dukecon.org/acna/2018/#/scheduledEvent/df977fd305a31b903 [5] http://apachecon.dukecon.org/acna/2018/#/scheduledEvent/22c6c30412a3828d6 [6] http://apachecon.dukecon.org/acna/2018/#/scheduledEvent/fbbb2384fa91ebc6b [7] http://apachecon.dukecon.org/acna/2018/#/scheduledEvent/88d50c3613852c2de
[jira] [Resolved] (THRIFT-3769) Fix logic of THRIFT-2268
[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3769. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks. > Fix logic of THRIFT-2268 > > > Key: THRIFT-3769 > URL: https://issues.apache.org/jira/browse/THRIFT-3769 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9.2 >Reporter: Harsh J >Assignee: James E. King, III >Priority: Minor > Fix For: 0.12.0 > > Attachments: THRIFT-3769.patch > > > THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled > servers, but the commit doesn't help in doing so (its just adding more > specific noise today). > This is because the transport factory overrides disallow throwing specific > execution types (no TTransportException in signature), and thereby all > implementations will throw a RuntimeException-wrapped exception, which the > added catch clauses would never encounter. > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslServerTransport.java#L217-L219 > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L290-L295 > We'll need to unwrap the RuntimeException to perform an actual valid cause > check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (THRIFT-3769) Fix logic of THRIFT-2268
[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3769: -- Assignee: James E. King, III > Fix logic of THRIFT-2268 > > > Key: THRIFT-3769 > URL: https://issues.apache.org/jira/browse/THRIFT-3769 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9.2 >Reporter: Harsh J >Assignee: James E. King, III >Priority: Minor > Attachments: THRIFT-3769.patch > > > THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled > servers, but the commit doesn't help in doing so (its just adding more > specific noise today). > This is because the transport factory overrides disallow throwing specific > execution types (no TTransportException in signature), and thereby all > implementations will throw a RuntimeException-wrapped exception, which the > added catch clauses would never encounter. > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslServerTransport.java#L217-L219 > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L290-L295 > We'll need to unwrap the RuntimeException to perform an actual valid cause > check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459652#comment-16459652
]
ASF GitHub Bot commented on THRIFT-3769:
jeking3 closed pull request #1543: THRIFT-3769 : Fix logic of THRIFT-2268
URL: https://github.com/apache/thrift/pull/1543
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java
b/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java
index 53c20e98fe..3b5f21e84c 100644
--- a/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java
+++ b/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java
@@ -311,14 +311,24 @@ public void run() {
break;
}
}
- } catch (TSaslTransportException ttx) {
-// Something thats not SASL was in the stream, continue silently
- } catch (TTransportException ttx) {
-// Assume the client died and continue silently
} catch (TException tx) {
LOGGER.error("Thrift error occurred during processing of message.",
tx);
} catch (Exception x) {
-LOGGER.error("Error occurred during processing of message.", x);
+// We'll usually receive RuntimeException types here
+// Need to unwrap to ascertain real causing exception before we choose
to ignore
+Throwable realCause = x.getCause();
+// Ignore err-logging all transport-level/type exceptions
+if ((realCause != null && realCause instanceof TTransportException)
+|| (x instanceof TTransportException)) {
+ if (LOGGER.isDebugEnabled()) {
+// Write to debug, just in case the exception gets required
+LOGGER
+.debug("Received TTransportException during processing of
message, ignoring: ", x);
+ }
+} else {
+ // Log the exception at error level and continue
+ LOGGER.error("Error occurred during processing of message.", x);
+}
} finally {
if (eventHandler != null) {
eventHandler.deleteContext(connectionContext, inputProtocol,
outputProtocol);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix logic of THRIFT-2268
>
>
> Key: THRIFT-3769
> URL: https://issues.apache.org/jira/browse/THRIFT-3769
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
>Affects Versions: 0.9.2
>Reporter: Harsh J
>Assignee: James E. King, III
>Priority: Minor
> Attachments: THRIFT-3769.patch
>
>
> THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled
> servers, but the commit doesn't help in doing so (its just adding more
> specific noise today).
> This is because the transport factory overrides disallow throwing specific
> execution types (no TTransportException in signature), and thereby all
> implementations will throw a RuntimeException-wrapped exception, which the
> added catch clauses would never encounter.
> https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslServerTransport.java#L217-L219
> https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L290-L295
> We'll need to unwrap the RuntimeException to perform an actual valid cause
> check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459651#comment-16459651 ] ASF GitHub Bot commented on THRIFT-4532: jeking3 commented on issue #1541: THRIFT-4532: Do not update previously generated output files if the contents have not changed URL: https://github.com/apache/thrift/pull/1541#issuecomment-385657794 I updated the top level CHANGES file with a list of breaking changes since 0.11.0 that I could find through diffing README files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Avoid updating Thrift compiler generated code if the output has not changed > --- > > Key: THRIFT-4532 > URL: https://issues.apache.org/jira/browse/THRIFT-4532 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Affects Versions: 0.11.0 >Reporter: Buğra Gedik >Assignee: James E. King, III >Priority: Minor > Fix For: 0.12.0 > > > We would like to contribute an improvement to the Thrift compiler that would > avoid regenerating target file(s) if they are going to be exactly the same as > the ones already present in the same place. This will help when running the > Thrift compiler in our build, especially in recursive mode. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459642#comment-16459642 ] ASF GitHub Bot commented on THRIFT-4532: jeking3 commented on issue #1541: THRIFT-4532: Do not update previously generated output files if the contents have not changed URL: https://github.com/apache/thrift/pull/1541#issuecomment-385654952 Given this one passed all builds I'm going to merge it, I can update the readme separately. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Avoid updating Thrift compiler generated code if the output has not changed > --- > > Key: THRIFT-4532 > URL: https://issues.apache.org/jira/browse/THRIFT-4532 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Affects Versions: 0.11.0 >Reporter: Buğra Gedik >Assignee: James E. King, III >Priority: Minor > Fix For: 0.12.0 > > > We would like to contribute an improvement to the Thrift compiler that would > avoid regenerating target file(s) if they are going to be exactly the same as > the ones already present in the same place. This will help when running the > Thrift compiler in our build, especially in recursive mode. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4532. Resolution: Fixed Committed - thanks. > Avoid updating Thrift compiler generated code if the output has not changed > --- > > Key: THRIFT-4532 > URL: https://issues.apache.org/jira/browse/THRIFT-4532 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Affects Versions: 0.11.0 >Reporter: Buğra Gedik >Assignee: James E. King, III >Priority: Minor > Fix For: 0.12.0 > > > We would like to contribute an improvement to the Thrift compiler that would > avoid regenerating target file(s) if they are going to be exactly the same as > the ones already present in the same place. This will help when running the > Thrift compiler in our build, especially in recursive mode. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4532: -- Assignee: James E. King, III > Avoid updating Thrift compiler generated code if the output has not changed > --- > > Key: THRIFT-4532 > URL: https://issues.apache.org/jira/browse/THRIFT-4532 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Affects Versions: 0.11.0 >Reporter: Buğra Gedik >Assignee: James E. King, III >Priority: Minor > Fix For: 0.12.0 > > > We would like to contribute an improvement to the Thrift compiler that would > avoid regenerating target file(s) if they are going to be exactly the same as > the ones already present in the same place. This will help when running the > Thrift compiler in our build, especially in recursive mode. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
