[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615235#comment-16615235 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G commented on issue #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#issuecomment-421451152 Looking into it ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4634) Haskell builds with older cabal cannot reconcile complex version requirements
[
https://issues.apache.org/jira/browse/THRIFT-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615152#comment-16615152
]
ASF GitHub Bot commented on THRIFT-4634:
jeking3 opened a new pull request #1594: THRIFT-4634: work around cabal 1.22
dependency bug breaking CI job for Xenial
URL: https://github.com/apache/thrift/pull/1594
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Haskell builds with older cabal cannot reconcile complex version requirements
> -
>
> Key: THRIFT-4634
> URL: https://issues.apache.org/jira/browse/THRIFT-4634
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
>Affects Versions: 0.11.0
>Reporter: James E. King III
>Assignee: James E. King III
>Priority: Minor
>
> The cabal version in Ubuntu Xenial is 1.22.6.0 and it has been failing on CI
> since HTTP-4000 changed to allow "network < 2.8" - the resulting output is:
> {noformat}
> root@48ae26f5e4f3:/thrift/src/lib/hs# make
> /usr/bin/cabal update
> Downloading the latest package list from hackage.haskell.org
> Skipping download: Local and remote files match.
> /usr/bin/cabal install
> Resolving dependencies...
> cabal: Could not resolve dependencies:
> trying: thrift-1.0.0 (user goal)
> trying: network-2.8.0.0 (dependency of thrift-1.0.0)
> trying: HTTP-4000.3.12 (dependency of thrift-1.0.0)
> trying: HTTP-4000.3.12:-conduit10
> trying: HTTP-4000.3.12:-mtl1
> rejecting: HTTP-4000.3.12:+network-uri (conflict: network==2.8.0.0,
> HTTP-4000.3.12:network-uri => network>=2.6 && <2.8)
> rejecting: HTTP-4000.3.12:-network-uri (conflict: network==2.8.0.0,
> HTTP-4000.3.12:network-uri => network>=2.2.1.8 && <2.6)
> Backjump limit reached (change with --max-backjumps).
> Makefile:639: recipe for target 'all-local' failed
> make: *** [all-local] Error 1
> {noformat}
> thrift has no direct dependency on network 2.8.0.0 - why it is being selected
> first is beyond me. It should back off to 2.7.0.2 once it sees the
> network-uri set of dependencies. It looks like the cabal in Ubuntu Bionic
> doesn't have this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
AW: [jira] [Commented] (THRIFT-1939) C#: Real async support
No? Sent from mobile device, please ignore spelling mistakes. Von: James E. King III (JIRA) Gesendet: 14.09.2018 13:54 An: dev@thrift.apache.org Betreff: [jira] [Commented] (THRIFT-1939) C#: Real async support [ https://issues.apache.org/jira/browse/THRIFT-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614691#comment-16614691 ] James E. King III commented on THRIFT-1939: --- I suspect the csharp library will be replaced by the netcore library, new development is best targeted there. > C#: Real async support > -- > > Key: THRIFT-1939 > URL: https://issues.apache.org/jira/browse/THRIFT-1939 > Project: Thrift > Issue Type: New Feature > Components: C# - Compiler, C# - Library >Reporter: Carl Yeksigian >Assignee: Carl Yeksigian >Priority: Major > > This process would affect both the compiler and the library. The compiler > needs to generate real async-await functions, and the library needs to be > changed to use the async methods on Socket. > If this was the default C# library, then the language version required would > jump to C# 5, the .NET runtime required would be 4.5, and Mono support would > become "beta". I think a better way would be to release a second .NET 4.5 > library, with a new language parameter "csharp:5", or a new language > "csharp5". I'm more in favor of the former, but it may make the compiler a > little hairier to write. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
AW: [jira] [Commented] (THRIFT-4541) Use new project system in "lib/csharp" and define supported platforms
No? Sent from mobile device, please ignore spelling mistakes. Von: ASF GitHub Bot (JIRA) Gesendet: 14.09.2018 14:05 An: dev@thrift.apache.org Betreff: [jira] [Commented] (THRIFT-4541) Use new project system in "lib/csharp" and define supported platforms [ https://issues.apache.org/jira/browse/THRIFT-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614706#comment-16614706 ] ASF GitHub Bot commented on THRIFT-4541: jeking3 commented on issue #1532: [WIP] THRIFT-4541: Use new project system in lib/csharp URL: https://github.com/apache/thrift/pull/1532#issuecomment-421337840 I would recommend focusing on netcore for new development and leaving csharp as legacy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use new project system in "lib/csharp" and define supported platforms > - > > Key: THRIFT-4541 > URL: https://issues.apache.org/jira/browse/THRIFT-4541 > Project: Thrift > Issue Type: Umbrella > Components: C# - Library >Reporter: Christian Weiss >Priority: Major > > As discussed in THRIFT-4535, it would be great if we could update > "lib/csharp" to use the new "csproj" project system. This will allow us to > target multiple platforms and the new ".NET Standard" with a single project. > It's possible to support pretty much every platform there is with this new > project format (see e.g. > [Newtonsoft.Json|https://github.com/JamesNK/Newtonsoft.Json/blob/master/Src/Newtonsoft.Json/Newtonsoft.Json.csproj]), > however supporting older platforms requires more work as this requires more > #if statements etc. > This means that we have to decide which platforms we want to support! > Targeting ".NET Standard 2.0" would be the easiest option as this version > [covers a much larger API > surface|https://blogs.msdn.microsoft.com/dotnet/2017/08/14/announcing-net-standard-2-0/]. > However, this would also mean that people have to use rather recent versions > of their platforms to use it, as .NET Standard 2.0 requires the following > minimum versions: > * .NET 4.6.1 (adding support for .NET 4.5 is no problem though) > * .NET Core 2.0 > * Mono 5.4 > * Xamarin.iOS 10.14 > * Xamarin.Mac 3.8 > * Xamarin.Android 8.0 > * UWP 10.0.16299 > I will create a PR that targets .NET Standard 2.0 and .NET 4.5 to show what > the new project files would look like. If the approach is OK for you in > general, then I can try to add support for whatever minimum versions you'd > like to support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4631) Codegen Creates Invalid Ruby for Recursive Structs
[
https://issues.apache.org/jira/browse/THRIFT-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615139#comment-16615139
]
ASF GitHub Bot commented on THRIFT-4631:
cgardens edited a comment on issue #1592: THRIFT-4631 Fix Ruby codegen to gen
valid ruby for recursive structs
URL: https://github.com/apache/thrift/pull/1592#issuecomment-421433216
@jeking3 - thanks for reviewing so quickly!
It looks like the travis build is failing. I've gone through the logs and
I'm not finding anything in there that's specific to this change, but I know
these are famous last words...
From what I'm seeing it looks like the part of the build that's failing is
also failing on master.
build for this pr:
https://travis-ci.org/apache/thrift/builds/427781155?utm_source=github_status_medium=notification
build for master: https://travis-ci.org/apache/thrift
Am I missing something here? Let me know if there's something more I should
be doing. Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Codegen Creates Invalid Ruby for Recursive Structs
> --
>
> Key: THRIFT-4631
> URL: https://issues.apache.org/jira/browse/THRIFT-4631
> Project: Thrift
> Issue Type: Bug
> Components: Ruby - Compiler, Ruby - Library
>Affects Versions: 0.11.0
>Reporter: charles giardina
>Priority: Minor
>
> Though thrift supports defining recursive structs, it appears that the Ruby
> codegen does not generate valid Ruby for for recursive structs.
> e.g. Here's an example of what I'm seeing and how to recreate it using
> Recursive.thrift in the Thrift test suite.
> * add {{$(THRIFT) --gen rb ../Recursive.thrift}} to {{test/rb/Makefile.am}}
> * and add {{require "recursive_types"}} to
> {{test/rb/generation/test_struct.rb}}
> * run {{make -k check}} from {{test/rb}}
> * this ends up raising the following exception:
> {code:java}
> thrift/test/rb/gen-rb/recursive_types.rb:50:in `': uninitialized
> constant CoRec2 (NameError)
> Did you mean? CoRec
> from thrift/test/rb/gen-rb/recursive_types.rb:45:in `'
> from thrift/test/rb/generation/test_struct.rb:22:in `require'
> from thrift/test/rb/generation/test_struct.rb:22:in `'
> from test_suite.rb:20:in `require'
> from test_suite.rb:20:in `block in '
> from test_suite.rb:20:in `each'
> from test_suite.rb:20:in `'
> make: *** [check] Error 1
> {code}
>
> I've copied the generated code below. But essentially the issue appears to be
> that recursive structs are referencing constants or classes that have not yet
> been declared. I have some ideas on how to address this and can post a
> proposed solution.
>
> generated code:
> {code:java}
> #
> # Autogenerated by Thrift Compiler (0.11.0)
> #
> # DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
> #
> require 'thrift'
> module RecursiveExample
> class Node < ::Thrift::Union
> include ::Thrift::Struct_Union
> class << self
> def inner_node(val)
> Node.new(:inner_node, val)
> end
> def leaf_node(val)
> Node.new(:leaf_node, val)
> end
> end
> INNER_NODE = 1
> LEAF_NODE = 2
> FIELDS = {
> INNER_NODE => {:type => ::Thrift::Types::STRUCT, :name => 'inner_node',
> :class => ::RecursiveExample::InnerNode, :optional => true},
> LEAF_NODE => {:type => ::Thrift::Types::STRUCT, :name => 'leaf_node',
> :class => ::RecursiveExample::LeafNode, :optional => true}
> }
> def struct_fields; FIELDS; end
> def validate
> raise(StandardError, 'Union fields are not set.') if get_set_field.nil?
> || get_value.nil?
> end
> ::Thrift::Union.generate_accessors self
> end
> class InnerNode
> include ::Thrift::Struct, ::Thrift::Struct_Union
> NODE = 1
> FIELDS = {
> NODE => {:type => ::Thrift::Types::STRUCT, :name => 'node', :class =>
> ::RecursiveExample::Node}
> }
> def struct_fields; FIELDS; end
> def validate
> raise
> ::Thrift::ProtocolException.new(::Thrift::ProtocolException::UNKNOWN,
> 'Required field node is unset!') unless @nodeend
> ::Thrift::Struct.generate_accessors self
> end
> class LeafNode
> include ::Thrift::Struct, ::Thrift::Struct_Union
> FIELDS = {
> }
> def struct_fields; FIELDS; end
> def validate
> end
> ::Thrift::Struct.generate_accessors self
> end
> end
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4631) Codegen Creates Invalid Ruby for Recursive Structs
[
https://issues.apache.org/jira/browse/THRIFT-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615138#comment-16615138
]
ASF GitHub Bot commented on THRIFT-4631:
cgardens commented on issue #1592: THRIFT-4631 Fix Ruby codegen to gen valid
ruby for recursive structs
URL: https://github.com/apache/thrift/pull/1592#issuecomment-421433216
@jeking3 - thanks for reviewing so quickly!
It looks like the travis build is failing. I've gone through the logs and
I'm not finding anything in there that's specific to this change, but I know
these are famous last words...
From what I'm seeing it looks like the part of the build that's failing is
also failing on master.
build for this pr:
https://travis-ci.org/apache/thrift/builds/427781155?utm_source=github_status_medium=notification
build for master: https://travis-ci.org/apache/thrift
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Codegen Creates Invalid Ruby for Recursive Structs
> --
>
> Key: THRIFT-4631
> URL: https://issues.apache.org/jira/browse/THRIFT-4631
> Project: Thrift
> Issue Type: Bug
> Components: Ruby - Compiler, Ruby - Library
>Affects Versions: 0.11.0
>Reporter: charles giardina
>Priority: Minor
>
> Though thrift supports defining recursive structs, it appears that the Ruby
> codegen does not generate valid Ruby for for recursive structs.
> e.g. Here's an example of what I'm seeing and how to recreate it using
> Recursive.thrift in the Thrift test suite.
> * add {{$(THRIFT) --gen rb ../Recursive.thrift}} to {{test/rb/Makefile.am}}
> * and add {{require "recursive_types"}} to
> {{test/rb/generation/test_struct.rb}}
> * run {{make -k check}} from {{test/rb}}
> * this ends up raising the following exception:
> {code:java}
> thrift/test/rb/gen-rb/recursive_types.rb:50:in `': uninitialized
> constant CoRec2 (NameError)
> Did you mean? CoRec
> from thrift/test/rb/gen-rb/recursive_types.rb:45:in `'
> from thrift/test/rb/generation/test_struct.rb:22:in `require'
> from thrift/test/rb/generation/test_struct.rb:22:in `'
> from test_suite.rb:20:in `require'
> from test_suite.rb:20:in `block in '
> from test_suite.rb:20:in `each'
> from test_suite.rb:20:in `'
> make: *** [check] Error 1
> {code}
>
> I've copied the generated code below. But essentially the issue appears to be
> that recursive structs are referencing constants or classes that have not yet
> been declared. I have some ideas on how to address this and can post a
> proposed solution.
>
> generated code:
> {code:java}
> #
> # Autogenerated by Thrift Compiler (0.11.0)
> #
> # DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
> #
> require 'thrift'
> module RecursiveExample
> class Node < ::Thrift::Union
> include ::Thrift::Struct_Union
> class << self
> def inner_node(val)
> Node.new(:inner_node, val)
> end
> def leaf_node(val)
> Node.new(:leaf_node, val)
> end
> end
> INNER_NODE = 1
> LEAF_NODE = 2
> FIELDS = {
> INNER_NODE => {:type => ::Thrift::Types::STRUCT, :name => 'inner_node',
> :class => ::RecursiveExample::InnerNode, :optional => true},
> LEAF_NODE => {:type => ::Thrift::Types::STRUCT, :name => 'leaf_node',
> :class => ::RecursiveExample::LeafNode, :optional => true}
> }
> def struct_fields; FIELDS; end
> def validate
> raise(StandardError, 'Union fields are not set.') if get_set_field.nil?
> || get_value.nil?
> end
> ::Thrift::Union.generate_accessors self
> end
> class InnerNode
> include ::Thrift::Struct, ::Thrift::Struct_Union
> NODE = 1
> FIELDS = {
> NODE => {:type => ::Thrift::Types::STRUCT, :name => 'node', :class =>
> ::RecursiveExample::Node}
> }
> def struct_fields; FIELDS; end
> def validate
> raise
> ::Thrift::ProtocolException.new(::Thrift::ProtocolException::UNKNOWN,
> 'Required field node is unset!') unless @nodeend
> ::Thrift::Struct.generate_accessors self
> end
> class LeafNode
> include ::Thrift::Struct, ::Thrift::Struct_Union
> FIELDS = {
> }
> def struct_fields; FIELDS; end
> def validate
> end
> ::Thrift::Struct.generate_accessors self
> end
> end
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4634) Haskell builds with older cabal cannot reconcile complex version requirements
[
https://issues.apache.org/jira/browse/THRIFT-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615113#comment-16615113
]
James E. King III commented on THRIFT-4634:
---
Version 1.24.0.2 of cabal seems to work.
> Haskell builds with older cabal cannot reconcile complex version requirements
> -
>
> Key: THRIFT-4634
> URL: https://issues.apache.org/jira/browse/THRIFT-4634
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
>Affects Versions: 0.11.0
>Reporter: James E. King III
>Assignee: James E. King III
>Priority: Minor
>
> The cabal version in Ubuntu Xenial is 1.22.6.0 and it has been failing on CI
> since HTTP-4000 changed to allow "network < 2.8" - the resulting output is:
> {noformat}
> root@48ae26f5e4f3:/thrift/src/lib/hs# make
> /usr/bin/cabal update
> Downloading the latest package list from hackage.haskell.org
> Skipping download: Local and remote files match.
> /usr/bin/cabal install
> Resolving dependencies...
> cabal: Could not resolve dependencies:
> trying: thrift-1.0.0 (user goal)
> trying: network-2.8.0.0 (dependency of thrift-1.0.0)
> trying: HTTP-4000.3.12 (dependency of thrift-1.0.0)
> trying: HTTP-4000.3.12:-conduit10
> trying: HTTP-4000.3.12:-mtl1
> rejecting: HTTP-4000.3.12:+network-uri (conflict: network==2.8.0.0,
> HTTP-4000.3.12:network-uri => network>=2.6 && <2.8)
> rejecting: HTTP-4000.3.12:-network-uri (conflict: network==2.8.0.0,
> HTTP-4000.3.12:network-uri => network>=2.2.1.8 && <2.6)
> Backjump limit reached (change with --max-backjumps).
> Makefile:639: recipe for target 'all-local' failed
> make: *** [all-local] Error 1
> {noformat}
> thrift has no direct dependency on network 2.8.0.0 - why it is being selected
> first is beyond me. It should back off to 2.7.0.2 once it sees the
> network-uri set of dependencies. It looks like the cabal in Ubuntu Bionic
> doesn't have this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (THRIFT-4634) Haskell builds with older cabal cannot reconcile complex version requirements
James E. King III created THRIFT-4634: - Summary: Haskell builds with older cabal cannot reconcile complex version requirements Key: THRIFT-4634 URL: https://issues.apache.org/jira/browse/THRIFT-4634 Project: Thrift Issue Type: Bug Components: Haskell - Library Affects Versions: 0.11.0 Reporter: James E. King III Assignee: James E. King III The cabal version in Ubuntu Xenial is 1.22.6.0 and it has been failing on CI since HTTP-4000 changed to allow "network < 2.8" - the resulting output is: ``` root@48ae26f5e4f3:/thrift/src/lib/hs# make /usr/bin/cabal update Downloading the latest package list from hackage.haskell.org Skipping download: Local and remote files match. /usr/bin/cabal install Resolving dependencies... cabal: Could not resolve dependencies: trying: thrift-1.0.0 (user goal) trying: network-2.8.0.0 (dependency of thrift-1.0.0) trying: HTTP-4000.3.12 (dependency of thrift-1.0.0) trying: HTTP-4000.3.12:-conduit10 trying: HTTP-4000.3.12:-mtl1 rejecting: HTTP-4000.3.12:+network-uri (conflict: network==2.8.0.0, HTTP-4000.3.12:network-uri => network>=2.6 && <2.8) rejecting: HTTP-4000.3.12:-network-uri (conflict: network==2.8.0.0, HTTP-4000.3.12:network-uri => network>=2.2.1.8 && <2.6) Backjump limit reached (change with --max-backjumps). Makefile:639: recipe for target 'all-local' failed make: *** [all-local] Error 1 ``` thrift has no direct dependency on network 2.8.0.0 - why it is being selected first is beyond me. It should back off to 2.7.0.2 once it sees the network-uri set of dependencies. It looks like the cabal in Ubuntu Bionic doesn't have this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (THRIFT-4634) Haskell builds with older cabal cannot reconcile complex version requirements
[
https://issues.apache.org/jira/browse/THRIFT-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III updated THRIFT-4634:
--
Description:
The cabal version in Ubuntu Xenial is 1.22.6.0 and it has been failing on CI
since HTTP-4000 changed to allow "network < 2.8" - the resulting output is:
{noformat}
root@48ae26f5e4f3:/thrift/src/lib/hs# make
/usr/bin/cabal update
Downloading the latest package list from hackage.haskell.org
Skipping download: Local and remote files match.
/usr/bin/cabal install
Resolving dependencies...
cabal: Could not resolve dependencies:
trying: thrift-1.0.0 (user goal)
trying: network-2.8.0.0 (dependency of thrift-1.0.0)
trying: HTTP-4000.3.12 (dependency of thrift-1.0.0)
trying: HTTP-4000.3.12:-conduit10
trying: HTTP-4000.3.12:-mtl1
rejecting: HTTP-4000.3.12:+network-uri (conflict: network==2.8.0.0,
HTTP-4000.3.12:network-uri => network>=2.6 && <2.8)
rejecting: HTTP-4000.3.12:-network-uri (conflict: network==2.8.0.0,
HTTP-4000.3.12:network-uri => network>=2.2.1.8 && <2.6)
Backjump limit reached (change with --max-backjumps).
Makefile:639: recipe for target 'all-local' failed
make: *** [all-local] Error 1
{noformat}
thrift has no direct dependency on network 2.8.0.0 - why it is being selected
first is beyond me. It should back off to 2.7.0.2 once it sees the network-uri
set of dependencies. It looks like the cabal in Ubuntu Bionic doesn't have
this problem.
was:
The cabal version in Ubuntu Xenial is 1.22.6.0 and it has been failing on CI
since HTTP-4000 changed to allow "network < 2.8" - the resulting output is:
```
root@48ae26f5e4f3:/thrift/src/lib/hs# make
/usr/bin/cabal update
Downloading the latest package list from hackage.haskell.org
Skipping download: Local and remote files match.
/usr/bin/cabal install
Resolving dependencies...
cabal: Could not resolve dependencies:
trying: thrift-1.0.0 (user goal)
trying: network-2.8.0.0 (dependency of thrift-1.0.0)
trying: HTTP-4000.3.12 (dependency of thrift-1.0.0)
trying: HTTP-4000.3.12:-conduit10
trying: HTTP-4000.3.12:-mtl1
rejecting: HTTP-4000.3.12:+network-uri (conflict: network==2.8.0.0,
HTTP-4000.3.12:network-uri => network>=2.6 && <2.8)
rejecting: HTTP-4000.3.12:-network-uri (conflict: network==2.8.0.0,
HTTP-4000.3.12:network-uri => network>=2.2.1.8 && <2.6)
Backjump limit reached (change with --max-backjumps).
Makefile:639: recipe for target 'all-local' failed
make: *** [all-local] Error 1
```
thrift has no direct dependency on network 2.8.0.0 - why it is being selected
first is beyond me. It should back off to 2.7.0.2 once it sees the network-uri
set of dependencies. It looks like the cabal in Ubuntu Bionic doesn't have
this problem.
> Haskell builds with older cabal cannot reconcile complex version requirements
> -
>
> Key: THRIFT-4634
> URL: https://issues.apache.org/jira/browse/THRIFT-4634
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
>Affects Versions: 0.11.0
>Reporter: James E. King III
>Assignee: James E. King III
>Priority: Minor
>
> The cabal version in Ubuntu Xenial is 1.22.6.0 and it has been failing on CI
> since HTTP-4000 changed to allow "network < 2.8" - the resulting output is:
> {noformat}
> root@48ae26f5e4f3:/thrift/src/lib/hs# make
> /usr/bin/cabal update
> Downloading the latest package list from hackage.haskell.org
> Skipping download: Local and remote files match.
> /usr/bin/cabal install
> Resolving dependencies...
> cabal: Could not resolve dependencies:
> trying: thrift-1.0.0 (user goal)
> trying: network-2.8.0.0 (dependency of thrift-1.0.0)
> trying: HTTP-4000.3.12 (dependency of thrift-1.0.0)
> trying: HTTP-4000.3.12:-conduit10
> trying: HTTP-4000.3.12:-mtl1
> rejecting: HTTP-4000.3.12:+network-uri (conflict: network==2.8.0.0,
> HTTP-4000.3.12:network-uri => network>=2.6 && <2.8)
> rejecting: HTTP-4000.3.12:-network-uri (conflict: network==2.8.0.0,
> HTTP-4000.3.12:network-uri => network>=2.2.1.8 && <2.6)
> Backjump limit reached (change with --max-backjumps).
> Makefile:639: recipe for target 'all-local' failed
> make: *** [all-local] Error 1
> {noformat}
> thrift has no direct dependency on network 2.8.0.0 - why it is being selected
> first is beyond me. It should back off to 2.7.0.2 once it sees the
> network-uri set of dependencies. It looks like the cabal in Ubuntu Bionic
> doesn't have this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-3458) Register thrift in D package registry
[ https://issues.apache.org/jira/browse/THRIFT-3458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614821#comment-16614821 ] ASF GitHub Bot commented on THRIFT-3458: jeking3 opened a new pull request #1593: THRIFT-3458: add dub support for dlang URL: https://github.com/apache/thrift/pull/1593 This is in preparation to add thrift to the dub package manager for dlang. This allows "dub build" and "dub test" to complete successfully when run from the top level directory. This closes #723 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Register thrift in D package registry > - > > Key: THRIFT-3458 > URL: https://issues.apache.org/jira/browse/THRIFT-3458 > Project: Thrift > Issue Type: Improvement > Components: D - Compiler, D - Library >Reporter: Tolstokulakov Nikolay >Assignee: James E. King III >Priority: Major > > add dub.sdl or dub.json and register it at code.dlang.org #723 has this work. > from THRIFT-4504: use dub to build the dlang bits and pull in the deimos > dependencies properly instead of putting them into the dockerfile for the CI > build. #1380 has most of this work. > The effort in #723 and #1380 are highly related and should be combined. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4541) Use new project system in "lib/csharp" and define supported platforms
[ https://issues.apache.org/jira/browse/THRIFT-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614706#comment-16614706 ] ASF GitHub Bot commented on THRIFT-4541: jeking3 commented on issue #1532: [WIP] THRIFT-4541: Use new project system in lib/csharp URL: https://github.com/apache/thrift/pull/1532#issuecomment-421337840 I would recommend focusing on netcore for new development and leaving csharp as legacy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use new project system in "lib/csharp" and define supported platforms > - > > Key: THRIFT-4541 > URL: https://issues.apache.org/jira/browse/THRIFT-4541 > Project: Thrift > Issue Type: Umbrella > Components: C# - Library >Reporter: Christian Weiss >Priority: Major > > As discussed in THRIFT-4535, it would be great if we could update > "lib/csharp" to use the new "csproj" project system. This will allow us to > target multiple platforms and the new ".NET Standard" with a single project. > It's possible to support pretty much every platform there is with this new > project format (see e.g. > [Newtonsoft.Json|https://github.com/JamesNK/Newtonsoft.Json/blob/master/Src/Newtonsoft.Json/Newtonsoft.Json.csproj]), > however supporting older platforms requires more work as this requires more > #if statements etc. > This means that we have to decide which platforms we want to support! > Targeting ".NET Standard 2.0" would be the easiest option as this version > [covers a much larger API > surface|https://blogs.msdn.microsoft.com/dotnet/2017/08/14/announcing-net-standard-2-0/]. > However, this would also mean that people have to use rather recent versions > of their platforms to use it, as .NET Standard 2.0 requires the following > minimum versions: > * .NET 4.6.1 (adding support for .NET 4.5 is no problem though) > * .NET Core 2.0 > * Mono 5.4 > * Xamarin.iOS 10.14 > * Xamarin.Mac 3.8 > * Xamarin.Android 8.0 > * UWP 10.0.16299 > I will create a PR that targets .NET Standard 2.0 and .NET 4.5 to show what > the new project files would look like. If the approach is OK for you in > general, then I can try to add support for whatever minimum versions you'd > like to support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614703#comment-16614703 ] ASF GitHub Bot commented on THRIFT-4551: jeking3 commented on issue #1548: THRIFT-4551: Run 'yarn prettier' to consistently format JS files URL: https://github.com/apache/thrift/pull/1548#issuecomment-421337471 @NameFILIP will you be able to resolve these issues? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add prettier for consistent JS code formatting > -- > > Key: THRIFT-4551 > URL: https://issues.apache.org/jira/browse/THRIFT-4551 > Project: Thrift > Issue Type: Improvement >Reporter: Filip Spiridonov >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > [Prettier|https://prettier.io/] is awesome. See > [why|https://prettier.io/docs/en/why-prettier.html] you should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4600) Don't close the connection in flush for python THttpClient.py
[
https://issues.apache.org/jira/browse/THRIFT-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614701#comment-16614701
]
ASF GitHub Bot commented on THRIFT-4600:
jeking3 commented on issue #1572: THRIFT-4600: fix-flush-on-THttpClient
URL: https://github.com/apache/thrift/pull/1572#issuecomment-421337344
@finncolman will you be able to resolve the new build failures?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Don't close the connection in flush for python THttpClient.py
> -
>
> Key: THRIFT-4600
> URL: https://issues.apache.org/jira/browse/THRIFT-4600
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.11.0
>Reporter: Finn Isaac Norris Colman
>Priority: Major
> Fix For: 0.11.0
>
> Attachments: 1572.patch
>
>
> In thrift/lib/py/src/transport/THttpClient.py in the flush method it closes
> and reopens the connection:
> {noformat}
> if self.isOpen():
> self.close()
> self.open(){noformat}
>
> This code is closing the connection on every flush request. The flush request
> occurs for every message send, which means that keep alive cannot be used.
> Removing this code from flush means that keep alive can be used as the user
> now has control over when the connection is closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (THRIFT-4633) Add C# Async Client Tutorial
James E. King III created THRIFT-4633: - Summary: Add C# Async Client Tutorial Key: THRIFT-4633 URL: https://issues.apache.org/jira/browse/THRIFT-4633 Project: Thrift Issue Type: Improvement Components: C# - Library Affects Versions: 0.11.0 Reporter: James E. King III Assignee: James E. King III Fix For: 0.12.0 Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-1939) C#: Real async support
[ https://issues.apache.org/jira/browse/THRIFT-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614691#comment-16614691 ] James E. King III commented on THRIFT-1939: --- I suspect the csharp library will be replaced by the netcore library, new development is best targeted there. > C#: Real async support > -- > > Key: THRIFT-1939 > URL: https://issues.apache.org/jira/browse/THRIFT-1939 > Project: Thrift > Issue Type: New Feature > Components: C# - Compiler, C# - Library >Reporter: Carl Yeksigian >Assignee: Carl Yeksigian >Priority: Major > > This process would affect both the compiler and the library. The compiler > needs to generate real async-await functions, and the library needs to be > changed to use the async methods on Socket. > If this was the default C# library, then the language version required would > jump to C# 5, the .NET runtime required would be 4.5, and Mono support would > become "beta". I think a better way would be to release a second .NET 4.5 > library, with a new language parameter "csharp:5", or a new language > "csharp5". I'm more in favor of the former, but it may make the compiler a > little hairier to write. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (THRIFT-4632) .NET core generator incorrectly uses Isset with nullable
Rodney Aaron Stainback created THRIFT-4632: -- Summary: .NET core generator incorrectly uses Isset with nullable Key: THRIFT-4632 URL: https://issues.apache.org/jira/browse/THRIFT-4632 Project: Thrift Issue Type: Bug Components: .NETCore - Compiler Affects Versions: 0.11.0 Reporter: Rodney Aaron Stainback Looks like the bug in on this line bool generate_isset = (nullable_ && has_non_required_default_value_fields) || (!nullable_ && has_non_required_fields); I think it should be bool generate_isset = (!nullable_ && has_non_required_fields); -- This message was sent by Atlassian JIRA (v7.6.3#76005)
