[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1443#comment-1443
 ] 

ASF GitHub Bot commented on THRIFT-4654:


jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 
compatibility (backwards compatible)
URL: https://github.com/apache/thrift/pull/1617#issuecomment-433715742
 
 
   Looks like you need to rebase your changes on the tip.  If you are getting 
flake8 issues in the build you must have branched off some other point where 
those issues existed.  Current builds are running clean (with some retries, 
admittedly).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Thrift Dart port is not compatible with Dart 2
> --
>
> Key: THRIFT-4654
> URL: https://issues.apache.org/jira/browse/THRIFT-4654
> Project: Thrift
>  Issue Type: Improvement
>  Components: Dart - Library
> Environment: Any OS, under Dart 2+
>Reporter: Rob Becker
>Assignee: James E. King III
>Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires 
> opting in via a setting in the pubspec.yaml and the code needs to update the 
> use of all caps constant names to the new camel case names.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (THRIFT-4653) ES6 Classes

[James E. King III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King III resolved THRIFT-4653.
---
   Resolution: Fixed
 Assignee: James E. King III
Fix Version/s: 1.0

Committed - thanks.  Not in the 0.12.0 branch, but if someone pulls it in, 
we'll modify the "Fix Version/s" field.

> ES6 Classes
> ---
>
> Key: THRIFT-4653
> URL: https://issues.apache.org/jira/browse/THRIFT-4653
> Project: Thrift
>  Issue Type: Improvement
>  Components: JavaScript - Compiler, Node.js - Compiler
>Reporter: Brian Forbis
>Assignee: James E. King III
>Priority: Minor
> Fix For: 1.0
>
>
> Updating the generated code to generate ES6 classes when using the es6 
> compiler option. ES6 classes should be a drop in replacement for manual ES5 
> prototypical inheritance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)