[jira] [Updated] (THRIFT-2023) gettimeofday implementation on Windows errors when no time zone is passed in.

2013-06-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2023: -- Issue Type: Bug (was: Improvement) gettimeofday implementation on Windows errors when no time

[jira] [Updated] (THRIFT-2022) CoB and dense code generation still uses TR1 bind, even though that doesn't work with clang

2013-06-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2022: -- Issue Type: Bug (was: Improvement) CoB and dense code generation still uses TR1 bind, even

[jira] [Created] (THRIFT-2025) Fix TSSLServerSocket 64-bit builds

2013-06-13 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-2025: - Summary: Fix TSSLServerSocket 64-bit builds Key: THRIFT-2025 URL: https://issues.apache.org/jira/browse/THRIFT-2025 Project: Thrift Issue Type: Bug

[jira] [Updated] (THRIFT-2025) Fix TSSLServerSocket 64-bit builds

2013-06-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2025: -- Attachment: ssl_port.patch Fix TSSLServerSocket 64-bit builds

[jira] [Created] (THRIFT-2024) TServer.cpp warns on 64-bit platforms about truncating an rlim_t into an int

2013-06-13 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-2024: - Summary: TServer.cpp warns on 64-bit platforms about truncating an rlim_t into an int Key: THRIFT-2024 URL: https://issues.apache.org/jira/browse/THRIFT-2024 Project:

[jira] [Updated] (THRIFT-2026) Fix TCompactProtocol 64 bit builds

2013-06-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2026: -- Attachment: compact_int_stuff.patch Fix TCompactProtocol 64 bit builds

[jira] [Created] (THRIFT-2026) Fix TCompactProtocol 64 bit builds

2013-06-13 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-2026: - Summary: Fix TCompactProtocol 64 bit builds Key: THRIFT-2026 URL: https://issues.apache.org/jira/browse/THRIFT-2026 Project: Thrift Issue Type: Bug

[jira] [Created] (THRIFT-2027) Minor 64-bit and NOMINMAX issues in C++ library

2013-06-13 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-2027: - Summary: Minor 64-bit and NOMINMAX issues in C++ library Key: THRIFT-2027 URL: https://issues.apache.org/jira/browse/THRIFT-2027 Project: Thrift Issue Type: Bug

[jira] [Updated] (THRIFT-2027) Minor 64-bit and NOMINMAX issues in C++ library

2013-06-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2027: -- Attachment: misc_minor.patch Minor 64-bit and NOMINMAX issues in C++ library

[jira] [Created] (THRIFT-2028) Cleanup threading headers / libraries

2013-06-13 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-2028: - Summary: Cleanup threading headers / libraries Key: THRIFT-2028 URL: https://issues.apache.org/jira/browse/THRIFT-2028 Project: Thrift Issue Type: Improvement

[jira] [Updated] (THRIFT-2028) Cleanup threading headers / libraries

2013-06-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2028: -- Attachment: thread_cleanup.patch Cleanup threading headers / libraries

[jira] [Updated] (THRIFT-2029) Port C++ tests to Windows

2013-06-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-2029: -- Attachment: porting_tests.patch Port C++ tests to Windows -

[jira] [Created] (THRIFT-2029) Port C++ tests to Windows

2013-06-13 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-2029: - Summary: Port C++ tests to Windows Key: THRIFT-2029 URL: https://issues.apache.org/jira/browse/THRIFT-2029 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-2014) Change C++ lib includes to use namespace/ style throughout

2013-06-10 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679490#comment-13679490 ] Ben Craig commented on THRIFT-2014: --- I would love for thrift/config.h to be the proper

[jira] [Commented] (THRIFT-1753) Multiple C++ Windows, OSX, and iOS portability issues

2013-06-08 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678766#comment-13678766 ] Ben Craig commented on THRIFT-1753: --- Short answer: I don't think the boost header

[jira] [Commented] (THRIFT-1753) Multiple C++ Windows, OSX, and iOS portability issues

2013-06-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678059#comment-13678059 ] Ben Craig commented on THRIFT-1753: --- Should be able to close out THRIFT-990 as well

[jira] [Commented] (THRIFT-1948) Add a stream type

2013-05-03 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648694#comment-13648694 ] Ben Craig commented on THRIFT-1948: --- What would the generated interfaces look like for

[jira] [Commented] (THRIFT-1948) Add a stream type

2013-05-03 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648988#comment-13648988 ] Ben Craig commented on THRIFT-1948: --- If you can show sort of what the Java or C# code

[jira] [Commented] (THRIFT-1890) C++: Make named pipes server work asynchronously

2013-03-19 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606371#comment-13606371 ] Ben Craig commented on THRIFT-1890: --- This made progress, but at least with the threaded

[jira] [Updated] (THRIFT-1890) C++: Make named pipes server work asynchronously

2013-03-19 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1890: -- Attachment: pipeStopTest.cpp addNumbers.thrift Toy test case programs for exercising

[jira] [Updated] (THRIFT-1890) C++: Make named pipes server work asynchronously

2013-03-19 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1890: -- Attachment: TPipeServer.cpp Changes that work for me. This file is likely hilariously out of date of

[jira] [Commented] (THRIFT-1891) Add Windows ALPC transport which is right counterpart of Unix domain sockets

2013-03-18 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605116#comment-13605116 ] Ben Craig commented on THRIFT-1891: --- Note the first sentence in the Wikipedia document:

[jira] [Commented] (THRIFT-1890) C++: Make named pipes server work asynchronously

2013-03-18 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605191#comment-13605191 ] Ben Craig commented on THRIFT-1890: --- Did some testing, and didn't have much luck. I

[jira] [Commented] (THRIFT-1892) Socket timeouts are declared in milli-seconds, but are actually set in micro-seconds

2013-03-18 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605247#comment-13605247 ] Ben Craig commented on THRIFT-1892: --- I looked at the code, and timeouts are wrong for

[jira] [Commented] (THRIFT-1890) C++: Make named pipes server work asynchronously

2013-03-15 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604120#comment-13604120 ] Ben Craig commented on THRIFT-1890: --- This will probably fix THRIFT-1777. I hope to be

[jira] [Commented] (THRIFT-1880) Make named pipes server work asynchronously (overlapped) to allow for clean server stops

2013-03-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599476#comment-13599476 ] Ben Craig commented on THRIFT-1880: --- Aww, only Delphi. I was getting excited that

[jira] [Commented] (THRIFT-1880) Make named pipes server work asynchronously (overlapped) to allow for clean server stops

2013-03-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599612#comment-13599612 ] Ben Craig commented on THRIFT-1880: --- If you post a C++ patch, I will gladly review it.

[jira] [Commented] (THRIFT-1875) BoostThreadFactory not compiling

2013-03-06 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13594805#comment-13594805 ] Ben Craig commented on THRIFT-1875: --- My suspicion is that this is the wrong fix for the

[jira] [Commented] (THRIFT-1870) Enhance TPipe / TPipeServer transport to support both Windows 64-bit and cross-platform *NIX support

2013-03-02 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591571#comment-13591571 ] Ben Craig commented on THRIFT-1870: --- I have been on a Windows development hiatus for

[jira] [Commented] (THRIFT-1870) Enhance TPipe / TPipeServer transport to support both Windows 64-bit and cross-platform *NIX support

2013-03-01 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591178#comment-13591178 ] Ben Craig commented on THRIFT-1870: --- So the main changes that I see that improve

[jira] [Commented] (THRIFT-1870) Enhance TPipe / TPipeServer transport to support both Windows 64-bit and cross-platform *NIX support

2013-03-01 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591298#comment-13591298 ] Ben Craig commented on THRIFT-1870: --- I understand that client code should have as few

[jira] [Commented] (THRIFT-1865) Thrift don't build on Android

2013-02-24 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585518#comment-13585518 ] Ben Craig commented on THRIFT-1865: --- This is a duplicate of THRIFT-1846, and

[jira] [Commented] (THRIFT-1846) Restore socket.h header to support builds with Android NDK

2013-02-11 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576342#comment-13576342 ] Ben Craig commented on THRIFT-1846: --- Just make sure that sockaddr, sockaddr_in,

[jira] [Commented] (THRIFT-1846) Restore socket.h header to support builds with Android NDK

2013-01-29 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565504#comment-13565504 ] Ben Craig commented on THRIFT-1846: --- THRIFT-1740 moved the #include from the .cpp to

[jira] [Commented] (THRIFT-1846) Restore socket.h header to support builds with Android NDK

2013-01-29 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565529#comment-13565529 ] Ben Craig commented on THRIFT-1846: --- The original patch is fine. I foolishly assumed

[jira] [Commented] (THRIFT-1740) Make C++ library build on OS X and iOS

2013-01-20 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558497#comment-13558497 ] Ben Craig commented on THRIFT-1740: --- I wasn't doing testing with cob_style when I made

[jira] [Commented] (THRIFT-1834) Unable to build C++ Thrift dynamic library on Windows

2013-01-18 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557513#comment-13557513 ] Ben Craig commented on THRIFT-1834: --- Currently, Thrift is designed to be packaged as a

[jira] [Created] (THRIFT-1776) TPipeServer should implement listen, so that TServerEventHandler preServe will work right

2012-12-05 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-1776: - Summary: TPipeServer should implement listen, so that TServerEventHandler preServe will work right Key: THRIFT-1776 URL: https://issues.apache.org/jira/browse/THRIFT-1776

[jira] [Created] (THRIFT-1777) TPipeServer is UNSTOPPABLE

2012-12-05 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-1777: - Summary: TPipeServer is UNSTOPPABLE Key: THRIFT-1777 URL: https://issues.apache.org/jira/browse/THRIFT-1777 Project: Thrift Issue Type: Bug Components:

[jira] [Updated] (THRIFT-1753) Multiple C++ Windows, OSX, and iOS portability issues

2012-12-04 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1753: -- Attachment: cleaner_port4.patch Same as last patch, but now starting the TFileTransport flush thread,

[jira] [Updated] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2012-12-04 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1750: -- Attachment: (was: compiler_cleanup.patch) Make compiler build cleanly under visual studio 10

[jira] [Updated] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2012-12-04 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1750: -- Attachment: compiler_cleanup.patch Putting a newline at the end of platform.h that was accidentally

[jira] [Commented] (THRIFT-1481) Unix domain sockets in C++ do not support the abstract namespace

2012-12-04 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509818#comment-13509818 ] Ben Craig commented on THRIFT-1481: --- I should be able to provide a .patch for this once

[jira] [Commented] (THRIFT-1771) make check fails on x64 for libboost_unit_test_framework.a

2012-12-03 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508845#comment-13508845 ] Ben Craig commented on THRIFT-1771: --- I don't know if it currently configurable in

[jira] [Updated] (THRIFT-1753) Multiple C++ Windows, OSX, and iOS portability issues

2012-11-27 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1753: -- Attachment: cleaner_port3.patch Addresses the same issues mentioned above, plus it fixes THRIFT-990

[jira] [Commented] (THRIFT-990) Sanify gettimeofday usage codebase-wide

2012-11-27 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504885#comment-13504885 ] Ben Craig commented on THRIFT-990: -- Mega-fix posted on THRIFT-1753

[jira] [Commented] (THRIFT-1740) Make C++ library build on OS X and iOS

2012-11-16 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13498824#comment-13498824 ] Ben Craig commented on THRIFT-1740: --- Thanks for getting this committed! I will see

[jira] [Updated] (THRIFT-1753) Multiple C++ Windows, OSX, and iOS portability issues

2012-11-16 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1753: -- Attachment: cleaner_port2.patch Does not yet address THRIFT-990. Still contains

[jira] [Updated] (THRIFT-1753) Multiple C++ Windows, OSX, and iOS portability issues

2012-11-16 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1753: -- Attachment: (was: cleaner_port.patch) Multiple C++ Windows, OSX, and iOS portability issues

[jira] [Commented] (THRIFT-1690) Sockets and Pipe Handles truncated on Win64

2012-11-14 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497222#comment-13497222 ] Ben Craig commented on THRIFT-1690: --- I think we are agreeing (at least on some parts).

[jira] [Commented] (THRIFT-1690) Sockets and Pipe Handles truncated on Win64

2012-11-14 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497482#comment-13497482 ] Ben Craig commented on THRIFT-1690: --- So what is the expectation of source compatibility

[jira] [Updated] (THRIFT-1753) Multiple C++ Windows, OSX, and iOS portability issues

2012-11-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1753: -- Attachment: cleaner_port.patch Multiple C++ Windows, OSX, and iOS portability issues

[jira] [Commented] (THRIFT-1690) Sockets and Pipe Handles truncated on Win64

2012-11-13 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496527#comment-13496527 ] Ben Craig commented on THRIFT-1690: --- The old code was a bit of a portability mess. The

[jira] [Commented] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2012-11-12 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495538#comment-13495538 ] Ben Craig commented on THRIFT-1750: --- MINGW still defines _WIN32, so that part seems to

[jira] [Updated] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2012-11-12 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1750: -- Attachment: (was: compiler_cleanup.patch) Make compiler build cleanly under visual studio 10

[jira] [Updated] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2012-11-12 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1750: -- Attachment: compiler_cleanup.patch Updated to fix MINGW / MSVC PATH_MAX confusion. Tested with mingw

[jira] [Created] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2012-11-09 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-1750: - Summary: Make compiler build cleanly under visual studio 10 Key: THRIFT-1750 URL: https://issues.apache.org/jira/browse/THRIFT-1750 Project: Thrift Issue Type:

[jira] [Updated] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2012-11-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1750: -- Attachment: compiler_cleanup.patch * No more MINGW flags, now testing for built-in _WIN32 and

[jira] [Created] (THRIFT-1751) definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined

2012-11-09 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-1751: - Summary: definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined Key: THRIFT-1751 URL: https://issues.apache.org/jira/browse/THRIFT-1751

[jira] [Updated] (THRIFT-1751) definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined

2012-11-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1751: -- Attachment: TServer_guard.patch Guarding increase_max_fds definition with HAVE_SYS_RESOURCE_H

[jira] [Commented] (THRIFT-1750) Make compiler build cleanly under visual studio 10

2012-11-09 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13494337#comment-13494337 ] Ben Craig commented on THRIFT-1750: --- I will look in to making these changes work with

[jira] [Created] (THRIFT-1740) Make C++ library build on OS X and iOS

2012-10-24 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-1740: - Summary: Make C++ library build on OS X and iOS Key: THRIFT-1740 URL: https://issues.apache.org/jira/browse/THRIFT-1740 Project: Thrift Issue Type: Improvement

[jira] [Updated] (THRIFT-1740) Make C++ library build on OS X and iOS

2012-10-24 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1740: -- Attachment: mac_and_ios.patch Make C++ library build on OS X and iOS

[jira] [Commented] (THRIFT-1740) Make C++ library build on OS X and iOS

2012-10-24 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483648#comment-13483648 ] Ben Craig commented on THRIFT-1740: --- The attached patch applies cleanly on 0.9 and the

[jira] [Commented] (THRIFT-1690) Sockets and Pipe Handles truncated on Win64

2012-10-05 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13470318#comment-13470318 ] Ben Craig commented on THRIFT-1690: --- One decent short term possibility is to change

[jira] [Updated] (THRIFT-1690) Sockets and Pipe Handles truncated on Win64

2012-10-05 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1690: -- Attachment: lib_socket_typedef.patch Fix for non-linux, non-windows builds of C++ library. Only

[jira] [Updated] (THRIFT-1695) allow warning-free compilation in VS 2012 and GNU 4.6

2012-10-05 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1695: -- Attachment: compiler_warning_purge.patch Merged all compiler related .patch files into one.

[jira] [Commented] (THRIFT-1695) allow warning-free compilation in VS 2012 and GNU 4.6

2012-10-05 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13470500#comment-13470500 ] Ben Craig commented on THRIFT-1695: --- Recreated patch. compiler_warning_purge.patch is

[jira] [Commented] (THRIFT-1690) Sockets and Pipe Handles truncated on Win64

2012-10-04 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469653#comment-13469653 ] Ben Craig commented on THRIFT-1690: --- Roger, I will be glad to better follow process in

[jira] [Updated] (THRIFT-1690) Sockets and Pipe Handles truncated on Win64

2012-09-19 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1690: -- Attachment: libthrift_warning_purge.patch libthrift_pipe_size.patch

[jira] [Updated] (THRIFT-1695) allow warning-free compilation in VS 2012 and GNU 4.6

2012-09-17 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1695: -- Attachment: platform_direct.patch libthrift_warning_purge.patch

[jira] [Created] (THRIFT-1690) Sockets and Pipe Handles truncated on Win64

2012-09-10 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-1690: - Summary: Sockets and Pipe Handles truncated on Win64 Key: THRIFT-1690 URL: https://issues.apache.org/jira/browse/THRIFT-1690 Project: Thrift Issue Type: Bug

[jira] [Created] (THRIFT-1692) SO_REUSEADDR allows for socket hijacking on Windows

2012-09-10 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-1692: - Summary: SO_REUSEADDR allows for socket hijacking on Windows Key: THRIFT-1692 URL: https://issues.apache.org/jira/browse/THRIFT-1692 Project: Thrift Issue Type:

[jira] [Created] (THRIFT-1686) t_php_generator.cc uses and instead of , and causes compiler errors with Visual Studio

2012-09-06 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-1686: - Summary: t_php_generator.cc uses and instead of , and causes compiler errors with Visual Studio Key: THRIFT-1686 URL: https://issues.apache.org/jira/browse/THRIFT-1686

[jira] [Updated] (THRIFT-1686) t_php_generator.cc uses and instead of , and causes compiler errors with Visual Studio

2012-09-06 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1686: -- Description: t_php_generator.cc uses and instead of , and causes compiler errors with Visual Studio

[jira] [Updated] (THRIFT-1686) t_php_generator.cc uses and instead of , and causes compiler errors with Visual Studio

2012-09-06 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig updated THRIFT-1686: -- Attachment: php_and_error.patch Patch for php compiler error t_php_generator.cc

[jira] [Created] (THRIFT-1687) Use Microsoft SafeInt (or reasonable alternative) to protect against integer arithmetic attacks

2012-09-06 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-1687: - Summary: Use Microsoft SafeInt (or reasonable alternative) to protect against integer arithmetic attacks Key: THRIFT-1687 URL: https://issues.apache.org/jira/browse/THRIFT-1687

<    1   2   3   4