janosvitok commented on issue #2100:
URL: https://github.com/apache/thrift/pull/2100#issuecomment-616715322
So what's the status of CMake support? I had an impression that CMake is
able to build the compiler and the c++ library at least (that's what I've used
to compile thrift compiler on
Jens-G commented on issue #2100:
URL: https://github.com/apache/thrift/pull/2100#issuecomment-616696754
They seem unmaintained because some people started the CMake switch but
never finished it. Hence we have two build systems to maintain and files that
ought to be automatically generated
Jens-G edited a comment on issue #2100:
URL: https://github.com/apache/thrift/pull/2100#issuecomment-616696754
They seem unmaintained because some people started the CMake switch but
never finished it. Hence we have two build systems to maintain and files that
ought to be automatically
Jens-G edited a comment on issue #2095:
URL: https://github.com/apache/thrift/pull/2095#issuecomment-616823649
Thanks! The remaining ones are probably unrelated problems but could you do
me the favour and force-push again to trigger CI?
Jens-G commented on issue #2095:
URL: https://github.com/apache/thrift/pull/2095#issuecomment-616823649
Thanbs! The remaining ones are probably unrelated problems but could you do
me the favour and force-push again to trigger CI?
franciscohanna92 commented on issue #1947:
URL: https://github.com/apache/thrift/pull/1947#issuecomment-616873555
Need this fix!
This is an automated message from the Apache Git Service.
To respond to the message, please log
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-617121345
Ready for review.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
emmenlau commented on issue #2105:
URL: https://github.com/apache/thrift/pull/2105#issuecomment-617121615
This may require a bit of review and discussion. Are the proposed changes
good?
This is an automated message from the
zeshuai007 commented on issue #2095:
URL: https://github.com/apache/thrift/pull/2095#issuecomment-617109330
@Jens-G , done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gaganso opened a new pull request #2104:
URL: https://github.com/apache/thrift/pull/2104
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does your
gaganso opened a new pull request #2103:
URL: https://github.com/apache/thrift/pull/2103
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does your
janosvitok commented on issue #2100:
URL: https://github.com/apache/thrift/pull/2100#issuecomment-616322575
These changes improve the project files, but do not fix it completely. There
are more files to be removed and some files to be added.
I'd suggest removing visual studio
janosvitok commented on issue #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-616325264
@kainjow I've created WIP PR #2048, but didn't have time to fill all the
tests out. Nevertheless, there are couple PR's in the queue that improve the
server situation in Swift (from
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616435582
I've found a small improvement where the Javascript target actually depends
on the target that copies the compiler into the source tree, not on the build
of the compiler. This ensures
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616505723
There seems to be an unrelated issue in
https://travis-ci.org/github/apache/thrift/jobs/677163097. Should I re-trigger
the builds and tests?
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616521068
Re-triggered build with a rebase on latest master, to fix random error in
Travis CI.
This is an automated message
emmenlau commented on issue #2102:
URL: https://github.com/apache/thrift/pull/2102#issuecomment-616523977
@dmaluka This is a nice changeset. To promote your change, maybe just
re-trigger the build so that hopefully tests work? With 1 out of 2 builds I'm
lucky and get all green lights :-)
emmenlau opened a new pull request #2105:
URL: https://github.com/apache/thrift/pull/2105
The constructors for THttpClient require specifying a `host`. However not
all supported socket types require a host. I.e. when using a Unix domain
socket, the host is required to be localhost.
dmaluka commented on issue #2102:
URL: https://github.com/apache/thrift/pull/2102#issuecomment-616585369
Re-triggered via force-pushing the same change again.
This is an automated message from the Apache Git Service.
To
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616584968
:-( Another random error in the CI. Can this be merged anyways?
This is an automated message from the Apache Git
emmenlau commented on pull request #2029:
URL: https://github.com/apache/thrift/pull/2029#issuecomment-619834916
This is fixed in latest master already. Closing.
This is an automated message from the Apache Git Service.
To
zeshuai007 commented on pull request #2117:
URL: https://github.com/apache/thrift/pull/2117#issuecomment-619790668
@dcelasun , I have modified it, and the CI has passed.
This is an automated message from the Apache Git
dcelasun commented on pull request #2033:
URL: https://github.com/apache/thrift/pull/2033#issuecomment-619780027
@prudhvid please rebase from master. There have been some CI fixes and I'd
like to see a green build before merging.
dcelasun commented on pull request #2117:
URL: https://github.com/apache/thrift/pull/2117#issuecomment-619798847
@zeshuai007 thanks, merged.
This is an automated message from the Apache Git Service.
To respond to the
dcelasun commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619813948
All right tests are green, I've managed to play around with it locally and
everything looks good.
One small thing: Since this is a breaking change for `TProcessor`,
emmenlau commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-619847306
The problem with the CI is not easily fixed for me. The issue comes from the
fact that the autotools build does not resolve the dependency between tests and
the Thrift library
ulidtko commented on pull request #2124:
URL: https://github.com/apache/thrift/pull/2124#issuecomment-620614059
Oh well, Travis fell down this time.
The only indication of whats wrong in the logs:
> make[4]: *** [all-local] Segmentation fault (core dumped)
That's kind of
Jens-G edited a comment on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-619382616
+1 LGTM but not tested.
Except of course that CI is all red.
Do we need to update documents (like *md) maybe?
Jens-G commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-619382616
+1 LGTM but not tested
This is an automated message from the Apache Git Service.
To respond to the message,
Jens-G edited a comment on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-619382616
+1 LGTM but not tested.
Except of course that CI is all red.
This is an automated message from the
ulidtko opened a new pull request #2124:
URL: https://github.com/apache/thrift/pull/2124
Hi!
Please see the [Jira issue][THRIFT-5186] for rationale. Basically, this
patch enables Thrift clients & servers to continue working in "offline mode" —
when only the loopback interace `lo`
cfriedt commented on pull request #2030:
URL: https://github.com/apache/thrift/pull/2030#issuecomment-620006879
Getting pushed back again, sorry.
This is an automated message from the Apache Git Service.
To respond to the
stale[bot] commented on pull request #2030:
URL: https://github.com/apache/thrift/pull/2030#issuecomment-620006900
This issue is no longer stale. Thank you for your contributions.
This is an automated message from the
dugenkui03 opened a new pull request #2125:
URL: https://github.com/apache/thrift/pull/2125
1. StringUtils haven't take `(offset + length)` > bytes.length';
2. `if ((offset | length | (offset + length) | (size - (offset + length))) <
0)` will faster than `>`
dcelasun commented on pull request #2079:
URL: https://github.com/apache/thrift/pull/2079#issuecomment-620053009
Indeed, thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log
penenin commented on pull request #2079:
URL: https://github.com/apache/thrift/pull/2079#issuecomment-620052366
It looks like Travis ran again successfully. Please let know if that is
sufficient for what you wanted.
This is
penenin edited a comment on pull request #2079:
URL: https://github.com/apache/thrift/pull/2079#issuecomment-620052366
It looks like Travis ran again successfully. Please let me know if that is
sufficient for what you wanted.
pacejackson commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-620115399
Updated :)
This is an automated message from the Apache Git Service.
To respond to the message, please log
dcelasun commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-620157935
Merged, thanks for the PR @pacejackson!
This is an automated message from the Apache Git Service.
To respond to
emmenlau commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618865274
Thanks @dcelasun, fixed now. Please review.
This is an automated message from the Apache Git Service.
To
emmenlau opened a new pull request #2115:
URL: https://github.com/apache/thrift/pull/2115
The Thrift implementations for NodeJS and Javascript seem to have come from
the same origins, and the code shares a strong resemblance. However it seems
the implementations have deviated over time.
kirviz commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-61897
Hi guys, I'm trying to find my way around here and eager for this PR.
I see the changes have been approved. Could anyone tell me what happens next?
emmenlau opened a new pull request #2114:
URL: https://github.com/apache/thrift/pull/2114
This is a minor PR that removes the (now deprecated) boost dependency from
the tests of Thrift compiler, and removes the (unused) script `bincat.sh`. I'm
curious if the CI finds any problems...
janosvitok commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-618947781
@kirviz: It is waiting for someone with commit rights to either merge this
or complain :) In the mean time, if you can try this at home :) and report the
results here (e.g.
alexanderedge commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-618948182
> @alexanderedge could you please rebase from master? The CI failures are
unrelated but there have been some fixes on master and I'd like to see if we
can get a green
fishy commented on pull request #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-618739157
@dcelasun Test added.
This is an automated message from the Apache Git Service.
To respond to the message, please
zeshuai007 opened a new pull request #2113:
URL: https://github.com/apache/thrift/pull/2113
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does
dcelasun commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618919413
Unfortunately this seems to have broken Travis:
> Rebuilding docker image ubuntu-xenial
> Sending build context to Docker daemon 11.26kB
> Error response from
emmenlau opened a new pull request #2116:
URL: https://github.com/apache/thrift/pull/2116
This PR adds wrapping to the TZlibTransportFactory. This is very helpful so
that servers can create their "normal" transport factory like before, then wrap
it into a TZlibTransportFactory.
zeshuai007 commented on pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#issuecomment-618908962
hi, @dcelasun
I have modified it locally and can resubmit this PR. can you reopen this PR?
This is an
emmenlau commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618924107
> Unfortunately this seems to have broken Travis:
>
> > Error response from daemon: Dockerfile parse error line 60: unknown
instruction: APT-ADD-REPOSITORY
> > The
dcelasun edited a comment on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618937017
I've restarted it and it failed again, because there really is a bug
:slightly_smiling_face: This:
```
echo "deb https://deb.nodesource.com/node_10.x xenial
dcelasun commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618937017
I've restarted it and it failed again, because there really is a bug
:slightly_smiling_face: This:
```
echo "deb https://deb.nodesource.com/node_10.x xenial main" |
dcelasun commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-618946513
@alexanderedge could you please rebase from master? The CI failures are
unrelated but there have been some fixes on master and I'd like to see if we
can get a green build
zeshuai007 opened a new pull request #2089:
URL: https://github.com/apache/thrift/pull/2089
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does
zeshuai007 opened a new pull request #2117:
URL: https://github.com/apache/thrift/pull/2117
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does
dcelasun commented on pull request #2106:
URL: https://github.com/apache/thrift/pull/2106#issuecomment-618835805
CI is all green, merged.
This is an automated message from the Apache Git Service.
To respond to the message,
dcelasun commented on pull request #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-618831826
Thanks! CI failures are unrelated so I'm merging this.
This is an automated message from the Apache Git
dcelasun commented on pull request #2113:
URL: https://github.com/apache/thrift/pull/2113#issuecomment-618832363
Tests are failing:
```
File "test/thrift_json.py", line 79
if __name__ == '__main__':
^
SyntaxError: invalid syntax
emmenlau commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618958494
Dammit, you are right! Thanks.
Slightly off-topic, I think the comments in the Dockerfile should really be
changed. I've had good experience with adding comments in
dcelasun edited a comment on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-618949715
> It is waiting for someone with commit rights to either merge this or
complain :)
I'm not familiar with Swift but others in this PR seem to be, so I'd be
happy
dcelasun commented on pull request #2115:
URL: https://github.com/apache/thrift/pull/2115#issuecomment-619019610
LGTM and all tests are green.
This is an automated message from the Apache Git Service.
To respond to the
dcelasun commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618984445
That's a great idea actually, please go ahead and change it.
This is an automated message from the Apache Git
dcelasun commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-619018047
Actually, the build is all green now, so I'm gonna go ahead and merge it.
Thanks everyone!
This is an
dcelasun commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-618949715
> It is waiting for someone with commit rights to either merge this or
complain :)
I'm not familiar with thrift but others in this PR seem to be, so I'd be
happy to
stale[bot] commented on pull request #2033:
URL: https://github.com/apache/thrift/pull/2033#issuecomment-619497064
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed in 7 days if no further activity occurs.
Thank you for your
zeshuai007 commented on pull request #2113:
URL: https://github.com/apache/thrift/pull/2113#issuecomment-619519390
@dcelasun ，done.
This is an automated message from the Apache Git Service.
To respond to the message, please
fishy commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619143377
@dcelasun :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dcelasun commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619146495
@fishy @pacejackson thanks for the PR, I've been looking forward to this!
I'll play around with this locally tomorrow and we'll take it from there.
emmenlau opened a new pull request #2118:
URL: https://github.com/apache/thrift/pull/2118
This PR adds cmake support for the C# netstd implementation. The major
changes are only in cmake and in the Visual Studio project files. The actual
build is executed via `dotnet` (which has to be
pacejackson opened a new pull request #2119:
URL: https://github.com/apache/thrift/pull/2119
Client: go
This PR adds a simple middleware framework for Go servers.
It provides:
1. A `ProcessorMiddleware` function interface used to define the actual
middleware
2.
stale[bot] commented on pull request #2033:
URL: https://github.com/apache/thrift/pull/2033#issuecomment-619528772
This issue is no longer stale. Thank you for your contributions.
This is an automated message from the
zeshuai007 commented on pull request #2033:
URL: https://github.com/apache/thrift/pull/2033#issuecomment-619528769
Hi @prudhvid, I don't found obvious errors in your code, but the CI failed
largely. Can you solve it before the bot close it?
Jens-G commented on pull request #2102:
URL: https://github.com/apache/thrift/pull/2102#issuecomment-619533475
Thanks @emmenlau for reviewing
This is an automated message from the Apache Git Service.
To respond to the
Jens-G commented on a change in pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#discussion_r415288133
##
File path: lib/py/test/thrift_transport.py
##
@@ -0,0 +1,51 @@
+import unittest
Review comment:
ASF header missing
stale[bot] commented on pull request #2035:
URL: https://github.com/apache/thrift/pull/2035#issuecomment-619585301
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed in 7 days if no further activity occurs.
Thank you for your
stale[bot] commented on pull request #2030:
URL: https://github.com/apache/thrift/pull/2030#issuecomment-619595612
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed in 7 days if no further activity occurs.
Thank you for your
emmenlau opened a new pull request #2109:
URL: https://github.com/apache/thrift/pull/2109
This change has mostly an impact on Windows. Currently Thrift does not
resolve error strings on Windows (for me). A typical error message may look
like `Could not bind: errno = 10049`. With C++11 the
fishy commented on issue #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-617877222
@dcelasun :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
fishy opened a new pull request #2110:
URL: https://github.com/apache/thrift/pull/2110
Client: go
Trying to read the next frame will likely cause the Read call blocking
indefinitely and eventually lead to timeout. See the JIRA ticket for
more context.
emmenlau opened a new pull request #2106:
URL: https://github.com/apache/thrift/pull/2106
This PR adds a new method isOpen() to the TServerTransport and
implementations TServerSocket and TPipeServer. I've added tests for
TServerSocket and tested on a number of platforms. The change is
Jens-G commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-617425716
@janosvitok comments from your side?
This is an automated message from the Apache Git Service.
To respond to the
stale[bot] commented on issue #2016:
URL: https://github.com/apache/thrift/pull/2016#issuecomment-618164495
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed in 7 days if no further activity occurs.
Thank you for your
emmenlau commented on issue #2105:
URL: https://github.com/apache/thrift/pull/2105#issuecomment-617603859
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
zeshuai007 opened a new pull request #2111:
URL: https://github.com/apache/thrift/pull/2111
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does
emmenlau opened a new pull request #2107:
URL: https://github.com/apache/thrift/pull/2107
This PR disables StressTestNonBlocking on Windows, not just in AppVeyor but
generally. This is required because the test is flaky.
- [x] See https://jira.apache.org/jira/browse/THRIFT-4282
-
stale[bot] commented on issue #2016:
URL: https://github.com/apache/thrift/pull/2016#issuecomment-618228349
This issue is no longer stale. Thank you for your contributions.
This is an automated message from the Apache
emmenlau commented on issue #2016:
URL: https://github.com/apache/thrift/pull/2016#issuecomment-618228324
Thanks bot! I'll get back to this issue, promise!
This is an automated message from the Apache Git Service.
To respond
emmenlau commented on issue #2107:
URL: https://github.com/apache/thrift/pull/2107#issuecomment-617769144
The single error in Travis CI is unrelated.
PR is ready for review...
This is an automated message from the
phile314 opened a new pull request #2108:
URL: https://github.com/apache/thrift/pull/2108
The read functions for handles promise to return *up* to the requested
number of bytes. This means in case we read less bytes, we should try again to
read some more bytes. This issue caused invalid
zeshuai007 commented on pull request #2111:
URL: https://github.com/apache/thrift/pull/2111#issuecomment-620322886
Hi @Jens-G , @dcelasun , can you help me review this PR?
This is an automated message from the Apache Git
zeshuai007 commented on pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#issuecomment-620313964
@Jens-G
I have fixed the conflict, and the CI has passed.
This is an automated message from the Apache
zeshuai007 edited a comment on pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#issuecomment-620313964
@Jens-G， @dcelasun ,
I have fixed the conflict, and the CI has passed.
This is an automated
fishy opened a new pull request #2128:
URL: https://github.com/apache/thrift/pull/2128
Client: go
Godoc requires at least one other exported type/function to render the
whole example file in the example, so export
simpleProcessorLoggingMiddleware to make the example of
emmenlau opened a new pull request #2127:
URL: https://github.com/apache/thrift/pull/2127
This PR adds support for domain sockets for Windows. During the
implementation I found a number of minor issues in TServerSocket and TSocket
that I believe are improved in this PR. None of these
penenin opened a new pull request #2121:
URL: https://github.com/apache/thrift/pull/2121
Add support for using WebSockets as a server transport to the C++ library.
- [X] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
penenin opened a new pull request #2120:
URL: https://github.com/apache/thrift/pull/2120
When establishing a WebSocket connection, Firefox sends Connection:
keep-alive, Upgrade instead of just Connection: Upgrade. Check to see if
Upgrade is in the header instead of checking to see if
dcelasun commented on a change in pull request #2121:
URL: https://github.com/apache/thrift/pull/2121#discussion_r414897662
##
File path: lib/cpp/Makefile.am
##
@@ -87,6 +87,7 @@ libthrift_la_SOURCES = src/thrift/TApplicationException.cpp \
dcelasun commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619266798
Tests are [failing](https://api.travis-ci.org/v3/job/679128191/log.txt).
```
gopath/src/tests/multiplexed_protocol_test.go:72:35: cannot use processor
(type
fishy commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619647145
Failing tests are fixed. The CI failure seems to be gradle related.
This is an automated message from the Apache
1 - 100 of 1389 matches
Mail list logo
