Call for reviews for recent Java generator changes

Hi dev@thrift, Recently I've created several proposals to change Java generator in thrift repo: 1. THRIFT-5521 https://github.com/apache/thrift/pull/2525 2. THRIFT-5520 https://github.com/apache/thrift/pull/2524 3. THRIFT-5524 https://github.com/apache/thrift/pull/2529 4. THRIFT-5522

RE: [jira] [Created] (THRIFT-5548) Kotlin code generator?

Hi dev@thrift, I'd like to propose to add this new language / code-gen but wonder if anyone has ever done similarly before (I did a search on Jira and dev mail list but no luck yet). Thanks! On 2022/04/06 01:39:00 "Jiayu Liu (Jira)" wrote: > Jiayu Liu create

Re: Dropping Java 8 support?

PM Jiayu Liu > wrote: > > 1. sub-project `libthrift`, which is the current Java library, to be > > configured with --release flag [2] to target Java 8 (class file > version, > > APIs) > > This is already what happens today, if the version detected is >= JDK > 9.

Re: Dropping Java 8 support?

gt; case, the > > rule applies. > > > > * https://www.oracle.com/java/technologies/java-se-support- > roadmap.html > > > > My 2 cents, > > > > Triton. > > > > Le jeu. 12 mai 2022 à 16:30, Yuxuan Wang > > > a > > écrit : > > &g

Dropping Java 8 support?

Hi dev@thrift, I've been working on the Java generator and library recently and have revamped the project a little bit, and for the most part, keeping all changes back compatible. Recently I've been thinking of introducing a breaking change: dropping the support of Java 8 and bumping the minimal

Re: Rust - attributes are not yet allowed on `if` expressions

I've long been wishing to upgrade the rust lib and gen code to latest version and have a pull request up at https://github.com/apache/thrift/pull/2623/files however i do need to fix some generator code that spills out clippy-failing code first... About the quick fix, i think dropping `--all` flag

Re: Rust - attributes are not yet allowed on `if` expressions

Sorry, wrong link. It should be https://github.com/apache/thrift/pull/2527 On June 24, 2022, jiayu liu wrote: > I've long been wishing to upgrade the rust lib and gen code to latest > version and have a pull request up at > https://github.com/apache/thrift/pull/2623/files however

Re: new committer: Liu Jiayu

Thank you Jens for the invite and help, I'm honored to become a committer and continue to contribute to the project! On June 25, 2022, Jens Geyer wrote: > The Project Management Committee (PMC) for Apache Thrift > has invited Liu Jiayu to become a committer and we are pleased > to announce that

Re: Java/Gradle issue - help appreciated

Hi JensG, I guess you can either upgrade your Java version to 11 or remove the whole line of "org.gradle.jvmargs=--add-exports" within "lib/java/gradle.properties" file. On June 23, 2022, Jens Geyer wrote: > Hi, > > I repeatedly run into an issue with one of my PRs. > Funny thing is, I did not

Re: date/time/timestamp, following ISO 8601

I still believe: using the convention used by Arrow, i.e., adding date32 and date64, where date32 for number of days past since UNIX epoch, and date64 for number of milliseconds past since UNIX epoch, can be useful without introducing ambiguity; for formatting using ISO 8601, users can still

Re: uuids - contributions welcome

I put up changes for Java (and Kotlin) here: https://github.com/apache/thrift/pull/2621 On June 9, 2022, Jens Geyer wrote: > Hi all, > > as you may have already noticed I created a uuid branch. Idea is to  > complete it on that branch until we have a green CI and then merge  > everything to

Re: To branch or not to branch - that is the question

i think the current CI is not broken due to bugs or regressions but rather just some unexpected tooling upgrades due to newer versions. i'm not seeing huge risk for branching. on the other hand, i've been wishing to fix it (in both rust lib and java lib) but haven't got enough time to get it done

Changes to CI and build process

Hi dev@thrift, I want to raise some attention on my recent updates/additions on the CI process and build process. Previously there has been some discussion on moving to CMake fully , but from the Jira ticket I can tell that the work is still in

Re: Java problems in the Travis builds

Yes I agree. I've located the issue, and the fix is at https://github.com/apache/thrift/pull/2686 (while upgrading to Java 17 which is the latest LTS version). On September 28, 2022, Mario Emmenlauer wrote: > On 28.09.22 09:22, Jiayu Liu wrote: > > update on this: I've tried to upgrade

Re: Java problems in the Travis builds

if we can just remove that specific task in the travis build. On September 16, 2022, jiayu liu wrote: > I'm trying to resolve the JDK bug by upgrading to Java 17 in bionic > build. The pull request is [1]. I also try to reduce excessive logging > in [2] > > [1]: https://github.com/apa

Re: Python "staleness" check failing

I did try out hash 72d5912 which wasn't long ago and it did work, and i don't think compiler code changed a lot since then. Must've been triggered by https://github.com/apache/thrift//commit/944b8e68a099392d80153ebcf26f32ff7f1d893a On September 12, 2022, Jens Geyer wrote: > Hi, > > I have a

Re: Python "staleness" check failing

i put out a fix at https://github.com/apache/thrift/pull/2661 which should be bringing the build back to normal. On September 13, 2022, jiayu liu wrote: > I did try out hash 72d5912 which wasn't long ago and it did work, and > i > don't think compiler code changed a lot since then. &g

Re: ocaml again

After https://github.com/apache/thrift/pull/2671 and https://github.com/apache/thrift/pull/2678 I'm able to get the build running again (not broken in the docker phase). If no one's blocking this I'll merge the 2678 PR later today to unblock the travis build. On September 23, 2022, Jens Geyer

Re: Dropping Java 8 support?

migrating to jdk11 > internally). > > On Fri, May 13, 2022 at 1:25 AM Christopher > wrote: > > > On Fri, May 13, 2022 at 1:20 AM Jiayu Liu > wrote: > > > > > > Regarding point 2 - the lib/kotlin has its own cross tests which > tests > > > kotlin

Re: Java problems in the Travis builds

I'm trying to resolve the JDK bug by upgrading to Java 17 in bionic build. The pull request is [1]. I also try to reduce excessive logging in [2] [1]: https://github.com/apache/thrift/pull/2662 [2]: https://github.com/apache/thrift/pull/2659 On September 11, 2022, yuxuan wang wrote: > So I

Context around TType in Java

Hi thrift-dev, I would like to know more about the context of TType in Java, specifically when ENUM was introduced in [1] in 2009, it is placed with value 16 (binary protocol) but in swift [2] it is utf8, in delphi [3] uuid, in C# [4] uuid, and per spec [5] uuid. Using 16 for uuid will possibly

Re: [jira] [Commented] (THRIFT-5640) rust library for thrift 0.17 not published

I'm testing it in Apache Arrow (https://github.com/apache/arrow- rs/pull/3104), hopefully we can see how it changes the generated code and client code downstream. Thanks for helping with the publishing. On November 13, 2022, "ASF GitHub Bot (Jira)" wrote: > [

Re: [jira] [Comment Edited] (THRIFT-5640) rust library for thrift 0.17 not published

Hi Allen, I might be able to help with publishing. On November 11, 2022, Allen George wrote: > I’m sorry - this is on me: I’ve been very short of time for the last > months. I can try grant release privileges to current active members > so that they can do crates releases (I certainly don’t want

Re: Does thrift need Java 11?

Hi Niels, Yes we moved on to Java 11 last year and configured the build to be targeting Java 11 minimal (using gradle release config, the building JDK is 17 but the target release is 11), you can find more info here:

Re: PRs and reviews actvity

I am looking for help in making https://github.com/apache/thrift/pull/2787 work, from experts of Python libraries. As a context, I am trying to migrate the current CI into GitHub actions by introducing per language CI steps. So far compiler itself, libraries including Java, Kotlin, rust, and

Re: Dropping Java 8 support?

2022 at 6:03 PM Jiayu Liu > wrote: > > > After 0.17 release i am proposing once again to upgrade to Java 11 > > minimal version. Any more feedback or concerns? > > > > On May 14, 2022, yuxuan wang wrote: > > > +1 for using jdk11 to build jdk8 compatible jar

Looking for help with CI cross tests

Hi, I've been trying to port CI into GitHub actions, and as you can see from one of the latest run: https://github.com/apache/thrift/actions/runs/4815594023 the cross-tests are failing, but I have managed to split it into separate buckets to better pin down errors. Now I am looking for help

Removing support for Python 2

Hi, I'd like to call for attention, that this PR https://github.com/apache/thrift/pull/2588 once merged will remove / drop the support for Python 2. Please share any concerns and/or help reviewing the PR. Thanks! -- Sent with HEY

Re: Kotlin failures in cross-test

fwiw i created https://github.com/apache/thrift/pull/2840 to fix this issue On August 9, 2023, yuxuan wang wrote: > When looking at cross-test logs from Github Actions, I noticed a lot > of > these errors: > > >8 > Error: A JNI error has occurred, please check your installation and >

[jira] [Created] (THRIFT-5521) In Java lib, add param for option_type to generate JDK8 optional types

Jiayu Liu created THRIFT-5521: - Summary: In Java lib, add param for option_type to generate JDK8 optional types Key: THRIFT-5521 URL: https://issues.apache.org/jira/browse/THRIFT-5521 Project: Thrift

[jira] [Created] (THRIFT-5522) Upgrade to gradle 6 for Java build

Jiayu Liu created THRIFT-5522: - Summary: Upgrade to gradle 6 for Java build Key: THRIFT-5522 URL: https://issues.apache.org/jira/browse/THRIFT-5522 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-5523) in rust lib, update to edition 2021 and use 1.58.1 toolchain

Jiayu Liu created THRIFT-5523: - Summary: in rust lib, update to edition 2021 and use 1.58.1 toolchain Key: THRIFT-5523 URL: https://issues.apache.org/jira/browse/THRIFT-5523 Project: Thrift

[jira] [Assigned] (THRIFT-5548) Kotlin code generator?

[ https://issues.apache.org/jira/browse/THRIFT-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiayu Liu reassigned THRIFT-5548: - Assignee: Jiayu Liu > Kotlin code generator? > -- > >

[jira] [Created] (THRIFT-5548) Kotlin code generator?

Jiayu Liu created THRIFT-5548: - Summary: Kotlin code generator? Key: THRIFT-5548 URL: https://issues.apache.org/jira/browse/THRIFT-5548 Project: Thrift Issue Type: New Feature