[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-09-11 Thread fumoboy007
Github user fumoboy007 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r78313579 --- Diff: lib/swift/Sources/LinuxHelper.swift --- @@ -0,0 +1,42 @@ +// +// LinuxHelper.swift +// Thrift +// +// Created

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-09-11 Thread fumoboy007
Github user fumoboy007 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r78312577 --- Diff: lib/swift/Sources/TStruct.swift --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-09-11 Thread fumoboy007
Github user fumoboy007 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r78312455 --- Diff: lib/swift/Sources/TApplicationError.swift --- @@ -0,0 +1,157 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-09-11 Thread fumoboy007
Github user fumoboy007 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r78312489 --- Diff: lib/swift/Sources/TList.swift --- @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-09-11 Thread fumoboy007
Github user fumoboy007 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r78312512 --- Diff: lib/swift/Sources/TMap.swift --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-09-11 Thread fumoboy007
Github user fumoboy007 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r78312532 --- Diff: lib/swift/Sources/TSet.swift --- @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-09-11 Thread fumoboy007
Github user fumoboy007 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r78312854 --- Diff: lib/swift/Sources/LinuxHelper.swift --- @@ -0,0 +1,42 @@ +// +// LinuxHelper.swift +// Thrift +// +// Created

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-09-16 Thread fumoboy007
Github user fumoboy007 commented on the issue: https://github.com/apache/thrift/pull/1084 ``` Compile Swift Module 'Thrift' (37 sources) /Users/…/Packages/Thrift-1.0.0/Sources/TSet.swift:22:70: warning: 'IndexableBase' is deprecated: it will be removed in Swift 4.0. Please

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-10-24 Thread fumoboy007
Github user fumoboy007 commented on the issue: https://github.com/apache/thrift/pull/1084 One major issue I encountered is the async support. There doesn’t seem to be an asynchronous `TProcessor`/`TProtocol`/`TClient` API in the base/generated code. Async support

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-10-24 Thread fumoboy007
Github user fumoboy007 commented on the issue: https://github.com/apache/thrift/pull/1084 Oh I didn’t know about the `async_clients` option… thanks! 😬 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-10-24 Thread fumoboy007
Github user fumoboy007 commented on the issue: https://github.com/apache/thrift/pull/1084 I don’t see a `[MyService]ProcessorAsync` in the generated code. How do I handle requests in an asynchronous manner? --- If your project is set up for it, you can reply to this email and have

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-11-12 Thread fumoboy007
Github user fumoboy007 commented on the issue: https://github.com/apache/thrift/pull/1084 Woah, nice! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2017-06-07 Thread fumoboy007
Github user fumoboy007 commented on the issue: https://github.com/apache/thrift/pull/1084 > SE-0162 [ https://github.com/apple/swift-evolution/blob/master/proposals/0162-package-manager-custom-target-layouts.md ] added API for controlling where the source files for each target sho

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2017-06-07 Thread fumoboy007
Github user fumoboy007 commented on the issue: https://github.com/apache/thrift/pull/1084 Yeah, it’s implemented in Swift 4. ![img_1999](https://user-images.githubusercontent.com/2100868/26892962-c6356fa6-4b6e-11e7-8394-1964d6ee.PNG) --- If your project is set up