[GitHub] thrift pull request: [THRIFT-1025] allow TSSLServerSocket and TSer...

2015-04-02 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/416 [THRIFT-1025] allow TSSLServerSocket and TServerSocket to optionally bin... ...d to a specific interface You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] thrift pull request: [THRIFT-1025] allow TSSLServerSocket and TSer...

2015-04-02 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/416 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: [THRIFT-1025] allow TSSLServerSocket and TSer...

2015-04-02 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/416#issuecomment-89040589 The build failed in an unexpected way (clang internal compiler error unrelated to the changes provided), so closing this pull request and opening another. --- If your

[GitHub] thrift pull request: [THRIFT-1025] allow TSSLServerSocket and TSer...

2015-04-02 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/417 [THRIFT-1025] allow TSSLServerSocket and TServerSocket to optionally bin... ...d to a specific interface You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] thrift pull request: [THRIFT-3069] fix socket leak if fcntl fails

2015-04-02 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/419 [THRIFT-3069] fix socket leak if fcntl fails You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3069-leak-socket

[GitHub] thrift pull request: [THRIFT-3066] fix assert that was assigning

2015-04-02 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/420 [THRIFT-3066] fix assert that was assigning You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3066-assert-that

[GitHub] thrift pull request: [THRIFT-3071] check minimum required version ...

2015-04-02 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/421 [THRIFT-3071] check minimum required version of automake in bootstrap.sh ~/thrift$ sh bootstrap.sh automake version 1.11.3 is too old (need 1.13 or later) You can merge this pull request into

[GitHub] thrift pull request: [THRIFT-3071] check minimum required version ...

2015-04-02 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/421 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: [THRIFT-3071] check minimum required version ...

2015-04-02 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/421#issuecomment-89116207 Going to fix some warnings at the same time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: [THRIFT-3071] check minimum required version ...

2015-04-02 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/421 [THRIFT-3071] check minimum required version of automake in bootstrap.sh ~/thrift$ sh bootstrap.sh automake version 1.11.3 is too old (need 1.13 or later) You can merge this pull request

[GitHub] thrift pull request: [THRIFT-3066] fix assert that was assigning

2015-04-03 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/420 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: [THRIFT-3061] eliminate potential for client ...

2015-04-03 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/423 [THRIFT-3061] eliminate potential for client to hang SSLSocket close You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix

[GitHub] thrift pull request: THRIFT-3080: fix connection leak of C++ Nonbl...

2015-04-03 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/422#discussion_r27765152 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1393,9 +1394,39 @@ bool TNonblockingIOThread::notify(TNonblockingServer::TConnection* conn

[GitHub] thrift pull request: THRIFT-3080: fix connection leak of C++ Nonbl...

2015-04-04 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/422#discussion_r27768849 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1393,9 +1394,39 @@ bool TNonblockingIOThread::notify(TNonblockingServer::TConnection* conn

[GitHub] thrift pull request: [THRIFT-1025] allow TSSLServerSocket and TSer...

2015-04-04 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/417#issuecomment-89645626 This was merged so I am closing the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: [THRIFT-1025] allow TSSLServerSocket and TSer...

2015-04-04 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/417 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: [THRIFT-2441] prevent client connections from...

2015-04-04 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/424 [THRIFT-2441] prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix

[GitHub] thrift pull request: [THRIFT-3062] fix segfault on invalid port nu...

2015-04-04 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/425 [THRIFT-3062] fix segfault on invalid port number You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3062-invalid

[GitHub] thrift pull request: [THRIFT-3077] TFileTransport fix ignored ftru...

2015-04-04 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/426 [THRIFT-3077] TFileTransport fix ignored ftruncate result You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3077

[GitHub] thrift pull request: Bugfix/thrift 3081 consolidate client process...

2015-04-06 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/428 Bugfix/thrift 3081 consolidate client processing loops The pull request consolidates the client processing loop contained within TSimpleServer, TThreadedServer, TThreadPoolServer that were all

[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...

2015-04-06 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/429 [THRIFT-3086] fix a few minor valgrind identified issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3086

[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...

2015-04-07 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/429#issuecomment-90742753 @bufferoverflow Thanks for the heads up, if that is in the process documentation for submitting requests I missed it. I'll remove the brackets in my pull req

[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...

2015-04-09 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/429 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-09 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/433 THRIFT-3081 consolidate client processing loops This pull request consolidates the client processing loops contained within TSimpleServer, TThreadedServer, TThreadPoolServer that were all similar

[GitHub] thrift pull request: [THRIFT-3077] TFileTransport fix ignored ftru...

2015-04-09 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/426 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-09 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/428#issuecomment-91361228 Build failed though no fault of my own, so closing this and opening a new one. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-09 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: [THRIFT-3077] TFileTransport fix ignored ftru...

2015-04-09 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/426#issuecomment-91281448 Closing as the code has been merged into the project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...

2015-04-09 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/429#issuecomment-91282080 The code has been merged so I am closing the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-09 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/428#issuecomment-91284246 There was no conflict with master however I need to base THRIFT-3083 on top of these changes so I needed to refresh it. --- If your project is set up for it, you can

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-11 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-11 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-91989278 As part of work on THRIFT-3084 I added a TServer integration test, and found that the shutdown behavior and the rules for when you can call setInterruptableChildren

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92031586 Added an integration test to prove behavior is correct; re-opening for CI build. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92032827 Closing and reopening because three builds failed with "build.ninja not found". Seems unrelated to changes made. --- If your project is set up for it, you ca

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92033000 Nevermind, it is my fault - fixing it.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92034746 Wow, this really isn't my morning... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/424#discussion_r28203871 --- Diff: lib/cpp/src/thrift/server/TSimpleServer.cpp --- @@ -88,7 +88,7 @@ void TSimpleServer::serve() { string errStr = string("Some ki

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-12 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/424#discussion_r28205714 --- Diff: lib/cpp/src/thrift/transport/TSocket.cpp --- @@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) { goto try_again

[GitHub] thrift pull request: THRIFT-3071 fix bootstrap.sh on MinGW

2015-04-13 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/438 THRIFT-3071 fix bootstrap.sh on MinGW Fixes an issue I introduced in bootstrap.sh that depended on "rev", an executable not normally available in MinGW or MSYS. You can merge this pu

[GitHub] thrift pull request: THRIFT-3071 fix bootstrap.sh on MinGW

2015-04-13 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/438 THRIFT-3071 fix bootstrap.sh on MinGW Fixes an issue I introduced in bootstrap.sh that depended on "rev", an executable not normally available in MinGW or MSYS. You can merge this pu

[GitHub] thrift pull request: THRIFT-3071 fix bootstrap.sh on MinGW

2015-04-13 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3071 fix bootstrap.sh on MinGW

2015-04-13 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/438#issuecomment-92401346 Build failed in an unrelated way so I closed and re-opened to kick a new build. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...

2015-04-13 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/439 THRIFT-3094 fix broken cmake build of C++ library with alternate threading You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-13 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/424#discussion_r28269576 --- Diff: lib/cpp/src/thrift/transport/TSocket.cpp --- @@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) { goto try_again

[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...

2015-04-13 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...

2015-04-13 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92498933 I guess this was merged through Hudson, as a result I am closing this. Sometimes they close automatically, and sometimes they do not, and I have no idea why... --- If

[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...

2015-04-13 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92506605 Are we using the github "merge pull request" mechanism that appears in each pull request here, or are we forced to use some other means to commit changes? -

[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...

2015-04-13 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92508143 Thanks - the manual steps in this process are less than ideal, and Apache should consider tighter integration to resolve. --- If your project is set up for it, you can

[GitHub] thrift pull request: [THRIFT-3088] TThreadPoolServer with Sasl aut...

2015-04-14 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/432#discussion_r28361223 --- Diff: lib/java/src/org/apache/thrift/server/TThreadPoolServer.java --- @@ -303,6 +303,10 @@ public void run() { if (outputTransport != null

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-14 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-93028344 Getting a windows build going has been really difficult, which is bizarre because it used to be easy. I've tried MinGW, and cygwin, and native with cmake. Each t

[GitHub] thrift pull request: THRIFT-3080: fix connection leak of C++ Nonbl...

2015-04-14 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/422#discussion_r28375162 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1393,9 +1397,42 @@ bool TNonblockingIOThread::notify(TNonblockingServer::TConnection* conn

[GitHub] thrift pull request: [THRIFT-3088] TThreadPoolServer with Sasl aut...

2015-04-14 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/432#discussion_r28375520 --- Diff: lib/java/src/org/apache/thrift/server/TThreadPoolServer.java --- @@ -303,6 +303,10 @@ public void run() { if (outputTransport != null

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-04-14 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/411#issuecomment-93084562 Given this was committed, you can close the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] thrift pull request: THRIFT-3080: fix connection leak of C++ Nonbl...

2015-04-16 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/422#discussion_r28515512 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1393,9 +1397,42 @@ bool TNonblockingIOThread::notify(TNonblockingServer::TConnection* conn

[GitHub] thrift pull request: THRIFT-3105 fix TNonBlockingServer build for ...

2015-04-17 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/453 THRIFT-3105 fix TNonBlockingServer build for libthriftnb library on windows You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-21 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/456 THRIFT-2850 cmake win cpp library and unit tests I made changes to the cmake environment so that cmake can build the compiler, static libraries and unit tests on Windows. In my testing I found

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-21 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/456#issuecomment-94859580 Darnit, a last minute change busted Windows - closing to fix. :| --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-21 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-21 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/456 THRIFT-2850 cmake win cpp library and unit tests I made changes to the cmake environment so that cmake can build the compiler, static libraries and unit tests on Windows. In my testing I found

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-22 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/456#issuecomment-95120411 csharp build failed and I believe it is unrelated, recycling pull request to rebuild --- If your project is set up for it, you can reply to this email and have your

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-22 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-22 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/456 THRIFT-2850 cmake win cpp library and unit tests I made changes to the cmake environment so that cmake can build the compiler, static libraries and unit tests on Windows. In my testing I found

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-22 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-95177941 To make the (hopefully) impending merge easier, I merged master into this branch and there was one conflict to resolve so I took care of it. --- If your project is set

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-22 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/456#issuecomment-95180226 Need help - all of the "make cross" csharp tests appear to be failing in Travis CI but I do not believe the changes I made would have impacted them at all

[GitHub] thrift pull request: THRIFT-3000 .NET implementation has trouble w...

2015-04-23 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/450#issuecomment-95650450 Did this complete a CI build? Someone suggested in analysis of my pull request to THRIFT-2850 that this changeset is the root cause. --- If your project is set up for

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-23 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/456#discussion_r29022096 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp --- @@ -576,12 +576,12 @@ int TSSLSocketFactory::passwordCallback(char* password, int size, int, void

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-24 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-95891841 I rebased with master after THRIFT-3000 was reverted to ensure that in Travis CI, job #1 passes. --- If your project is set up for it, you can reply to this email and

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-24 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/460 bugfix/THRIFT-3081 consolidate client processing loops in simple and threaded servers This provides consistency to client handling throughout the client lifecycle across all the simple and

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-24 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-95952386 Committed - closing pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/460#issuecomment-95956705 Yuck, bad merge. Something odd happened. Checking into it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/460#issuecomment-95959732 Actually the merge is correct; I don't know why github decided to make it difficult. The diffs are accurate. I did this work on top of THRIFT-2441 on my

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/460 bugfix/THRIFT-3081 consolidate client processing loops in simple and threaded servers This provides consistency to client handling throughout the client lifecycle across all the simple and

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/460#issuecomment-95976890 1249.8 failed in javascript - I did not touch javascript; recycling the pull request to kick a new build --- If your project is set up for it, you can reply to this

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/460 bugfix/THRIFT-3081 consolidate client processing loops in simple and threaded servers This provides consistency to client handling throughout the client lifecycle across all the simple and

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-24 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/456#discussion_r29076042 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp --- @@ -319,7 +319,7 @@ void TSSLSocket::checkHandshake() { return; } ssl_ = ctx_

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-26 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/460#issuecomment-96369617 closing this pull request because the history is too complex; I will submit another one that consolidates the changes and omits all the merges I used during development

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-26 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-26 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/464 THRIFT-3081 consolidate client processing loop in most TServers This pull request consolidates the client processing loop in the TSimpleServer, TThreadedServer, and TThreadPoolServer. This ensures

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-26 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-26 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/466 THRIFT-3083 consolidate simple and threaded server run loops Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them and

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-27 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/466 THRIFT-3083 consolidate simple and threaded server run loops Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-27 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/466#issuecomment-96895697 Failed strangely - recycling. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-27 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/466 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-28 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/466 THRIFT-3083 consolidate simple and threaded server run loops Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-28 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/466 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-28 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/466 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-28 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/466 THRIFT-3083 consolidate simple and threaded server run loops Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-28 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/466 THRIFT-3083 consolidate simple and threaded server run loops Currently the simple and threaded servers all share a very similar serve() workflow. This improvement story is to consolidate them

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-28 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/466 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3083 consolidate simple and threaded s...

2015-04-28 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/466 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   3   4   5   6   7   8   9   10   >