[jira] [Created] (THRIFT-3408) JSON generator emits incorrect types
Andrew Bloomgarden created THRIFT-3408: -- Summary: JSON generator emits incorrect types Key: THRIFT-3408 URL: https://issues.apache.org/jira/browse/THRIFT-3408 Project: Thrift Issue Type: Bug Components: JSON - Compiler Affects Versions: 0.9.3 Reporter: Andrew Bloomgarden Priority: Minor This change makes all base types emit "binary" as their type in the JSON generator: https://github.com/apache/thrift/commit/8dbe5f60a7c1401302e10aec41069f9c385d34a1#diff-e6c383fcc2ee5e64083db96846727639 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2574) Compiler option to generate namespace directories for Ruby
Andrew Bloomgarden created THRIFT-2574: -- Summary: Compiler option to generate namespace directories for Ruby Key: THRIFT-2574 URL: https://issues.apache.org/jira/browse/THRIFT-2574 Project: Thrift Issue Type: Improvement Components: Ruby - Compiler Affects Versions: 0.9.1 Reporter: Andrew Bloomgarden Fix For: 0.9.2 As described in THRIFT-1544, it would be nice if Thrift generated properly-namespaced files for Ruby. That patch would break backwards compatibility, so I don't know if you want it. This one makes namespacing correctly an option (namespaced). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (THRIFT-2574) Compiler option to generate namespace directories for Ruby
[ https://issues.apache.org/jira/browse/THRIFT-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Bloomgarden updated THRIFT-2574: --- Labels: compiler namespaces patch ruby (was: compiler namespaces patch) Compiler option to generate namespace directories for Ruby -- Key: THRIFT-2574 URL: https://issues.apache.org/jira/browse/THRIFT-2574 Project: Thrift Issue Type: Improvement Components: Ruby - Compiler Affects Versions: 0.9.1 Reporter: Andrew Bloomgarden Labels: compiler, namespaces, patch, ruby Fix For: 0.9.2 As described in THRIFT-1544, it would be nice if Thrift generated properly-namespaced files for Ruby. That patch would break backwards compatibility, so I don't know if you want it. This one makes namespacing correctly an option (namespaced). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (THRIFT-2574) Compiler option to generate namespace directories for Ruby
[ https://issues.apache.org/jira/browse/THRIFT-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Bloomgarden updated THRIFT-2574: --- Attachment: thrift-2574.diff thrift-2574-formatted-patch.patch Here's the patch with tests, formatted two different ways. Compiler option to generate namespace directories for Ruby -- Key: THRIFT-2574 URL: https://issues.apache.org/jira/browse/THRIFT-2574 Project: Thrift Issue Type: Improvement Components: Ruby - Compiler Affects Versions: 0.9.1 Reporter: Andrew Bloomgarden Labels: compiler, namespaces, patch, ruby Fix For: 0.9.2 Attachments: thrift-2574-formatted-patch.patch, thrift-2574.diff As described in THRIFT-1544, it would be nice if Thrift generated properly-namespaced files for Ruby. That patch would break backwards compatibility, so I don't know if you want it. This one makes namespacing correctly an option (namespaced). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831683#comment-13831683 ] Andrew Bloomgarden commented on THRIFT-2145: That would probably work, but I don't think it's necessary. I don't think it's asking too much of people who need a Thin-based server to require it themselves. Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831768#comment-13831768 ] Andrew Bloomgarden commented on THRIFT-2145: Thank you! Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Fix For: 0.9.2 Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794338#comment-13794338 ] Andrew Bloomgarden commented on THRIFT-2145: Note that MongrelHttpServer wasn't being required by thrift.rb, so you didn't need to install Mongrel to use thrift. Since the thin-based server is meant to replace the Mongrel-based one, it should act the same way. Anyways, this change broke backwards compatibility in a point release. Please fix it, and not by just adding thin as a runtime dependency. Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)