[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation
[ https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194764#comment-16194764 ] Gideon Korir commented on THRIFT-4350: -- [~jking] Can I help with anything related to the dotnetcore migration? I cloned your branch, ran the test + cross tests and they passed successfully. I'm in favor of not rolling back - even visual studio doesn't allow me to open the project without opening. > Update netcore build for dotnet 2.0 sdk and make cross validation > - > > Key: THRIFT-4350 > URL: https://issues.apache.org/jira/browse/THRIFT-4350 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Library >Affects Versions: 0.10.0 > Environment: docker ubuntu-xenial >Reporter: James E. King, III >Assignee: James E. King, III > > # Add dotnet core 2.0.0 official to the docker build image (xenial) > # Convert projects using "dotnet migrate" > # Ensure one can build on Windows inside Visual Studio 2017 using the project > that is checked in > # Ensure one can build on Linux using the project that is checked in and use > make check > # Set the target framework to netcoreapp2.0 - required for threading to work? > # Enable netcore in make cross > # Fix issues found: > ## netcore library never increases the sequence id number -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation
[ https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192513#comment-16192513 ] Gideon Korir commented on THRIFT-4350: -- I've sent in a PR that upgrades the project SDK to dotnet core 2.0. The project now targets netstandard 1.6 & 2.0. Build + tests were successful (although ruby autotools.sh is broken in Travis) and I created a sample at [thrift aspnet core sample|https://github.com/gideonkorir/thriftnetcoresample]. I didn't change the code for now but upgrading the SDK allows for further improvements e.g. merging it with the CSharp code base > Update netcore build for dotnet 2.0 sdk and make cross validation > - > > Key: THRIFT-4350 > URL: https://issues.apache.org/jira/browse/THRIFT-4350 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Library >Affects Versions: 0.10.0 > Environment: docker ubuntu-xenial >Reporter: James E. King, III >Assignee: James E. King, III > > # Add dotnet core 2.0.0 official to the docker build image (xenial) > # Convert projects using "dotnet migrate" > # Ensure one can build on Windows inside Visual Studio 2017 using the project > that is checked in > # Ensure one can build on Linux using the project that is checked in and use > make check > # Set the target framework to netcoreapp2.0 - required for threading to work? > # Enable netcore in make cross > # Fix issues found: > ## netcore library never increases the sequence id number -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (THRIFT-4347) running build-thrift error when running tests
[ https://issues.apache.org/jira/browse/THRIFT-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gideon Korir closed THRIFT-4347. Resolution: Fixed > running build-thrift error when running tests > - > > Key: THRIFT-4347 > URL: https://issues.apache.org/jira/browse/THRIFT-4347 > Project: Thrift > Issue Type: Bug > Components: Build Process, Test Suite >Affects Versions: 0.10.0 > Environment: - Following the instructions at > [github|https://github.com/apache/thrift/tree/master/build/wincpp] to build > Thrift on Windows 7. I'm a bit out of my league there but I followed all the > instructions using: > # Branch: master > # Visual Studio 2017 Community > # CMake 3.9.3 > # WinFlexBison - latest > # OpenSsl 1.1.0-rc > # Zlib 1.2.9 > # libevent 2.1.7-rc > # ActivePerl 5.24.2.2403 x64 > # Boost boost_1_62_0-msvc-14.0-32 > Environment Variables: > # ARCH = x86 > # COMPILER = vc150 > # GENERATOR = Visual Studio 15 2017 >Reporter: Gideon Korir > > build-thrift.bat /NOTEST => SUCCESSFUL BUILD > build-thrift.bat => ERROR > SO FAR I've Isolated the error to the post-build event for RUN_TESTS project. > There error message is: > Error MSB3073 The command "setlocal > "C:\Program Files\CMake\bin\ctest.exe" --force-new-ctest-process -C Debug > if %errorlevel% neq 0 goto :cmEnd > :cmEnd > endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone > :cmErrorLevel > exit /b %1 > :cmDone > if %errorlevel% neq 0 goto :VCEnd > :VCEnd" exited with code 8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4347) running build-thrift error when running tests
[ https://issues.apache.org/jira/browse/THRIFT-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180943#comment-16180943 ] Gideon Korir commented on THRIFT-4347: -- This occurs because Ctest doesn't have correct boost libraries to link against. Fixed by adding path to boost libraries to my PATH system variable. > running build-thrift error when running tests > - > > Key: THRIFT-4347 > URL: https://issues.apache.org/jira/browse/THRIFT-4347 > Project: Thrift > Issue Type: Bug > Components: Build Process, Test Suite >Affects Versions: 0.10.0 > Environment: - Following the instructions at > [github|https://github.com/apache/thrift/tree/master/build/wincpp] to build > Thrift on Windows 7. I'm a bit out of my league there but I followed all the > instructions using: > # Branch: master > # Visual Studio 2017 Community > # CMake 3.9.3 > # WinFlexBison - latest > # OpenSsl 1.1.0-rc > # Zlib 1.2.9 > # libevent 2.1.7-rc > # ActivePerl 5.24.2.2403 x64 > # Boost boost_1_62_0-msvc-14.0-32 > Environment Variables: > # ARCH = x86 > # COMPILER = vc150 > # GENERATOR = Visual Studio 15 2017 >Reporter: Gideon Korir > > build-thrift.bat /NOTEST => SUCCESSFUL BUILD > build-thrift.bat => ERROR > SO FAR I've Isolated the error to the post-build event for RUN_TESTS project. > There error message is: > Error MSB3073 The command "setlocal > "C:\Program Files\CMake\bin\ctest.exe" --force-new-ctest-process -C Debug > if %errorlevel% neq 0 goto :cmEnd > :cmEnd > endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone > :cmErrorLevel > exit /b %1 > :cmDone > if %errorlevel% neq 0 goto :VCEnd > :VCEnd" exited with code 8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (THRIFT-4347) running build-thrift error when running tests
Gideon Korir created THRIFT-4347: Summary: running build-thrift error when running tests Key: THRIFT-4347 URL: https://issues.apache.org/jira/browse/THRIFT-4347 Project: Thrift Issue Type: Bug Components: Build Process, Test Suite Affects Versions: 0.10.0 Environment: - Following the instructions at [github|https://github.com/apache/thrift/tree/master/build/wincpp] to build Thrift on Windows 7. I'm a bit out of my league there but I followed all the instructions using: # Branch: master # Visual Studio 2017 Community # CMake 3.9.3 # WinFlexBison - latest # OpenSsl 1.1.0-rc # Zlib 1.2.9 # libevent 2.1.7-rc # ActivePerl 5.24.2.2403 x64 # Boost boost_1_62_0-msvc-14.0-32 Environment Variables: # ARCH = x86 # COMPILER = vc150 # GENERATOR = Visual Studio 15 2017 Reporter: Gideon Korir build-thrift.bat /NOTEST => SUCCESSFUL BUILD build-thrift.bat => ERROR SO FAR I've Isolated the error to the post-build event for RUN_TESTS project. There error message is: Error MSB3073 The command "setlocal "C:\Program Files\CMake\bin\ctest.exe" --force-new-ctest-process -C Debug if %errorlevel% neq 0 goto :cmEnd :cmEnd endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone :cmErrorLevel exit /b %1 :cmDone if %errorlevel% neq 0 goto :VCEnd :VCEnd" exited with code 8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
