Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1497
@jeking3 There is already a Jira item:
https://issues.apache.org/jira/browse/THRIFT-4465
Btw, it makes sense that the fix resolves the framed transport failures.
Because the bug was about
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1497
@jeking3 I think all tests have passed.
---
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1497#discussion_r172754060
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -472,6 +472,18 @@ void TNonblockingServer::TConnection::workSocket
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1497#discussion_r172752961
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -472,6 +472,18 @@ void TNonblockingServer::TConnection::workSocket
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1497
@jeking3 The ``client_pool_tests`` failed in 2 of the bots within
Travis-CI. I don't think it is related to my change. Are these known to fail
every now
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
@jeking3 Here: https://github.com/apache/thrift/pull/1497
---
GitHub user bgedik opened a pull request:
https://github.com/apache/thrift/pull/1497
Remove workSocket call that is too early
Make the work socket conditional
Revert back the changes
Only call workSocket() when there is pending data to read
Minor update to a comment
GitHub user bgedik reopened a pull request:
https://github.com/apache/thrift/pull/1476
Remove premature call to workSocket() in TNonblockingServer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bgedik/thrift
bugfix/non
Github user bgedik closed the pull request at:
https://github.com/apache/thrift/pull/1476
---
Github user bgedik closed the pull request at:
https://github.com/apache/thrift/pull/1476
---
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
@jeking3 anything I can do to get this into a mergable state?
---
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163681677
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163679874
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
@@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() {
close();
}
+bool TSSLSocket
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163673632
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
@@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() {
close();
}
+bool TSSLSocket
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
Ok, reverted back.
---
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163651048
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163640014
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163420333
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
@jeking3 This is ready for review now.
---
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
@jeking3 My latest fix worked fine, but failed to compile on windows. I'll
rework to something that works for all platforms.
---
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
The following tests FAILED:
16 - concurrency_test (Timeout)
20 - TNonblockingSSLServerTest (Timeout)
I think the failure in {{TNonblockingSSLServerTest}} could be related
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r102025490
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1566,24 +1562,26 @@ void
TNonblockingIOThread::setCurrentThreadHighPriority(bool value
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r102023002
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1566,24 +1562,26 @@ void
TNonblockingIOThread::setCurrentThreadHighPriority(bool value
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1080#discussion_r97798270
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1080#discussion_r97712383
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error
25 matches
Mail list logo
