[jira] [Created] (THRIFT-4557) use RWLock instead of Lock

2018-04-17 Thread gansteed (JIRA)
gansteed created THRIFT-4557: Summary: use RWLock instead of Lock Key: THRIFT-4557 URL: https://issues.apache.org/jira/browse/THRIFT-4557 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-16 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439025#comment-16439025 ] gansteed commented on THRIFT-4552: -- hello, the PR failed because of C++ tests: https://travis-ci.org

[jira] [Commented] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-13 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437123#comment-16437123 ] gansteed commented on THRIFT-4552: -- That's what I mean in last comment, just like you demo. in https

[jira] [Commented] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-13 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436885#comment-16436885 ] gansteed commented on THRIFT-4553: -- okay, thank you! I'll close this issue then. > are there any pl

[jira] [Closed] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-13 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gansteed closed THRIFT-4553. Resolution: Fixed > are there any plans for add middle-ware support for thrift Go implementat

[jira] [Commented] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-12 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436867#comment-16436867 ] gansteed commented on THRIFT-4552: -- hello, thanks for your reply, I don't fully understand the issue

[jira] [Commented] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-12 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436862#comment-16436862 ] gansteed commented on THRIFT-4553: -- wow, yes, you're right. but by doing this, my code knows too much

[jira] [Commented] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-12 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436674#comment-16436674 ] gansteed commented on THRIFT-4553: -- [~calcifer] hello, I want to do it in BinaryProtocol, too, do you

[jira] [Created] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-11 Thread gansteed (JIRA)
gansteed created THRIFT-4553: Summary: are there any plans for add middle-ware support for thrift Go implementation? Key: THRIFT-4553 URL: https://issues.apache.org/jira/browse/THRIFT-4553 Project

[jira] [Created] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-11 Thread gansteed (JIRA)
gansteed created THRIFT-4552: Summary: why acquire a lock in TSimpleServer implementation for Go? Key: THRIFT-4552 URL: https://issues.apache.org/jira/browse/THRIFT-4552 Project: Thrift Issue

why acquire a lock in TSimpleServer implementation for Go?

2018-04-11 Thread gansteed
hi, all: I'm using Thrift and I'm reading thrift implementation for Go, I found code in `TSimpleServer.AcceptLoop` like this: ```go func (p *TSimpleServer) AcceptLoop() error { for { client, err := p.serverTransport.Accept() p.mu.Lock()