[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-04-15 Thread huerlisi
Github user huerlisi closed the pull request at: https://github.com/apache/thrift/pull/411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-04-15 Thread huerlisi
Github user huerlisi commented on the pull request: https://github.com/apache/thrift/pull/411#issuecomment-93250554 Thanks for the heads up:-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request: Add compiler/cpp/lex.yythriftl.cc to gitignor...

2015-03-30 Thread huerlisi
GitHub user huerlisi opened a pull request: https://github.com/apache/thrift/pull/412 Add compiler/cpp/lex.yythriftl.cc to gitignore. I've accidentially checked that file in in another PR. So this commit adds that file to the .gitignore. Might be that this is only

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-03-30 Thread huerlisi
GitHub user huerlisi opened a pull request: https://github.com/apache/thrift/pull/411 Fixes nodejs readme syntax The README for nodejs examples had strange syntax letting Markdown thinking everything is a header. You can merge this pull request into a Git repository by running

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-03-30 Thread huerlisi
Github user huerlisi commented on the pull request: https://github.com/apache/thrift/pull/411#issuecomment-87633148 Fixed, ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-03-30 Thread huerlisi
Github user huerlisi commented on the pull request: https://github.com/apache/thrift/pull/411#issuecomment-87639738 The failing test (Haskel: https://travis-ci.org/apache/thrift/jobs/56395742) seems to be unrelated to my changes. --- If your project is set up for it, you can reply

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-03-30 Thread huerlisi
Github user huerlisi commented on the pull request: https://github.com/apache/thrift/pull/411#issuecomment-87632748 Sorry, accidentally checked in a generated file, will fix and amend the last commit. --- If your project is set up for it, you can reply to this email and have your