[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650142#comment-16650142 ] ASF GitHub Bot commented on THRIFT-4551: jeking3 commented on issue #1548: THRIFT-4551: Run 'yarn prettier' to consistently format JS files URL: https://github.com/apache/thrift/pull/1548#issuecomment-429835004 @NameFILIP will you be able to resolve these issues? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add prettier for consistent JS code formatting > -- > > Key: THRIFT-4551 > URL: https://issues.apache.org/jira/browse/THRIFT-4551 > Project: Thrift > Issue Type: Improvement >Reporter: Filip Spiridonov >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > [Prettier|https://prettier.io/] is awesome. See > [why|https://prettier.io/docs/en/why-prettier.html] you should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614703#comment-16614703 ] ASF GitHub Bot commented on THRIFT-4551: jeking3 commented on issue #1548: THRIFT-4551: Run 'yarn prettier' to consistently format JS files URL: https://github.com/apache/thrift/pull/1548#issuecomment-421337471 @NameFILIP will you be able to resolve these issues? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add prettier for consistent JS code formatting > -- > > Key: THRIFT-4551 > URL: https://issues.apache.org/jira/browse/THRIFT-4551 > Project: Thrift > Issue Type: Improvement >Reporter: Filip Spiridonov >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > [Prettier|https://prettier.io/] is awesome. See > [why|https://prettier.io/docs/en/why-prettier.html] you should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562115#comment-16562115 ] ASF GitHub Bot commented on THRIFT-4551: jeking3 commented on issue #1548: THRIFT-4551: Run 'yarn prettier' to consistently format JS files URL: https://github.com/apache/thrift/pull/1548#issuecomment-408928923 Cannot merge it as it breaks the build. Will you be doing more work on this (eslint)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add prettier for consistent JS code formatting > -- > > Key: THRIFT-4551 > URL: https://issues.apache.org/jira/browse/THRIFT-4551 > Project: Thrift > Issue Type: Improvement >Reporter: Filip Spiridonov >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > [Prettier|https://prettier.io/] is awesome. See > [why|https://prettier.io/docs/en/why-prettier.html] you should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525478#comment-16525478 ] ASF GitHub Bot commented on THRIFT-4551: NameFILIP commented on issue #1548: THRIFT-4551: Run 'yarn prettier' to consistently format JS files URL: https://github.com/apache/thrift/pull/1548#issuecomment-400796255 yes, it conflicts with jslint rules.. which is not very flexible. Ideally, the project should be changed to use eslint which is much more powerful and is the industry standard and it should be good then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add prettier for consistent JS code formatting > -- > > Key: THRIFT-4551 > URL: https://issues.apache.org/jira/browse/THRIFT-4551 > Project: Thrift > Issue Type: Improvement >Reporter: Filip Spiridonov >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > [Prettier|https://prettier.io/] is awesome. See > [why|https://prettier.io/docs/en/why-prettier.html] you should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525473#comment-16525473 ] ASF GitHub Bot commented on THRIFT-4551: jeking3 commented on issue #1548: THRIFT-4551: Run 'yarn prettier' to consistently format JS files URL: https://github.com/apache/thrift/pull/1548#issuecomment-400795401 Looks like there are still issues: ``` [jsl:jslint] /thrift/src/lib/js/src/thrift.js:322:5: Bad line breaking before '?'. [jsl:jslint] ? options.customHeaders [jsl:jslint] ^ [jsl:jslint] /thrift/src/lib/js/src/thrift.js:323:7: Bad line breaking before '?'. [jsl:jslint] ? options.customHeaders [jsl:jslint] ^ [jsl:jslint] /thrift/src/lib/js/src/thrift.js:384:9: Move the invocation into the parens that contain the function. [jsl:jslint] })(); [jsl:jslint] ^ [jsl:jslint] /thrift/src/lib/js/src/thrift.js:392:9: Move the invocation into the parens that contain the function. [jsl:jslint] })(); [jsl:jslint] ^ [jsl:jslint] /thrift/src/lib/js/src/thrift.js:603:11: Move the invocation into the parens that contain the function. [jsl:jslint] })() [jsl:jslint] ^ [jsl:jslint] /thrift/src/lib/js/src/thrift.js:628:13: Move the invocation into the parens that contain the function. [jsl:jslint] })() [jsl:jslint] ^ ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add prettier for consistent JS code formatting > -- > > Key: THRIFT-4551 > URL: https://issues.apache.org/jira/browse/THRIFT-4551 > Project: Thrift > Issue Type: Improvement >Reporter: Filip Spiridonov >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > [Prettier|https://prettier.io/] is awesome. See > [why|https://prettier.io/docs/en/why-prettier.html] you should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525087#comment-16525087 ] ASF GitHub Bot commented on THRIFT-4551: jeking3 commented on issue #1548: THRIFT-4551: Run 'yarn prettier' to consistently format JS files URL: https://github.com/apache/thrift/pull/1548#issuecomment-400669588 I rebased on master to get a clean build. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add prettier for consistent JS code formatting > -- > > Key: THRIFT-4551 > URL: https://issues.apache.org/jira/browse/THRIFT-4551 > Project: Thrift > Issue Type: Improvement >Reporter: Filip Spiridonov >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > [Prettier|https://prettier.io/] is awesome. See > [why|https://prettier.io/docs/en/why-prettier.html] you should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468237#comment-16468237 ] ASF GitHub Bot commented on THRIFT-4551: jeking3 commented on issue #1548: THRIFT-4551: Run 'yarn prettier' to consistently format JS files URL: https://github.com/apache/thrift/pull/1548#issuecomment-387601416 @NameFILIP these changes broke the build. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add prettier for consistent JS code formatting > -- > > Key: THRIFT-4551 > URL: https://issues.apache.org/jira/browse/THRIFT-4551 > Project: Thrift > Issue Type: Improvement >Reporter: Filip Spiridonov >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > [Prettier|https://prettier.io/] is awesome. See > [why|https://prettier.io/docs/en/why-prettier.html] you should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443085#comment-16443085 ] ASF GitHub Bot commented on THRIFT-4551: NameFILIP opened a new pull request #1548: THRIFT-4551: Run 'yarn prettier' to consistently format JS files URL: https://github.com/apache/thrift/pull/1548 It's possible to add configuration using `prettier.config.js` to format the code in a specific way, but first see these: [Prettier issue](https://github.com/prettier/prettier/issues/40) [Dan Abramov talk (at 15:40)](https://youtu.be/G39lKaONAlA?t=939) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add prettier for consistent JS code formatting > -- > > Key: THRIFT-4551 > URL: https://issues.apache.org/jira/browse/THRIFT-4551 > Project: Thrift > Issue Type: Improvement >Reporter: Filip Spiridonov >Assignee: James E. King, III >Priority: Minor > Fix For: 0.12.0 > > > [Prettier|https://prettier.io/] is awesome. See > [why|https://prettier.io/docs/en/why-prettier.html] you should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434241#comment-16434241 ] James E. King, III commented on THRIFT-4551: Thanks for opening a ticket and the PRs. > Add prettier for consistent JS code formatting > -- > > Key: THRIFT-4551 > URL: https://issues.apache.org/jira/browse/THRIFT-4551 > Project: Thrift > Issue Type: Improvement >Reporter: Filip Spiridonov >Priority: Minor > > [Prettier|https://prettier.io/] is awesome. See > [why|https://prettier.io/docs/en/why-prettier.html] you should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
