[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 In general I want to make sure all clients send a seqid and all servers put that seqid in the result. Without this we won't be able to have clients that can have multiple outstanding requests in the future. ---
[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...
Github user bananer commented on the issue: https://github.com/apache/thrift/pull/1058 @jeking3 To be honest, I don't know why this is useful/necessary. I think there is no need for a seqid because the connection between request and response is handled through callbacks automatically. ---
[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 @bananer is this worth pulling forward if it passes a build? ---
[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 This change needs a Jira ticket; please see https://thrift.apache.org/docs/HowToContribute. Also if you can rebase on master and push that will kick a new CI build; CI needs to pass (or failures easily explained) to merge. ---
[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 This change needs a Jira ticket; please see https://thrift.apache.org/docs/HowToContribute. Also if you can rebase on master and push that will kick a new CI build; CI needs to pass (or failures easily explained) to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
