Github user yurikoles commented on the issue:
https://github.com/apache/thrift/pull/1084
Hi @apocolipse,
Please consider taking into account usage of reserved keywords in *.thrift
files. For example back end developers may use field with name `description` in
their structures.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1084
Okay, so I could merge this, but I need to know (since I've never used
cocoa, swift, or any of the apple stuff really):
* Are there breaking changes?
* Are they documented?
* Is it
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@JacopoMangiavacchi Server side already works using something like Perfect
or Zewo, I already have separate server adapters for them
https://github.com/apocolipse/TPerfectHTTPServer
Github user JacopoMangiavacchi commented on the issue:
https://github.com/apache/thrift/pull/1084
I tested this PR and I see it already support also Swift 4.0 and I'm adding
Swift-Nio support for easily implement also the server side.
Any update on this merge ? Thanks a lot
Github user jorgeazevedo commented on the issue:
https://github.com/apache/thrift/pull/1084
Any movement on this? I'd love to see this merged.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1084
I would recommend the original commenters chime in as the requested work
was done; this should be SQUASHED (nobody wants to cherry-pick 84 commits) and
rebased on master and if it passes CI clean,
Github user tbartelmess commented on the issue:
https://github.com/apache/thrift/pull/1084
Any movement on this? I'd love to see this merged.
---
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@nsuke hah good catch, bad habits from other languages ;) Fixed
---
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@nsuke requested cleanup completed
---
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1084
This replaces current Swift2 generator/lib with new one which supports
Swift3. The current one is still kept as option `swift:cocoa`, though.
Swift 2 has been not usable with latest XCode for
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1084
What needs to happen next to move this forward?
---
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
Also, to anyone using this, I'm making a pretty decent sized change right
now to how `TEnums` work with Swift Enums. Backstory is that Swift enums are
overly opinionated and don't work well if
Github user fumoboy007 commented on the issue:
https://github.com/apache/thrift/pull/1084
Yeah, itâs implemented in Swift 4.
---
If your project is set up for
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
Its just a proposal so far, i don't think it'll be implemented for Swift 3
(but i havent been keeping close track, correct me if i'm wrong) It'll make
more sense to do once Swift4 drops and SPM
Github user fumoboy007 commented on the issue:
https://github.com/apache/thrift/pull/1084
> SE-0162 [
https://github.com/apple/swift-evolution/blob/master/proposals/0162-package-manager-custom-target-layouts.md
] added API for controlling where the source files for each target should
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@gotev feel free to contribute anything that was mentioned there. Its
otherwise code complete (and likely better supported than the already merged
Swift2 and Cocoa/Obj-C generators), I will
Github user gotev commented on the issue:
https://github.com/apache/thrift/pull/1084
@jeking3 @apocolipse What it's left to be done for this pull request to be
merged? I can provide some help. Is
[this](https://github.com/apache/thrift/pull/1084#issuecomment-289279668)
everything
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1084
None that I know of. What you can do is:
1. Make sure language support is in the Dockerfile for the ubuntu and
debian builds.
2. Look for CROSS_LANGS in the top level Makefile.am.
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@jeking3 no, any docs on whats needed for that? I can add it in. The old
Cocoa+Swift generator was lacking here as well. (As is the Obj-C Cocoa
generator)
---
If your project is set up for
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1084
Are these changes integrated into the "make cross" cross-language
validation suite?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
Update 2/28/2017:
Old Swift generator and new merged into one,
Old generator under `cocoa` option, `promise_kit` option only available for
old generator as well.
I don't have any
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@nsuke I've removed the attribution, will keep it in my personal Lib repo
thats used strictly for SPM integration. Fixed the error codes you mentioned
above.
I'll go ahead and merge
Github user fumoboy007 commented on the issue:
https://github.com/apache/thrift/pull/1084
Woah, nice!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
Update:
I've modified the generated Async clients to use a new `TAsyncResult`
parameter for callbacks rather than Optional Return/Error tuples. Short
version of why is that those
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
I've created 2 separate HTTP Servers using external libraries and made them
available to play with
https://github.com/apocolipse/TZewoHTTPServer and
Github user ChristopherRogers commented on the issue:
https://github.com/apache/thrift/pull/1084
I have not. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@fumoboy007 so for clients you should be doing something like this:
```swift
let factory = THTTPSessionTransport.Factory(url: serviceURL)
let client = HermesAsyncClient(with:
Github user fumoboy007 commented on the issue:
https://github.com/apache/thrift/pull/1084
I donât see a `[MyService]ProcessorAsync` in the generated code. How do I
handle requests in an asynchronous manner?
---
If your project is set up for it, you can reply to this email and have
Github user fumoboy007 commented on the issue:
https://github.com/apache/thrift/pull/1084
Oh I didnât know about the `async_clients` option⦠thanks! ð¬
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@fumoboy007 There is `TAsyncClient` in TClient.swift as well as
`TAsyncTransport/Factory` in TTransport.swift, and the generator will generate
async clients properly (`--gen
Github user fumoboy007 commented on the issue:
https://github.com/apache/thrift/pull/1084
One major issue I encountered is the async support. There doesnât seem to
be an asynchronous `TProcessor`/`TProtocol`/`TClient` API in the base/generated
code.
Async support is
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@fumoboy007 @ChristopherRogers Have you all found any other outstanding
issues that need addressing?
@nsuke @kdubb What final steps do we need to do to get this into the
official
Github user fumoboy007 commented on the issue:
https://github.com/apache/thrift/pull/1084
```
Compile Swift Module 'Thrift' (37 sources)
/Users/â¦/Packages/Thrift-1.0.0/Sources/TSet.swift:22:70: warning:
'IndexableBase' is deprecated: it will be removed in Swift 4.0. Please
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@ChristopherRogers @fumoboy007 I implemented union support with enums,
here's an example of generated code:
```
union TestUnion {
1: i32 data,
2: string message,
3: bool
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@nsuke I considered that when starting out, however the differences between
Swift 2 and 3 are pretty dramatic that makes shared code minimal (i.e.
everything in this library is Value typed,
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1084
There's a substantial amount of code duplication with existing swift
generator.
Do you have any idea as to reducing them ?
As I've never seen anyone advocating the current practice of "single
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
That'll require generation of both read and write serialization code (which
I try to abstract much of to the library), but its doable I suppose.
---
If your project is set up for it, you can
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@ChristopherRogers Something like this?
```
union AUnion {
1: string result,
2: CustomException error
}
```
```swift
enum AUnion {
case result(val:
Github user ChristopherRogers commented on the issue:
https://github.com/apache/thrift/pull/1084
I noticed you haven't special cased unions (they'll just be generated as
structs.) Have you looked into adding support for this? I'd love to be able to
use Swift's enums with Thrift's
Github user apocolipse commented on the issue:
https://github.com/apache/thrift/pull/1084
@fumoboy007 thanks, thought i had the overflow ones in there, will add them
back in :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
40 matches
Mail list logo
