[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user NameFILIP commented on the issue: https://github.com/apache/thrift/pull/1086 Looks like a critical error was introduced in this PR. Here is the fix for it: https://github.com/apache/thrift/pull/1531 ---

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1086 Looks good to me. I guess there is no TTransportException for the js runtime? I'd like one other person more familiar with using the language to approve then we can merge it in, like

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user lifei commented on the issue: https://github.com/apache/thrift/pull/1086 @jeking3 modified --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1086 As-is the patch would require string parsing to get the statusCode which is brittle. I like the overall direction of handling unexpected status code with an exception; consider using a derived

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user lifei commented on the issue: https://github.com/apache/thrift/pull/1086 > I think that putting the statusCode into the text description would be useful here added --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1086 status code not equal 200 doesn't means it's a `TApplicationException`. * When status code is 301/3xx, should thrift client follow the redirect? * In some server implements, server

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user lifei commented on the issue: https://github.com/apache/thrift/pull/1086 https://issues.apache.org/jira/browse/THRIFT-3926 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1086 ping @RandyAbernethy for thoughts on this patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this