Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
@jeking3 Here: https://github.com/apache/thrift/pull/1497
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1476
Squash to one commit, please.
---
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
@jeking3 anything I can do to get this into a mergable state?
---
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
Ok, reverted back.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1476
I see now, I may have led you down the wrong path with my comments. So
peek() blocks waiting for data the be available to read and the end result of
peek is that there is data to read OR the
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
@jeking3 This is ready for review now.
---
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
@jeking3 My latest fix worked fine, but failed to compile on windows. I'll
rework to something that works for all platforms.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1476
Yes, concurrency_test has sporadic failures - it is a lot better than it
used to be; seems to be worse on Visual Studio 10. Perhaps the solution here
is to handle EAGAIN properly?
---
Github user bgedik commented on the issue:
https://github.com/apache/thrift/pull/1476
The following tests FAILED:
16 - concurrency_test (Timeout)
20 - TNonblockingSSLServerTest (Timeout)
I think the failure in {{TNonblockingSSLServerTest}} could be related.
