[GitHub] thrift issue #1480: [nodejs] Fix issue with connection failures silently fai...

2018-03-16 Thread dorilla
Github user dorilla commented on the issue: https://github.com/apache/thrift/pull/1480 Apologies, I haven't had the time to update this ticket. I fully intend to, just trying to find the time. ---

[GitHub] thrift issue #1480: [nodejs] Fix issue with connection failures silently fai...

2018-03-15 Thread bananer
Github user bananer commented on the issue: https://github.com/apache/thrift/pull/1480 @jeking3 This looks reasonable. Should have tests, though. ---

[GitHub] thrift issue #1480: [nodejs] Fix issue with connection failures silently fai...

2018-03-13 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1480 @bananer apart from missing any testing, is this a reasonable enhancement? ---

[GitHub] thrift issue #1480: [nodejs] Fix issue with connection failures silently fai...

2018-03-09 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1480 This needs to be retargeted at the master branch and it needs an Apache Jira thrift ticket. See https://thrift.apache.org/docs/HowToContribute ---