[GitHub] thrift issue #1507: THRIFT-4516: Fix "go vet" warnings for Go 1.10

2018-03-15 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1507 Go ahead and merge. After you merge, I update my fork and kick a build on my account to refresh the images. It's an optimization that saves ~10 minutes per build job. ---

[GitHub] thrift issue #1507: THRIFT-4516: Fix "go vet" warnings for Go 1.10

2018-03-15 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1507 Failures seem unrelated. Should I merge or do you need to something on docker.io? ---

[GitHub] thrift issue #1507: THRIFT-4516: Fix "go vet" warnings for Go 1.10

2018-03-15 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1507 I'll keep an eye on this. Right now the docker images on docker.io have to be generated manually every time they are updated, otherwise the build jobs take more time than they should. ---