Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1515
The new style changes and checks are pretty recent, based on work done by
@RobberPhex.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1515
Fortunately these changes are confined to one file so reviewing it isn't
too bad - hopefully they pass the new php formatting tests in the sca build.
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1515
Please don't change the code style while you are doing unrelated changes,
it makes it very hard to review what *actually* changed. Even with the changes,
there are lots of style inconsistencies
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1515
Please squash your changes to a single commit if possible. Thanks.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1515
THRIFT-4171
---
