Github user huerlisi closed the pull request at:
https://github.com/apache/thrift/pull/411
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user huerlisi commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-93250554
Thanks for the heads up:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-93084562
Given this was committed, you can close the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-90731296
Thanks Simon!
just committed this, please check this for the next PR
https://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it,
GitHub user huerlisi opened a pull request:
https://github.com/apache/thrift/pull/411
Fixes nodejs readme syntax
The README for nodejs examples had strange syntax letting Markdown thinking
everything is a header.
You can merge this pull request into a Git repository by running:
Github user huerlisi commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-87633148
Fixed, ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user huerlisi commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-87639738
The failing test (Haskel:
https://travis-ci.org/apache/thrift/jobs/56395742) seems to be unrelated to my
changes.
---
If your project is set up for it, you can reply
Github user huerlisi commented on the pull request:
https://github.com/apache/thrift/pull/411#issuecomment-87632748
Sorry, accidentally checked in a generated file, will fix and amend the
last commit.
---
If your project is set up for it, you can reply to this email and have your
