Github user sharpdevel commented on the pull request:
https://github.com/apache/thrift/pull/377#issuecomment-93936892
I'm afraid I don't know how to reopen this pull request. Do I have to
create a new one? I already create a Jira-Ticket
GitHub user sharpdevel reopened a pull request:
https://github.com/apache/thrift/pull/377
Issue with IPv6 an IPv4 on windows machines
When using TcpListener and TcpClient it depends on the network
configuration if IPv4 or IPv6 is used. By upgrading the framework to .NET 4.5
the
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/377#issuecomment-93822001
@sharpdevel: Didn't recognize that PR, it somehow got lost in the mails.
Could you file a JIRA ticket and reopen the PR mentioning the ticket number?
I'll take a look at
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/377#issuecomment-93617632
Thanks for your patch @sharpdevel, in order for us to accept a pull request
we need to have a jira ticket associated with it. Please see our contributing
guide at
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/377#issuecomment-75319740
I don't have a better idea, so yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sharpdevel commented on the pull request:
https://github.com/apache/thrift/pull/377#issuecomment-75016334
You are right. Die DualMode also has to be set using reflection. If you
agree with me to head in this direction I will fix it and make another pull
request -
Github user sharpdevel commented on the pull request:
https://github.com/apache/thrift/pull/377#issuecomment-74635670
I could imagine something like this:
if (typeof(TcpClient).GetProperty(DualMode) == null)
{
client = new
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/377#issuecomment-74573196
Can we do something with #ifdefs to protect against when it is not
available?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sharpdevel commented on the pull request:
https://github.com/apache/thrift/pull/377#issuecomment-74489056
You a right: Mono 3.12.0 has no support for the Socket.DualMode property
which I used in my patch. Sorry for not double checking that. As requested I
opened a jira
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/377#issuecomment-74369726
May I ask you to [create a JIRA ticket for
that](thrift.apache.org/docs/HowToContribute)?
Thanks,
JensG
---
If your project is set up for it, you can reply
GitHub user sharpdevel opened a pull request:
https://github.com/apache/thrift/pull/377
Issue with IPv6 an IPv4 on windows machines
When using TcpListener and TcpClient it depends on the network
configuration if IPv4 or IPv6 is used. By upgrading the framework to .NET 4.5
the
11 matches
Mail list logo
