[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-26 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/464 THRIFT-3081 consolidate client processing loop in most TServers This pull request consolidates the client processing loop in the TSimpleServer, TThreadedServer, and TThreadPoolServer. This ensures

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-26 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-10 Thread ben-craig
Github user ben-craig commented on a diff in the pull request: https://github.com/apache/thrift/pull/433#discussion_r28189373 --- Diff: lib/cpp/src/thrift/server/TThreadPoolServer.cpp --- @@ -146,9 +73,12 @@ void TThreadPoolServer::serve() { shared_ptrTProcessor

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-10 Thread ben-craig
Github user ben-craig commented on a diff in the pull request: https://github.com/apache/thrift/pull/433#discussion_r28189526 --- Diff: lib/cpp/src/thrift/server/TConnectedClient.cpp --- @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-09 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/433 THRIFT-3081 consolidate client processing loops This pull request consolidates the client processing loops contained within TSimpleServer, TThreadedServer, TThreadPoolServer that were all similar

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-09 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/428#issuecomment-91361228 Build failed though no fault of my own, so closing this and opening a new one. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-09 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

2015-04-09 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/428#issuecomment-91284246 There was no conflict with master however I need to base THRIFT-3083 on top of these changes so I needed to refresh it. --- If your project is set up for it, you can