[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...

2015-07-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...

2015-07-01 Thread jparise
Github user jparise commented on a diff in the pull request: https://github.com/apache/thrift/pull/535#discussion_r33729457 --- Diff: compiler/cpp/src/generate/t_erl_generator.cc --- @@ -55,6 +55,7 @@ class t_erl_generator : public t_generator { out_dir_base_ = gen-erl;

[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...

2015-07-01 Thread thecodeboss
Github user thecodeboss commented on a diff in the pull request: https://github.com/apache/thrift/pull/535#discussion_r33730165 --- Diff: compiler/cpp/src/generate/t_erl_generator.cc --- @@ -55,6 +55,7 @@ class t_erl_generator : public t_generator { out_dir_base_ =

[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...

2015-06-30 Thread thecodeboss
GitHub user thecodeboss opened a pull request: https://github.com/apache/thrift/pull/535 THRIFT-3214 Add Erlang option for using maps instead of dicts Erlang OTP 18 introduces significant performance improvements when using maps instead of dicts. Here is a benchmark showing the