[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...

2016-01-08 Thread ericklaus-wf
Github user ericklaus-wf commented on the pull request: https://github.com/apache/thrift/pull/755#issuecomment-170096390 @Jens-G Do I need to do anything else to get this PR moving? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...

2016-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/755 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...

2015-12-23 Thread ericklaus-wf
Github user ericklaus-wf commented on the pull request: https://github.com/apache/thrift/pull/755#issuecomment-166932712 The CI build has failed when running the cpp-cpp test twice now. I'm not sure how my python changes could affect this. Am I kicking off the CI incorrectly?

[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...

2015-12-22 Thread ericklaus-wf
Github user ericklaus-wf closed the pull request at: https://github.com/apache/thrift/pull/755 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...

2015-12-22 Thread ericklaus-wf
GitHub user ericklaus-wf reopened a pull request: https://github.com/apache/thrift/pull/755 THRIFT-3499: Add package_prefix to python generator Permit prefixing import paths with a certain string to support devs who will place the generated code below the top level of their python

[GitHub] thrift pull request: THRIFT-3499: Add package_prefix to python gen...

2015-12-22 Thread ericklaus-wf
Github user ericklaus-wf closed the pull request at: https://github.com/apache/thrift/pull/755 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature