[GitHub] thrift pull request: Update simple_json_protocol.go

2014-11-18 Thread cvlchinet
Github user cvlchinet commented on the pull request:

https://github.com/apache/thrift/pull/134#issuecomment-63557119
  
This was fixed in https://github.com/apache/thrift/pull/273.
Can be closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] thrift pull request: Update simple_json_protocol.go

2014-06-12 Thread Jens-G
Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/134#issuecomment-45955641
  
[Could you add an JIRA 
ticket?](http://thrift.apache,.org/docs/HowToContribute)? 
Furthermore, an associated test case would be great as well!
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] thrift pull request: Update simple_json_protocol.go

2014-06-05 Thread hpgood
GitHub user hpgood opened a pull request:

https://github.com/apache/thrift/pull/134

Update simple_json_protocol.go

fix bug:when read the end of message ,don't need ParsePostValue().

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hpgood/thrift patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #134


commit 37cc1b1e0ef47d40db970eac2cfcbf79053e48da
Author: hpgood 35557...@qq.com
Date:   2014-06-06T03:40:20Z

Update simple_json_protocol.go

fix bug:when read the end of message ,don't need ParsePostValue().




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---