Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1507
---
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1507#discussion_r174812332
--- Diff: lib/go/test/dontexportrwtest/compile_test.go ---
@@ -29,10 +28,10 @@ import (
func TestReadWriteMethodsArePrivate(t *testing.T) {
//
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1507#discussion_r174810986
--- Diff: lib/go/test/dontexportrwtest/compile_test.go ---
@@ -29,10 +28,10 @@ import (
func TestReadWriteMethodsArePrivate(t *testing.T) {
// T
GitHub user dcelasun opened a pull request:
https://github.com/apache/thrift/pull/1507
THRIFT-4516: Fix "go vet" warnings for Go 1.10
Opening this here because my free Travis account has its builds killed
after 50 minutes.
You can merge this pull request into a Git repository by ru
