[GitHub] thrift pull request #1509: THRIFT-4515: cross server test improvement: grace...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1509


---

[GitHub] thrift pull request #1509: THRIFT-4515: cross server test improvement: grace...

[jeking3]

GitHub user jeking3 opened a pull request:

https://github.com/apache/thrift/pull/1509

THRIFT-4515: cross server test improvement: graceful test server shutdown

### Problem ###
Test servers are not shut down gracefully - they are SIGKILLed once the 
client exits.

### Solution ###
Try using SIGINT first, capture the result code and process it properly, 
SIGKILL if the process seems unresponsive.

### Also ###
- Better subprocess management in cross test requires Python 3.3 or later 
to run the suite.
- tests.json can declare "stop_signal":  in the server stanza to 
customize this behavior
- Added signal handling to C++, D, and Perl test servers to stop gracefully.
- Cleaned up some C++ library compiler warnings.
- Fixed C++ TSocket error descriptions for domain sockets to use the path 
instead of host/port.
- Fixed an intermittent issue in concurrency_test.
- Perl server had no "stop()" mechanism which was easy to add.
- Updated SBCL (lisp) to 1.4.5 to try and eliminate these "file not found" 
sporadic build issues.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeking3/thrift THRIFT-4515

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1509


commit f1905707c0f7be34e811d2dc4af50a6e06a01364
Author: James E. King III 
Date:   2018-03-16T20:07:42Z

THRIFT-4515: cross server test improvement: graceful test server shutdown

commit 8e116b9af11dc1533725f7806f73ffadff442524
Author: James E. King III 
Date:   2018-03-19T12:16:51Z

THRIFT-82: move to SBCL 1.4.5 (hopefully will address 1.4.4 sporadic build 
errors)




---