[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13531608#comment-13531608
]
Jens Geyer commented on THRIFT-1780:
+1
Looks good so far, I just modified one line
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527546#comment-13527546
]
Jens Geyer commented on THRIFT-1780:
Nice!
But ... using your patch I get without
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527560#comment-13527560
]
Carl Yeksigian commented on THRIFT-1780:
Yes, I agree.
One problem with this
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527576#comment-13527576
]
Jens Geyer commented on THRIFT-1780:
{quote}
One problem with this approach (either
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527637#comment-13527637
]
Jens Geyer commented on THRIFT-1780:
The C# code used to use _isset fields even for
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527643#comment-13527643
]
Jens Geyer commented on THRIFT-1780:
The non-nullable case is broken by the patch,
