[jira] [Commented] (THRIFT-4460) php library use PSR-2

2018-02-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363387#comment-16363387
 ] 

ASF GitHub Bot commented on THRIFT-4460:


Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1472#discussion_r168062703
  
--- Diff: build/docker/scripts/sca.sh ---
@@ -49,6 +49,10 @@ flake8 --ignore=E501 test/test.py
 flake8 --ignore=E501,E722 test/crossrunner
 flake8 test/features
 
+# PHP code style
+composer install --quiet
+./vendor/bin/phpcs
--- End diff --

@RobberPhex this change is causing errors in other builds even though I 
have rebased on master, see:

https://travis-ci.org/apache/thrift/jobs/341109387

I am going to disable it for now.


> php library use PSR-2
> -
>
> Key: THRIFT-4460
> URL: https://issues.apache.org/jira/browse/THRIFT-4460
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
> Fix For: 0.12.0
>
>
> PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4460) php library use PSR-2

2018-01-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336921#comment-16336921
 ] 

ASF GitHub Bot commented on THRIFT-4460:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1472


> php library use PSR-2
> -
>
> Key: THRIFT-4460
> URL: https://issues.apache.org/jira/browse/THRIFT-4460
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
> Fix For: 0.12.0
>
>
> PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4460) php library use PSR-2

2018-01-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334982#comment-16334982
 ] 

ASF GitHub Bot commented on THRIFT-4460:


Github user RobberPhex commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1472#discussion_r163079208
  
--- Diff: build/docker/scripts/sca.sh ---
@@ -49,6 +49,10 @@ flake8 --ignore=E501 test/test.py
 flake8 --ignore=E501,E722 test/crossrunner
 flake8 test/features
 
+# PHP code style
+composer install --quiet
+./vendor/bin/phpcs
--- End diff --

@jeking3 
`phpcs` will check which PHP library match PSR-2.(like `flake8`)


> php library use PSR-2
> -
>
> Key: THRIFT-4460
> URL: https://issues.apache.org/jira/browse/THRIFT-4460
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
>
> PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4460) php library use PSR-2

2018-01-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334629#comment-16334629
 ] 

ASF GitHub Bot commented on THRIFT-4460:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1472
  
Are there any tools we can run as part of the build (like flake8) that 
would validate PSR-2?


> php library use PSR-2
> -
>
> Key: THRIFT-4460
> URL: https://issues.apache.org/jira/browse/THRIFT-4460
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
>
> PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4460) php library use PSR-2

2018-01-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327314#comment-16327314
 ] 

ASF GitHub Bot commented on THRIFT-4460:


Github user RobberPhex commented on the issue:

https://github.com/apache/thrift/pull/1472
  
rebased and squashed


> php library use PSR-2
> -
>
> Key: THRIFT-4460
> URL: https://issues.apache.org/jira/browse/THRIFT-4460
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
>
> PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4460) php library use PSR-2

2018-01-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327159#comment-16327159
 ] 

ASF GitHub Bot commented on THRIFT-4460:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1472
  
Rebase on master as I merged THRIFT-4459.


> php library use PSR-2
> -
>
> Key: THRIFT-4460
> URL: https://issues.apache.org/jira/browse/THRIFT-4460
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
>
> PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4460) php library use PSR-2

2018-01-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326776#comment-16326776
 ] 

ASF GitHub Bot commented on THRIFT-4460:


GitHub user RobberPhex opened a pull request:

https://github.com/apache/thrift/pull/1472

THRIFT-4460: PHP Library use PSR-2

ref https://issues.apache.org/jira/browse/THRIFT-4460

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RobberPhex/thrift psr-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1472.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1472


commit ee05eef38042bb462294055c084a382f0b93328b
Author: Robert Lu 
Date:   2017-11-03T04:27:31Z

reduce php library directory depth

commit cebbf0468c33080c3de6cc3b34772d1fe9a59886
Author: Robert Lu 
Date:   2018-01-15T11:03:13Z

5.5.9

commit 63cf9186ecc8e7f97130ebcbabb0c61080722bce
Author: Robert Lu 
Date:   2017-11-11T01:08:25Z

add php_codesniffer

* ignore composer.lock and vendor

commit feea9044270124ec88f1cf92dfad90de553ac8a1
Author: Robert Lu 
Date:   2018-01-15T12:31:14Z

add php to sca

commit fc6e42109b7910e42e86b40def0158c707911ddd
Author: Robert Lu 
Date:   2018-01-15T12:31:44Z

psr2 format

commit 21aeabb8088db59cb4bf8dcc30499335040fb911
Author: Robert Lu 
Date:   2018-01-16T05:32:35Z

add coding_standards.md




> php library use PSR-2
> -
>
> Key: THRIFT-4460
> URL: https://issues.apache.org/jira/browse/THRIFT-4460
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
>
> PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)