[ https://issues.apache.org/jira/browse/THRIFT-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525174#comment-16525174 ]
Brian Forbis commented on THRIFT-4520: -------------------------------------- +1. Furthermore, rather than forever supportingĀ multiple --gen flags to generate types of code that are compatible with various versions of JS, couldn't we just generate one modern version and suggest for users to use something like Babel to transpile to something compatible in their environment? It may make for easier maintenance / less bugs. > Modernize JS/node > ----------------- > > Key: THRIFT-4520 > URL: https://issues.apache.org/jira/browse/THRIFT-4520 > Project: Thrift > Issue Type: Wish > Components: JavaScript - Compiler, JavaScript - Library, Node.js - > Compiler, Node.js - Library > Reporter: Philip Frank > Priority: Minor > > This is just a wishlist for now, I consider tackling some of the points when > I have downtime. As [~jking3] proposed, these incompatible changes would live > in separate "js2" and "node2" directories. Feedback and additions are welcome! > * De-duplicte implementations of JS and node, including: > ** Thrift.TJSONProtocol > ** Thrift.MultiplexProtocol > ** Thrift.Type > ** Thrift.MessageType > ** various Exception types > * Drop support for synchronous service calls (js+node), jquery based calls > (js) and maybe even async "callback as last argument" calls; embrace Promise > as return value > * integrate JS with "make cross" test suite, possibly using karma and > chrome-headless, drop grunt/phantom-based test workflow > * Bonus: publish smaller npm packages for browser and node, which include > only the lib -- This message was sent by Atlassian JIRA (v7.6.3#76005)