Re: Constants interface

2007-04-12 Thread David H. DeWolf
oh, sorry, I wasn't paying attention that well :) Antonio Petrelli wrote: 2007/4/12, David H. DeWolf <[EMAIL PROTECTED]>: In the future, since we're on java5, these types of constants should probably by enums anyways. enums? They are used as attribute names in request and session scope! Anto

Re: Constants interface

2007-04-12 Thread Antonio Petrelli
2007/4/12, David H. DeWolf <[EMAIL PROTECTED]>: In the future, since we're on java5, these types of constants should probably by enums anyways. enums? They are used as attribute names in request and session scope! Antonio

Re: Constants interface

2007-04-12 Thread David H. DeWolf
Agreed. I'm all for it. In the future, since we're on java5, these types of constants should probably by enums anyways. Antonio Petrelli wrote: Hi all! When generating the Checkstyle report I noticed that it does not like the "Constants" interface, because it contains only constant fields (

Constants interface

2007-04-12 Thread Antonio Petrelli
Hi all! When generating the Checkstyle report I noticed that it does not like the "Constants" interface, because it contains only constant fields (and no methods). So I was trying to remove it at all, since it contains only two constants: ATTRIBUTE_CONTEXT_STACK is used only in BasicAttributeConte

Re: Checkstyle doubts

2007-04-12 Thread Antonio Petrelli
Ok, after reviewing the answers, I will remove the "generics angular brackets whitespace-around" rule, but will maintain the "no public in interfaces" rule. Antonio 2007/4/5, Nathan Bubna <[EMAIL PROTECTED]>: On 4/5/07, Martin Cooper <[EMAIL PROTECTED]> wrote: > On 4/5/07, David H. DeWolf <[EMA

Tiles entry points (WAS: Re: [VOTE] 2.0.3 Release Quality)

2007-04-12 Thread Antonio Petrelli
2007/4/11, David H. DeWolf <[EMAIL PROTECTED]>: Greg Reddin wrote: > On 4/11/07, David H. DeWolf <[EMAIL PROTECTED]> wrote: > It does seem that TilesDecorationFilter and TilesDispatchServlet are > misplaced. Personally I think all these things should be in tiles-core > instead of tiles-api. P