[jira] [Commented] (TINKERPOP-1535) Bump to support Giraph 1.2.0.

[ https://issues.apache.org/jira/browse/TINKERPOP-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100982#comment-16100982 ] ASF GitHub Bot commented on TINKERPOP-1535: --- Github user spmallette commente

[GitHub] tinkerpop issue #681: TINKERPOP-1535: Bump to support Giraph 1.2.0.

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/681 All tests pass with `docker/build.sh -t -n -i` VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[jira] [Commented] (TINKERPOP-1535) Bump to support Giraph 1.2.0.

[ https://issues.apache.org/jira/browse/TINKERPOP-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100961#comment-16100961 ] ASF GitHub Bot commented on TINKERPOP-1535: --- Github user okram commented on

[GitHub] tinkerpop issue #681: TINKERPOP-1535: Bump to support Giraph 1.2.0.

Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/681 ``` [INFO] [INFO] BUILD SUCCESS [INFO]

[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100901#comment-16100901 ] ASF GitHub Bot commented on TINKERPOP-1736: --- Github user okram commented on

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/682 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[jira] [Updated] (TINKERPOP-1737) Validate and throw an exception when maxContentLength overflows

[ https://issues.apache.org/jira/browse/TINKERPOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Hanna updated TINKERPOP-1737: Priority: Trivial (was: Major) > Validate and throw an exception when maxContentLength

[jira] [Created] (TINKERPOP-1737) Validate and throw an exception when maxContentLength overflows

Jeremy Hanna created TINKERPOP-1737: --- Summary: Validate and throw an exception when maxContentLength overflows Key: TINKERPOP-1737 URL: https://issues.apache.org/jira/browse/TINKERPOP-1737 Project:

[jira] [Updated] (TINKERPOP-1737) Validate and throw an exception when maxContentLength overflows

[ https://issues.apache.org/jira/browse/TINKERPOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Hanna updated TINKERPOP-1737: Description: If you set the {{maxContentLength}} to higher than {{Integer.MAX_VALUE}} it

[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100796#comment-16100796 ] ASF GitHub Bot commented on TINKERPOP-1736: --- Github user robertdale commente

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/682 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100756#comment-16100756 ] ASF GitHub Bot commented on TINKERPOP-1736: --- GitHub user dkuppitz opened a p

[GitHub] tinkerpop pull request #682: TINKERPOP-1736 Sack step evaluated by groovy in...

GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/682 TINKERPOP-1736 Sack step evaluated by groovy interprets numbers in an unexpected way https://issues.apache.org/jira/browse/TINKERPOP-1736 Fixed a bug in `BigDecimal` divisions in `Numbe

[jira] [Assigned] (TINKERPOP-1535) Bump to support Giraph 1.2.0.

[ https://issues.apache.org/jira/browse/TINKERPOP-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marko A. Rodriguez reassigned TINKERPOP-1535: - Assignee: Marko A. Rodriguez > Bump to support Giraph 1.2.0. > --

[jira] [Commented] (TINKERPOP-1535) Bump to support Giraph 1.2.0.

[ https://issues.apache.org/jira/browse/TINKERPOP-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100713#comment-16100713 ] ASF GitHub Bot commented on TINKERPOP-1535: --- GitHub user okram opened a pull

[GitHub] tinkerpop pull request #681: TINKERPOP-1535: Bump to support Giraph 1.2.0.

GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/681 TINKERPOP-1535: Bump to support Giraph 1.2.0. https://issues.apache.org/jira/browse/TINKERPOP-1535 I bumped Giraph from 1.1.0 to 1.20. It was a pretty straight forward upgrade. There was o

[jira] [Closed] (TINKERPOP-1715) Bump to Spark 2.2

[ https://issues.apache.org/jira/browse/TINKERPOP-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marko A. Rodriguez closed TINKERPOP-1715. - Resolution: Fixed Assignee: Marko A. Rodriguez Fix Version/s: 3

[jira] [Created] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

stephen mallette created TINKERPOP-1736: --- Summary: Sack step evaluated by groovy interprets numbers in an unexpected way Key: TINKERPOP-1736 URL: https://issues.apache.org/jira/browse/TINKERPOP-1736

Re: groovy, numbers and sack

Yes, looks like only BigDecimal div. BigInteger doesn't take a rounding mode and everything else appears to be done at the primitive level. Robert Dale On Tue, Jul 25, 2017 at 10:34 AM, Daniel Kuppitz wrote: > Yea, using the snippet provided by Robert, this can easily be fixed in > NumberHelper

Re: groovy, numbers and sack

Yea, using the snippet provided by Robert, this can easily be fixed in NumberHelper. It only affects div, right? Cheers, Daniel On Tue, Jul 25, 2017 at 3:41 PM, Marko Rodriguez wrote: > Hi, > > Does Kuppitz’ NumberHelper come into play here? > > https://github.com/apache/tinkerpop/blob

Re: groovy, numbers and sack

Hi, Does Kuppitz’ NumberHelper come into play here? https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/NumberHelper.java

Re: groovy, numbers and sack

I think gremlin should handle this case. It's a matter of setting the MathContext precision. I was trying to reproduce this in the shell but couldn't. Here's why and what groovy does: public Number divideImpl(Number left, Number right) { BigDecimal bigLeft = toBigDecimal(left);

groovy, numbers and sack

Dan "The Stroke" LaRocque gave me some gory details on groovy's handling of decimals/numbers which can make sack() do this: gremlin> g.withSack(2).V().sack(div).by(constant(3.0)).sack() Non-terminating decimal expansion; no exact representable decimal result. Type ':help' or ':h' for help. Display