[jira] [Commented] (TINKERPOP-1801) OLAP profile() step return incorrect timing

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225848#comment-16225848 ] ASF GitHub Bot commented on TINKERPOP-1801: --- Github user spmallette commente

[GitHub] tinkerpop issue #734: TINKERPOP-1801: fix profile() timing in OLAP by adding...

2017-10-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/734 @okram if all looks good to you after artem's changes you should be free to merge this now: All tests pass with `docker/build.sh -t -n -i` VOTE +1 ---

[jira] [Commented] (TINKERPOP-1821) Consistent behavior of self-referencing edges

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225768#comment-16225768 ] ASF GitHub Bot commented on TINKERPOP-1821: --- GitHub user okram opened a pull

[GitHub] tinkerpop pull request #739: TINKERPOP-1821: Consistent behavior of self-ref...

2017-10-30 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/739 TINKERPOP-1821: Consistent behavior of self-referencing edges https://issues.apache.org/jira/browse/TINKERPOP-1821 Added test for self-edges and fixed a semantic issue in `Neo4jGraph` rega

Re: [DISCUSS] GLV Test Suite

2017-10-30 Thread Stephen Mallette
I guess there wouldn't be a problem with that, though having it the way it works now was a nice check to ensure that the ScriptEngine was configured properly. I guess that shouldn't be the focus on this body of tests though. We should be more concerned that the elements of the Gremlin language actu

[jira] [Updated] (TINKERPOP-1820) Include Python and .NET GLV tests on TravisCI

2017-10-30 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1820: Issue Type: Improvement (was: Test) > Include Python and .NET GLV tests on Trav

Re: CountStrategy and TraversalHelper.replaceStep

2017-10-30 Thread pieter gmail
Ok great, I'll test a bit with the order changed. Thanks, Pieter On 30/10/2017 18:01, Daniel Kuppitz wrote: Ah, yea, I see what you mean. It's actually replaceStep() which is buggy, not the strategy. The fix is easy, we just need to change the order of the 2 statements in replaceStep(): public

Re: CountStrategy and TraversalHelper.replaceStep

2017-10-30 Thread Daniel Kuppitz
Ah, yea, I see what you mean. It's actually replaceStep() which is buggy, not the strategy. The fix is easy, we just need to change the order of the 2 statements in replaceStep(): public static void replaceStep(final Step removeStep, final Step insertStep, final Traversal.Admin traversal) { f

[jira] [Created] (TINKERPOP-1821) Consistent behavior of self-referencing edges

2017-10-30 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-1821: --- Summary: Consistent behavior of self-referencing edges Key: TINKERPOP-1821 URL: https://issues.apache.org/jira/browse/TINKERPOP-1821 Project: TinkerPop

[jira] [Commented] (TINKERPOP-1819) documentation query and description mismatch

2017-10-30 Thread Chandran Anjur Narasimhan (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225084#comment-16225084 ] Chandran Anjur Narasimhan commented on TINKERPOP-1819: -- That was

Re: CountStrategy and TraversalHelper.replaceStep

2017-10-30 Thread pieter gmail
I am on the latest 3.3.1-SNAPSHOT, just pulled master again. The actual traversals and results are correct. However after the CountStrategy the VertexStep(OUT,edge) previousStep pointer (AbstractStep.previousStep) is incorrect. I should be EmptyStep but infact points to the newly inserted NotS

[jira] [Commented] (TINKERPOP-1820) Include Python and .NET GLV tests on TravisCI

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225044#comment-16225044 ] ASF GitHub Bot commented on TINKERPOP-1820: --- Github user jorgebay commented

[GitHub] tinkerpop issue #738: TINKERPOP-1820 Include Python and .NET GLVs on TravisC...

2017-10-30 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/738 > I see that you used the -q option. What happens if there is a failure in native python tests? currently i don't see any output for those, i'm wondering how that will fail when it does.

Re: CountStrategy and TraversalHelper.replaceStep

2017-10-30 Thread Daniel Kuppitz
I don't see any issues. Which version are you talking about? *gremlin> Gremlin.version()* *==>3.2.7-SNAPSHOT* gremlin> g = TinkerFactory.createModern().traversal() ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard] gremlin> g.V(1).repeat(out()).until(__.not(outE())).values('name')

[jira] [Commented] (TINKERPOP-1801) OLAP profile() step return incorrect timing

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224914#comment-16224914 ] ASF GitHub Bot commented on TINKERPOP-1801: --- Github user artem-aliev comment

[GitHub] tinkerpop issue #734: TINKERPOP-1801: fix profile() timing in OLAP by adding...

2017-10-30 Thread artem-aliev
Github user artem-aliev commented on the issue: https://github.com/apache/tinkerpop/pull/734 I have fixed test failures. TinkerPopComputer does not call ComputerPorgram.execute methods if spit has no vertices. For example: modern graph has 6 vertices but computer has 8

[jira] [Closed] (TINKERPOP-1819) documentation query and description mismatch

2017-10-30 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1819. --- Resolution: Fixed Assignee: stephen mallette Fix Version/s: 3.3.1

[jira] [Commented] (TINKERPOP-1752) Gremlin.Net: Generate completely type-safe methods

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224829#comment-16224829 ] ASF GitHub Bot commented on TINKERPOP-1752: --- Github user jorgebay commented

[GitHub] tinkerpop issue #712: TINKERPOP-1752: Gremlin.Net: Generate completely type-...

2017-10-30 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/712 Yes it builds, this PR is good to go on my end! Sorry I forgot to confirm on Friday :/ ---

[jira] [Commented] (TINKERPOP-1752) Gremlin.Net: Generate completely type-safe methods

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224828#comment-16224828 ] ASF GitHub Bot commented on TINKERPOP-1752: --- Github user spmallette commente

[GitHub] tinkerpop issue #712: TINKERPOP-1752: Gremlin.Net: Generate completely type-...

2017-10-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/712 @jorgebay did the docker build ever finish successfully? ---

[GitHub] tinkerpop issue #738: TINKERPOP-1820 Include Python and .NET GLVs on TravisC...

2017-10-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/738 I see that you used the `-q` option. What happens if there is a failure in native python tests? currently i don't see any output for those, i'm wondering how that will fail when it does.

[jira] [Commented] (TINKERPOP-1820) Include Python and .NET GLV tests on TravisCI

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224661#comment-16224661 ] ASF GitHub Bot commented on TINKERPOP-1820: --- Github user spmallette commente

[jira] [Commented] (TINKERPOP-1820) Include Python and .NET GLV tests on TravisCI

2017-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224540#comment-16224540 ] ASF GitHub Bot commented on TINKERPOP-1820: --- GitHub user jorgebay opened a p

[GitHub] tinkerpop pull request #738: TINKERPOP-1820 Include Python and .NET GLVs on ...

2017-10-30 Thread jorgebay
GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/738 TINKERPOP-1820 Include Python and .NET GLVs on TravisCI https://issues.apache.org/jira/browse/TINKERPOP-1820 Run Python and .NET GLV tests on travis CI. You can merge this pull request

[jira] [Created] (TINKERPOP-1820) Include Python and .NET GLV tests on TravisCI

2017-10-30 Thread Jorge Bay (JIRA)
Jorge Bay created TINKERPOP-1820: Summary: Include Python and .NET GLV tests on TravisCI Key: TINKERPOP-1820 URL: https://issues.apache.org/jira/browse/TINKERPOP-1820 Project: TinkerPop Issue

CountStrategy and TraversalHelper.replaceStep

2017-10-30 Thread pieter gmail
Hi, Whilst optimizing the NotStep I came across what looks to me like a bug in TraversalHelper.replaceStep or perhaps rather in CountStrategy. The test below shows the bug.     @Test     public void g_VX1X_repeatXoutX_untilXoutE_count_isX0XX_name() {     Graph graph = TinkerFactory.create