[jira] [Commented] (TINKERPOP-1830) Race condition in Tinkergraph index creation

2017-11-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248724#comment-16248724 ] ASF GitHub Bot commented on TINKERPOP-1830: --- Github user mpollmeier commented on the issue:

[GitHub] tinkerpop issue #745: TINKERPOP-1830: fix race condition in TinkerIndex

2017-11-11 Thread mpollmeier
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/745 Instead of marking them as final I simply dropped the assignment. Re tp32: yes, I also mentioned this in the description of the ticket. I've just squashed all commits and rebased onto tp32

Re: CountStrategy and TraversalHelper.replaceStep

2017-11-11 Thread pieter gmail
Created a jira for this. I tested your fix and all tests are passing again. Sqlg and TinkerGraph. Thanks Pieter On 30/10/2017 18:01, Daniel Kuppitz wrote: Ah, yea, I see what you mean. It's actually replaceStep() which is buggy, not the

[jira] [Created] (TINKERPOP-1832) TraversalHelper.replaceStep sets previousStep to the wrong step

2017-11-11 Thread pieter martin (JIRA)
pieter martin created TINKERPOP-1832: Summary: TraversalHelper.replaceStep sets previousStep to the wrong step Key: TINKERPOP-1832 URL: https://issues.apache.org/jira/browse/TINKERPOP-1832

[jira] [Commented] (TINKERPOP-1830) Race condition in Tinkergraph index creation

2017-11-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248449#comment-16248449 ] ASF GitHub Bot commented on TINKERPOP-1830: --- Github user spmallette commented on a diff in

[jira] [Commented] (TINKERPOP-1830) Race condition in Tinkergraph index creation

2017-11-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248450#comment-16248450 ] ASF GitHub Bot commented on TINKERPOP-1830: --- Github user spmallette commented on the issue:

[jira] [Commented] (TINKERPOP-1830) Race condition in Tinkergraph index creation

2017-11-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248448#comment-16248448 ] ASF GitHub Bot commented on TINKERPOP-1830: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop issue #745: TINKERPOP-1830: fix race condition in TinkerIndex

2017-11-11 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/745 Please also include an update to CHANGELOG for this fix. ---

[GitHub] tinkerpop pull request #745: TINKERPOP-1830: fix race condition in TinkerInd...

2017-11-11 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/745#discussion_r150381086 --- Diff: tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerIndex.java --- @@ -48,17 +48,18 @@ public

[GitHub] tinkerpop pull request #745: TINKERPOP-1830: fix race condition in TinkerInd...

2017-11-11 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/745#discussion_r150381081 --- Diff: tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerIndex.java --- @@ -48,17 +48,18 @@ public